From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00068.outbound.protection.outlook.com [40.107.0.68]) by dpdk.org (Postfix) with ESMTP id 3D33F4B4B for ; Mon, 13 Aug 2018 22:42:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0+EuBZ6lUzNixCh+F2axnDjuv4y7DBH4L0mh3wbHJ54=; b=AfbP7hXyisryvacB7HXVqrUg27IxPUOBrs3EHCSZPiMbsoIjyHBGrrvBCB4L/R909cyLcttulTAsx1bIsrdTm+tNMZWlLDBt90zN1EhEOXr5yFGz7yMbUqhOxtUwNJQLSuU5J7BSAlG2Il8KjV5kCkf02FR4AOOQIjBhRHjgZdY= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by DB3PR0502MB3980.eurprd05.prod.outlook.com (2603:10a6:8:10::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1017.18; Mon, 13 Aug 2018 20:42:37 +0000 From: Yongseok Koh To: Radu Nicolau Cc: Chas Williams , dpdk stable Date: Mon, 13 Aug 2018 13:42:09 -0700 Message-Id: <20180813204213.25436-6-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180813204213.25436-1-yskoh@mellanox.com> References: <20180813204213.25436-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: MWHPR19CA0084.namprd19.prod.outlook.com (2603:10b6:320:1f::22) To DB3PR0502MB3980.eurprd05.prod.outlook.com (2603:10a6:8:10::27) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f2bc1a1e-a724-431c-10a1-08d6015d4ea1 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB3980; X-Microsoft-Exchange-Diagnostics: 1; DB3PR0502MB3980; 3:qWn7ojCgJ73WO8qLMDuR3XnOHfqGEDRtA1o+auC+I10hCGC1+QLjkh3dKBVNN2yQ1v9UYqzbAvyYRa0c1C8cLr6F3vSOY4RUdwj0hfgyA2/eyv3KtQUPh74vbPY+sFVIN7j43cq/ZyDq5l4X+w4N+joZGo0uFF4nraR1orf2ZBam0ZeCWpj6KkGe3Ji0wFGc/y0TWXaZar8ue5TOj9L9B2X4YBsfVrFnvUftAhepVeJrP53BRmMkj1QlbwrXJ5B3; 25:QnwS4g0jBKeAv6fHQk/LBtGmG7FVK/EqwMOK1ZAI2bJu40uFMiVhra2KCzEqj9SdNJ1yVnyj9vlzbyGK4upCGxdClBfDgPgNJqCNtKDL9PJb7ge2R+08/loHRxbpNa/QKhkRxyVMDxnwf7j6BKeU2SGtBM2TG+BxieYLm8mxH9qLIAcOTAXBolK7Vu82q61akrECRg1Jn66B0Pd6k8xztQuL7nh+j3spqyOvpCyDeMuqGlvA42UiQGYnKJhOQcV+/2VJSt0D1WGaPwAUYRV45fFOeHuibDZHxhcFlFBAKPXJmP+eH+n7XCg6TTcZAPG2KiSt3wRVO9m2SAOiYkoRWg==; 31:nF9RjE1pV4UIVoEX4Pvo7jCZonhW07Jv9iAnlxNyiwI4hEwV4l0Vn1TiZVVLuFH94gW71YF4GTEGvK4O0HlC/2yoPHKVXB5Hsl8MwyW5KFZXMrGHhpZIkwacxj/SNkz8Gz8MwJl3n3JnTdxVJa18PE0o0zUn81JynsIZVvzvDL6od3o5lA4Hg/43mtRYuxpgYORmzd9djDvkDuszqi/n5l2Rs/r2TNlS2FO/t5xgknM= X-MS-TrafficTypeDiagnostic: DB3PR0502MB3980: X-Microsoft-Exchange-Diagnostics: 1; DB3PR0502MB3980; 20:9zS2pGq2CzFW+wIu3iTit9Ntu/0dCl0OxyLgoq6dyMo0GVQgHriSCGrlljSk58/PScl15TeiYzH5dh3KYLojIjCGpDZXSQzZOk/XTq++SxehM8Kp2dI3Po7ISmhj8lsGhZFv5VaddveGjrsfv9iYfkQ2t81CWoXp0Nziq8CHaPkkyYaGeQkqMSfgCuYaPXJx+5A1+MP5jRdF/EDgCrhOac/g12WPpu2ZjOJZjxADZ2gu3dxJPbmJoj6U5czLW62c0dvg14JCqM0Jx1H5xuM3uICQyNkLIvtTdAOSubB7/i8LM2yUJrEEjul6MscirwJxA+uoJCbPO3+vPKg2vGzKs9L2QRbDpuJ1Qlp393tyCgWWWrWmIJcWAgG7UfdRENfON0Ebvc3Fmy7DLOKbYOykiUihwuraBHJB7L9UW5cl8M4JIwHN1TnG1TQUyv8FBEf6dKV/vN1QXX4eeNgD6B5oKLOQ0n10f1P93UseMRS22nULvytZqMYSaikM7Q+1cKJc; 4:xcgFnqAj4G8OcYAMyjRisJnh9D3tLp/IqyN6rBVE2bA1JSsado/z0xLZYlRFbawEmTd8eFVJDlbBSaOp4IB866K2xbgpvQVYORF36BCBtUB3QWPtjHkhLQ1aU9i4cz5jPCzuYd7zJIZf47oj040yZcM3HfEfs53qu2F8yBv9NR1hXnAlcxZe0FBEaxDOXGzq+sdqH0Ga538Cmq15iLKtUdCMTTe48KbUPpVoOFD6TL2kBsc3DbBbDEOQteUgOCbePvHtxHbF4Am9rTokAnBqj1ORNoAaDvoHVLebBAsn3de5hMhnSYGB5MGF/QcmteFjNFfTZW11k0weutjJC55LlvM0W39v9ViM+idk7l7dlrE= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(97927398514766)(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(823301033)(93006095)(93001095)(3002001)(3231311)(944501410)(52105095)(10201501046)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:DB3PR0502MB3980; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0502MB3980; X-Forefront-PRVS: 07630F72AD X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(346002)(136003)(366004)(39860400002)(376002)(189003)(199004)(28163001)(69234005)(105586002)(106356001)(97736004)(76176011)(16526019)(26005)(186003)(446003)(11346002)(2616005)(956004)(14444005)(36756003)(50466002)(486006)(69596002)(21086003)(6916009)(476003)(53936002)(53376002)(48376002)(386003)(7736002)(6666003)(1720100001)(66066001)(305945005)(47776003)(478600001)(7696005)(53546011)(51416003)(25786009)(52116002)(4326008)(966005)(55016002)(6306002)(54906003)(16586007)(86362001)(5660300001)(3846002)(8676002)(6116002)(8936002)(316002)(81166006)(68736007)(50226002)(1076002)(2906002)(81156014); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3980; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB3PR0502MB3980; 23:krjTSZBAJNo/+ifOdTci2xotcJf63EIbG9KQ/FP?= =?us-ascii?Q?8ZEsJ/xplaT9mSHbcy+CkI0CyQGNEDWVk8vB40AYM5RQrEB3CMDZDNvZnnNw?= =?us-ascii?Q?a/QPNluLEK2vudwF19PosC0qCqbc0At9ePuLLBg0PnS6y/bnCS5Cgs8LjKx4?= =?us-ascii?Q?aXICE5Eh67DohwEnhJ/qZcolW5ETGVBCdY/aRB+zGsRd8kgs1svPnYfMVyMQ?= =?us-ascii?Q?rv4uNMqzOGM6bfyfHwv4UGwUqP2GE2Di6dhA0kFS5UQoIak9xFC4YOJWh5Y8?= =?us-ascii?Q?GBgqBjB9wOge7wm1alPpT/05g4akaD+MhubKd07MjqMIJRRIVJKIu3mv8V9i?= =?us-ascii?Q?/zaEPMCDXRl4fWm4DwbEiYXuqkZDx1Q5FI2wNT3nxsLX+xSQGaUypO8+JAVA?= =?us-ascii?Q?fT1ta/26faQeLlcRDntDaqr+sl4Yd7QFWT/COJX/M61CR4f5vwhLfSeo+J6X?= =?us-ascii?Q?rCOh9iOE1gnar6dTqUAEjfi4t/Kd+/yAF9LXSn3cav2UiTCB2ubg3KR9WqqY?= =?us-ascii?Q?ooygXcrxdwaYlq5nkxvguT1XejmiCG49c++LyCowBSXMnmJAZFInYWFQjORj?= =?us-ascii?Q?VRxDoJC63z18Z4RnA3qQNdPO8AsBHQtXZ1Kch8m4Pvfhf94Zqu5iT3oFUaWU?= =?us-ascii?Q?ymUvgHgJ2F8ac7a58vWtv7A211gWiy9w7CHntN3M5ebLfUu+hSnLxL9xkv0d?= =?us-ascii?Q?LodIeRqzFM8zweG2OndCBDSXS4CVMM7ZnAB7JSDSSAqYOF0cmf0anuHSZ72Y?= =?us-ascii?Q?+L99QLEvUa0jjJoW7w0iXlvx7diASBwgZPytqhyAEyobp0DCKqaLybTNONIo?= =?us-ascii?Q?1+6VYeTlEUttO5wGKvZZPF9Mz5QUNdKjtr55S3ZjBKugi0FC/GKyRqhT6mc6?= =?us-ascii?Q?1KPQArrsXrird5CwiLwDfE17WCnlppF6nSpc5TOPBrQD0fG0xn2qXCWxORfz?= =?us-ascii?Q?hc34SCiRcAYaM77o0kWdpXyeSZPFcWmDyYPGRlOX4S8Xg2EiW9CfrA1ftchs?= =?us-ascii?Q?2lf5k9mYIbPhuCRXvUetphFlY2yymi6GX0gRIqfJLghjjRW+LGqMoog4/7zV?= =?us-ascii?Q?i0KFJZHoqSyMAzZfFhltgjmN3wL67BgdTmuLtYmV/b51VDMlLxv+wWbmQWm3?= =?us-ascii?Q?rcBl/a8NdjuiiEA+AH451tYpec9U2P7jXHYDPMIAnNOgZfQ3ZCrr+j6HAs12?= =?us-ascii?Q?XAbcY142wWUTRzoCvpouoREJhor4gLtt2G4G3ev/THlmO1UifyUNJIpPNi0g?= =?us-ascii?Q?W6RJ6NWyePAlApjtKrV8M5oYG+94LFVQ+0OcdLSEkipvCUBgZLY1wKt5nmcy?= =?us-ascii?Q?tel0YCklvDsoz7Dr/qGqRY5i2/1C4lKr1Psr5ThycIKj2YIBVYX/H0zde+vi?= =?us-ascii?Q?BGYsg/AjsvY8RQXKvQwLRohc8OOxt68zzPAjlOp0RP48ps3QO?= X-Microsoft-Antispam-Message-Info: TXyaxZzhHxeqJTTrQ/bqgeauHntYVJ3WJH/Ie9YIuIkbwVwJZtLC0/R3XKTHxSTA2E81gP9aeQT123OejSvHBlkWrlN1dQqJGw/EPdphBWF/kAHLVBWiBBo5pTScwY0UOTJDjkbb2MvkYUBvP1rNk1p1cvjNebespIXQvUEE7AcxDdXPLmmT5ATKyfoOL8CVSY3g818d8fSK9sVJvfCHpA4hb7Vl8pf1PxlTWkSDurOORB4TV/NzsuY6hRD+IXBVr2LXcOtbqX8tQgjcJnGpYIygCnETyKE8rWsDD70Fcs/4dImrCkiuxaoKDd/4pPeECEgyjuSoHzrLa7H/Ona1GLMZh9yKjeJ/2Z9RZ7KFaBc= X-Microsoft-Exchange-Diagnostics: 1; DB3PR0502MB3980; 6:rhlmojU7NFp+D0Wrhwcm778Ouvs77+Iiy6ddi+5p+S9Gy9hideLvsHaDD050C0aZ5ffwOQKQr3BQV9JBwz7CWM9Rk1keUhHQ8+p4EElmE6rK40aj/8Xgeh8xmopxBKrWonxtZEHdpVfr3gwbpSDJ9JQh5sQW3wWbclGAHVybTQLw3v32Heft4fRm3MKGM+5+ZPQy0/ooaLeB/v9Glm9nyndIvKW6DJuoWO4ar7QRBU93R3/n9fJsFEnYOXQAQHSeMqrDopZoNR9NiAL3YDHAHKLkI3Nm9cLssn/NAv1SBbqK6DKt8z5JK5Nzlgx8yVp+xeb8h3aiWcA8001CH4ttXyb7RSeHaE8nEfU+xRpGE0claSZCG9Ooi2K2JNoKPGyEgyu5qLkk3kQS8wHJV3ksPq+DJdGglyg3KgnGqGuKSCD5JF6pWc7DrtUUBtqB2Wgl6res8JaZy5LE/LX4u2EhSw==; 5:p/82u0vISBChT/3lSwKYjes+1x2FPNWh8rE7FeASNtWtSxs2BQKA92PIecm+0d530hZP/aoZsZV/+cRH2ptOOeTivHwJoeHT5XLSiXgbqSlZXHs9fKd/nhGL0rXEaDEKnCJYTqTma76uuj7ATSLTk+weVNaOwMXxdVDhVf+1hV4=; 7:c3xYOUGPvL/cZawkD7Gce6vi85i1xHjTvglR7EIerxQhjGauF0kdXNPV/ETvGcvnwXmdsk9VsNeHiNFIdmp1kUPqsHofJYVg4cLvdZhYYGRJfuF/Lx2D6gHd9aslQC5u8E5/AY1eE2APR2avovJSwIXmgWmf0Vy6N6gNKymapBwae1jtYVP8qX4i2+xm3RSyCwb9xDLAO4hqA6Ov3fGLRptEGif8M/sFFPv5ZfKR8ub4L5XqbaYPrI6X9nG4Fv2D SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Aug 2018 20:42:37.2601 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f2bc1a1e-a724-431c-10a1-08d6015d4ea1 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3980 Subject: [dpdk-stable] patch 'net/bonding: fix race condition' has been queued to LTS release 17.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Aug 2018 20:42:39 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/15/18. So please shout if anyone has objections. Thanks. Yongseok --- >>From 49806dcbbaa2807e7883594b30b9b48f7a4ece3d Mon Sep 17 00:00:00 2001 From: Radu Nicolau Date: Wed, 25 Jul 2018 10:39:40 +0100 Subject: [PATCH] net/bonding: fix race condition [ upstream commit 5922ff069fb910946f97780754ad4b66b987d5b6 ] Race condition can appear in the bond_mode_8023ad_periodic_cb() callback when bonding port is stopped, reconfigured and restarted. Re-ordered calls in bond_ethdev_start() to have callback alarm set after slave ports are reconfigured. Fixes: 2efb58cbab6e ("bond: new link bonding library") Signed-off-by: Radu Nicolau Acked-by: Chas Williams --- drivers/net/bonding/rte_eth_bond_pmd.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index 98515bc39..8880231ea 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c @@ -1932,10 +1932,6 @@ bond_ethdev_start(struct rte_eth_dev *eth_dev) } } - /* Update all slave devices MACs*/ - if (mac_address_slaves_update(eth_dev) != 0) - goto out_err; - /* If bonded device is configure in promiscuous mode then re-apply config */ if (internals->promiscuous_en) bond_ethdev_promiscuous_enable(eth_dev); @@ -1976,6 +1972,10 @@ bond_ethdev_start(struct rte_eth_dev *eth_dev) (void *)&rte_eth_devices[internals->port_id]); } + /* Update all slave devices MACs*/ + if (mac_address_slaves_update(eth_dev) != 0) + goto out_err; + if (internals->user_defined_primary_port) bond_ethdev_primary_set(internals, internals->primary_port); -- 2.11.0