From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00077.outbound.protection.outlook.com [40.107.0.77]) by dpdk.org (Postfix) with ESMTP id 274E147CD for ; Mon, 13 Aug 2018 22:42:41 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vu7FD0RVmNLr1vUbC+rMKmZg4Nu9imtxYhwZ3wiHiIg=; b=ZoYjnaJCXNGWI9soUK4jFQZEovTwpUaqtDpJrwKi5kEGjj0FBPDXPNJ2CLAFXQSYoR6+HJnTNICrdVAtKh/0ATrdUZTHvXYOn1JSVqov+3OzhZZN1IuWdpFm1pNU09kIpXPGrv+Mcrsaek/UAdnbwhiY3HInm6pqnWLrxKsxkcM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by DB3PR0502MB3980.eurprd05.prod.outlook.com (2603:10a6:8:10::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1017.18; Mon, 13 Aug 2018 20:42:38 +0000 From: Yongseok Koh To: Harry van Haaren Cc: Jerin Jacob , dpdk stable Date: Mon, 13 Aug 2018 13:42:10 -0700 Message-Id: <20180813204213.25436-7-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180813204213.25436-1-yskoh@mellanox.com> References: <20180813204213.25436-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: MWHPR19CA0084.namprd19.prod.outlook.com (2603:10b6:320:1f::22) To DB3PR0502MB3980.eurprd05.prod.outlook.com (2603:10a6:8:10::27) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 36de91e9-0e0f-4423-3566-08d6015d4f8e X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB3980; X-Microsoft-Exchange-Diagnostics: 1; DB3PR0502MB3980; 3:vPQqgVf5VH4MXx3Vf63AYIqR48qgo3sFt2331+4woDE4oAZDwKvB7a4D8idXMqY7/HdDtDebu3lGgh2bfX12KufswEO1oawrI9hUINzzeQ7KBV86V7dQhCXqiPVWslrk/Qr77DWkcJIQ5sdFQLu989C+/zCdOH0P+44n+RQ93XVkDRmwer00S9UQx4SYz2cwmIV4DLIHRPQfAkNrCXtzdACCQUPUZHgWiSI4Wh3lPPa8yFKlrLZsP3c95q8AjDe9; 25:Jlf5CFQDp5gH4SFF9OjC4iKN6pe4tizEMgCZ5d1SpcbZhjlvixpeThWSDtCRlEh2W1dCxxYqZiILi7KD73FiYXrK2lVsDKpb5G1NgSENiwkWeEwyuNBeWWjGHfo9kf1679XMOORZqOUm/4wnU11QqWjEdM6tH9iYPeGxOZ7D6MlmEfp7O3ssE/9T3OLYYTWBaJsgzC4LQczUEzBcAlfpLCP4IU7TcIo0J6laL/I0ULMSqfBiJubldqHrYaRYpHbYUlpauDeRw4zHvE9BpDosuIOtdCNrlEMdtBRH92diyS6BnCWW6dfNGOZDFP6c8pJxzyl154JbhrJEMXSIzB28RQ==; 31:ISdPVf5aFtjMIjLVEYPIy18ikOwExVatemn+rUCWtWmxP62qjBDkdw21Nb1T40cmYmHT0mKzGZvOpDa5XxCLtxBb/61XtNsmOW8bIYAYAuQ3w4C12JqzC5pDDXRMPq4yjpy/YTl1SI9gx10iS/+y/He27en4WQdMKjm7KcadDpApOxnqB81BQNv1Ac8BwuTFTIYq0zgZMXtaZpg+au+AGAUXaugwDxygNAm+eU9Ckk0= X-MS-TrafficTypeDiagnostic: DB3PR0502MB3980: X-Microsoft-Exchange-Diagnostics: 1; DB3PR0502MB3980; 20:FMv/wxSdD6mSQQHUddxL9tBtcvGVbCA2um2C64tMEL4kvUzTLcwW010c9dPPHmXNZCtu/YFjc26f9wgRmTCIffs/Wg6Tt1NiQA4JGROcJws0uZ5EHLMQ4XjA9YtG9bZTVbGyN/qPq7aByl7bepWPNMKwDMQjibCMgAdps51b0sf8u1pQ8cJ0GhVrd0iVLPM906lo9rjkKnhtQ9kUBrwoWpaD9OYtFO+CFKsDZmzmU38GowN6Z5qgTys/fAvclAv+X3XWmR4swkyFH47TGM6sapmYjzzrK23q0kxRGmOjq0jExQf/hqghoOU5kM6nv3BWtIPyOFmJHf15STkGW3r7RBHRqGAdjpJXsQgVGKuBpBYNS7MafFeUyjs1XthJgf7/ZPLVXJNWy4pUIo9Xsn1XUBb/XH44p0AWXN8wwSFGxqDuMfMRqYBbjRJmZUJcx4nCUxtHbcq9c4L59OZNeGQX1LS1qDLuidrTbIo3qX+xfJ1vWE1sJtGcNqd/pLi5N52r; 4:JSYkTzAbx2pOBzSf3aTyuSB6cdRuRiCJISEScG7XgSETqXL5vCM2/FtW5IP4r075fv44bUyWQdX8O/u06C2R88I8nPQqunI3Gc1l/H1sdDUphrpDpPsQY1Z0SjWlWtbUgtkGnDQXF52TOhDMrm6sZ9S8qXxlUq+fQ4LnkyH12I2XXymDGBkb2vmnV48hHq3Rq4a6vxjyp5+RRHrM69NhrMgryRqWW7Z5TQCPQd4XbRRWL9xF0S8DzVYneh40vWIOJ9z2wSJusc01HZQgFYi/2CSoJtxTkHX0SiZLlV3+fbP/95AdgiGLaM0r/r0R6NQJ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(823301033)(93006095)(93001095)(3002001)(3231311)(944501410)(52105095)(10201501046)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011)(7699016); SRVR:DB3PR0502MB3980; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0502MB3980; X-Forefront-PRVS: 07630F72AD X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(396003)(346002)(136003)(366004)(39860400002)(376002)(189003)(199004)(28163001)(69234005)(105586002)(106356001)(97736004)(76176011)(16526019)(26005)(186003)(446003)(11346002)(2616005)(956004)(14444005)(36756003)(50466002)(486006)(69596002)(21086003)(6916009)(476003)(53936002)(53376002)(48376002)(386003)(7736002)(6666003)(1720100001)(66066001)(305945005)(47776003)(478600001)(7696005)(53546011)(51416003)(25786009)(52116002)(4326008)(966005)(55016002)(6306002)(54906003)(16586007)(86362001)(5660300001)(3846002)(8676002)(6116002)(8936002)(316002)(81166006)(68736007)(50226002)(1076002)(2906002)(81156014); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3980; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB3PR0502MB3980; 23:ZGJ5hmVFIPlG4kmHsMsAe8npoCvS/w6q815b0+Q?= =?us-ascii?Q?85AlaMqdmchP1g4yzpphD8+gFXXpDZ8bIHUF4qpku8m6VMEQU/Gq1o6yE1Qv?= =?us-ascii?Q?ivRnm9ZFANKu8ckJFhOb2S9Qz2Orjk6po1v8GGuuqGGbxx+UNxOsFNh7ahbN?= =?us-ascii?Q?p9zx+o1qeeegsF/hQP8xnYDMVWKwufpJ7f+c8W7FBOwFKFd6sIPKzrCR/TYs?= =?us-ascii?Q?HA123F7s0UFRb7WKrK/mkF8CydLHDNlaJmS0CEOggUE8ke66Wg+tpgo/iZNh?= =?us-ascii?Q?Ow02ld9b6MMPLE18Qt5BYcOPvr9CVdqFC14PNUhGR7uxShScl3qsLO4S5RkU?= =?us-ascii?Q?kLYF2AG+CiKl/KslwV5qsjrEUG2enqxkK5fEo0UQZ0DdEIII+G2A/YSZAhpd?= =?us-ascii?Q?1lajL5p+6wcdTlJCWTdDXONqzD+YD+vYz29RhBQg0P9h2gQz6JaQNzwAq7XO?= =?us-ascii?Q?maL1oQL4fxcof5BrC0aP4oj4OO7/CK6aoXTKBiX41sycRXCapPqEQ7isXabr?= =?us-ascii?Q?fnU1qnPUKE2e18+hWL1m2o/4MDZgpoK35IEB/gS7JZsYmnF38Ztkz5T5Pw0D?= =?us-ascii?Q?6dTpKjsC40kq12PZuVbmAeHimQb6cDUF6Nl7ehd9iVFbGkvZt06F1JGo9R6U?= =?us-ascii?Q?fDVSJ9/yH2lRPymyBxpFOz59RlfsSA9MlxZPbqmIwQNCz1fhroK4ROAPkYob?= =?us-ascii?Q?lR7QUvymzNoAGSY7ucFZDmd8N8Piq/IzO+IDEwVR4juJ+77FuJ8ZZod68ves?= =?us-ascii?Q?bc74hwHdW9neyjG0ri+lySTkj31812Wml85z/Hds+wSiLiZcZtappOCHAYal?= =?us-ascii?Q?Z+tWyBVhb6OWVb4fs/K27NlSgyJPRNS1zjbe4iDRRkvgMi+K2+TIyy3GRKgh?= =?us-ascii?Q?/+fDlrYyU4kc9xZbTpkd7QoxVAMAREPSwsBCkl0k+H70bgQwptxgJDEBB6KV?= =?us-ascii?Q?gBwkGzm1xMyWCIFZJJrgR9FuWyJRugBgUzSKkNhzp2jWk+YDaMjTXpFWoz2P?= =?us-ascii?Q?jY0CvcncfxLj9pZRorr9W/tqm6v3iujOdZqrVn9TYSJ3CNNMWOx9QZRtQPcZ?= =?us-ascii?Q?bJ8Q/mq4zboR8uVwPQYKnc+YnaNcOpz3r7CMUVv3YLClc5INeibHBkiTeaQj?= =?us-ascii?Q?pmoaurC+3HhlM/pv2X+SvnZicogrkpoLsQQJNBHeRzWjp6yr4/cejfypa2FU?= =?us-ascii?Q?nw5vuxajOr0yRQkYBvdIcDGkKFg2St0HqWt3WzPZYwJU46QYZwuKB/hE1Be9?= =?us-ascii?Q?IhUrCpB9rooWijNDCQ8bEbWuTV3vUZ+I+mUA007b8YcXWblAuMp9/Udi+bep?= =?us-ascii?Q?vKXJf4g6BV2kTikIsmEfvW9hpov3a5KGLghm/Q9M2wlywa4kHYyLwLSmFPqX?= =?us-ascii?Q?GR9dVNKFFdBOppKW6JTMZvu7zhIFskbKLnTJLJRYoiGlkCcoh?= X-Microsoft-Antispam-Message-Info: ZKiiJQy3/90K0OX4RNF72pdYt16oscvjXBBt8N00hTCSQiwM8hnDwLemoRLYdLWYoeiVmEAqO5Kzf2324d/gYC6HGA1tu6XilL6t0Zt1V5OBz9lxt460Y2/5UIwTa8tMid7dvvscisKQt8fWbJVcJkmdrebyf0fD281NpBA7WOCpXL/zo7bcnjvw7fy6mNQK1ASMEqj85oLAh//wn5YUVjs94b/yq856CbqB8iFmx0gpyU43BvHC8ERx7MpORPWgjinbsUMJAD0GloMEElucqiLFOaA1sI0ZS3t+/CIM3hlQZCZc+/AEI38adjZJymZZ/J6gc6FqTgyz4xQvcDNWqXBmQ8tXIu0UWZnKb1w8XCo= X-Microsoft-Exchange-Diagnostics: 1; DB3PR0502MB3980; 6:jnxUBRsi0RTCIQ5WNE0aBCWM/OZir6//Pouf3HMzu7b6y/VPo4Q+z70l1x9ELEypClkWx2Tk9VGeP7UIkZP7HBzwfv6qG0Sg41oYStTuxMwG9r+7y71UQOB/mJ/tpYKicm1a+oXGVUWCNXnfB0gji5qL+LbDvErfW0175wgCk8b3+kU1N9o0hmKDfZ6IPE1oto5WdrB5a0w8zRx+1p3vNcnGxTfRpIRncEfugLF/qSexKEHqzGhNoBLMqOujnyy/tyngiWbdAmEF1R87pinzc5054EVAaENptWDLyP+4n23qn27U6nl7kaxB/IXOu6c1l6H7/kFCLaXRmCdVZE+aYhizEusnL0aqQme91aoU0tZEyI3bPJ5Gn4gnDFIZ6i12CPZjs/re78mjLcPx/XjgXCcPu/lM8HhPmOdmby9j7fGmg8R2+xIEd/36gj/PK6u4yDiCr5Np/Oa93DFjx5qnNw==; 5:PhNVk2k1LB1SB6u+usn8zEqM3IclSxY5FixZRIx+X1Q6r+8Bnda27bVfaE/7RHpi/FZBikh3ytnK1jvm32V3Wdw+pB6JhEk15szHicCH0fGsG3zmwV3fAjznLAkpPocT3AxCWITCcdwlWPNJwo29ZhGjNsKW970dzqFnsURSCFQ=; 7:I78M9C8ABuReWjSrfZjf1UXg7CwpXoV2r5PlhJZDfyxxe2pREviQCJ0PHVgQ+ca2gcR+iKp+Au1xkvnF6A8JuDTKbc5dFD03tKREoDso5DtS/ciQdVqLnelQVJndaMegT+8T8njKdQyUyuInYbx17sggsUAkR0hpjN2hwgMkWs+YEcFN1xiKqUOL78+lHO2WgXjSH1uuaqwzPamJ9mezgzQxzs1DR9Epf+JkTeDxR+zSKw2B4ElAG0oBnTqmTYdf SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Aug 2018 20:42:38.8152 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 36de91e9-0e0f-4423-3566-08d6015d4f8e X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3980 Subject: [dpdk-stable] patch 'event: fix ring init failure handling' has been queued to LTS release 17.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Aug 2018 20:42:41 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/15/18. So please shout if anyone has objections. Thanks. Yongseok --- >>From 24e718ba4b191e5513d9d923cd3efc2a71485f9e Mon Sep 17 00:00:00 2001 From: Harry van Haaren Date: Thu, 2 Aug 2018 15:43:29 +0100 Subject: [PATCH] event: fix ring init failure handling [ upstream commit 219ae4a12995e5a8ee5e184655a37dd4ee96bf25 ] This commit fixes a bug in a 32-bit environment where the generic ring_init() would fail, but given the interaction with memzones the next iteration of the event_ring_autotest would actually *pass* because the ring in question would exist already an be looked-up. This commit rightly error checks the result of ring_init(), and calls rte_free() on the memory as required. Fixes: dc39e2f359b5 ("eventdev: add ring structure for events") Signed-off-by: Harry van Haaren Acked-by: Jerin Jacob --- lib/librte_eventdev/rte_event_ring.c | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/lib/librte_eventdev/rte_event_ring.c b/lib/librte_eventdev/rte_event_ring.c index b14c2127f..c0603cb99 100644 --- a/lib/librte_eventdev/rte_event_ring.c +++ b/lib/librte_eventdev/rte_event_ring.c @@ -110,11 +110,16 @@ rte_event_ring_create(const char *name, unsigned int count, int socket_id, mz = rte_memzone_reserve(mz_name, ring_size, socket_id, mz_flags); if (mz != NULL) { r = mz->addr; - /* - * no need to check return value here, we already checked the - * arguments above - */ - rte_event_ring_init(r, name, requested_count, flags); + /* Check return value in case rte_ring_init() fails on size */ + int err = rte_event_ring_init(r, name, requested_count, flags); + if (err) { + RTE_LOG(ERR, RING, "Ring init failed\n"); + if (rte_memzone_free(mz) != 0) + RTE_LOG(ERR, RING, "Cannot free memzone\n"); + rte_free(te); + rte_rwlock_write_unlock(RTE_EAL_TAILQ_RWLOCK); + return NULL; + } te->data = (void *) r; r->r.memzone = mz; -- 2.11.0