From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30065.outbound.protection.outlook.com [40.107.3.65]) by dpdk.org (Postfix) with ESMTP id 0FC7644C3 for ; Mon, 13 Aug 2018 22:43:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X2fAD/0vvb7/FUEyv9tgSpOwQtotMnwta3L+1EGCAiM=; b=I3+QR3mPsdeLHzlvzE7EiDEWyNjR6/TH8TGcWUfsL6an94+ainiJ5hcl5vVGqG08ARL3ius8TP1Sbr/xFkAvhA/LHO6pngEcvAlTxOvAUyatSuVmj94S4mUXqoq5ctsQqa/cU6WxGPRZBji7ZwF4ezk/8wfT6uH8L2QkYdYFL+E= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by AM6PR0502MB3975.eurprd05.prod.outlook.com (2603:10a6:209:1c::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1017.15; Mon, 13 Aug 2018 20:43:28 +0000 From: Yongseok Koh To: Yongseok Koh Cc: dpdk stable Date: Mon, 13 Aug 2018 13:42:58 -0700 Message-Id: <20180813204300.25514-5-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180813204300.25514-1-yskoh@mellanox.com> References: <20180813204300.25514-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: CY4PR13CA0017.namprd13.prod.outlook.com (2603:10b6:903:32::27) To AM6PR0502MB3975.eurprd05.prod.outlook.com (2603:10a6:209:1c::30) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 11a76de1-03d4-4c26-3e72-08d6015d6d1f X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR0502MB3975; X-Microsoft-Exchange-Diagnostics: 1; AM6PR0502MB3975; 3:8fflPy85pTgt8NoBORmnBFLhLn5PPGkqU4Jg4rstduF1ZtCyMDBfEgx7zP8InHOqpoH4EAXLHeTFua2iZH+jLFxkkKKcjkq+r6ciAdakcvZMIgD7cXM3xK6QS2ikf+bKyn7JNY/6fLilClrxAnn+wlysC5J9UMrrODiSYKVZwVqAGXFX8mKulRwubngI/857vt+BSKZ5ySkiRADrdaM8U2CJpAseW3Rj/S05hJNPgjxDjvqt3LdVB0O/MKMjKlUS; 25:gvYcKjZtFemAwgFYOdMnWuQTKeESSI1J9Pn5j3CzPDInnUfPubl6M7xM1+1uDKQHzvB2NzZG/yRXqmyK6vSDemmkVwCae7PEqBEo076/xBST6R6k4GUUU00PEzg9ajlqr8yS5Bg6nvvNbyIcvg1x1bPZbM3uY/Dq7zZnXMnkg/+yskRwM2dHkI8cLm4MWT1DjT7l1QDOwNXLwNXhf+zY73QwuztCphOb8uEwwN7jqclZGR4j+1+cBwWBlskcJI4hkH2ejiw/rH6CHvQc/iFRdMYfqz/qE1dckFNbw7/UBSIkHUASs7joShTQnZDYMpbY5vFAhi6oy2doj9VEK4xrMw==; 31:K38UOlvmNrGlTkUKFZhojtSky7ORiD8rjZajfheUc03SgLgQjLU/6yWvFWBh21+8nj237PkoZGTM8HO2+VteeGx2XwNUgzaOK8bpwkh83wKvfh60i4lRyWT5HeaqV2RMj0LwUBlOX0443JZsbKOKvHXCEs82Otx2v6j6nPFfnx56o+uvhaPXNICnleTV73IfWfNnmKpsjIiZfH7feyyWNv5+qOSEOghXeBv1Nb3nsps= X-MS-TrafficTypeDiagnostic: AM6PR0502MB3975: X-Microsoft-Exchange-Diagnostics: 1; AM6PR0502MB3975; 20:P9RdMT7P4u5bDPhnUVM4X75FQwhPTlyRpfTPBDrgxOZisN2PPJf6HOqBLG/m5tUTp/gVIlx557tbKSjywjCqTmr/mnJU524MkIWlZvnr4rK0DMJXzdhIivZvpXE8gsC+y3uzQEeO1D+DxMFdISkfUjN9yBPVS7vNQwF5oCoRofMXFgysKUx+Bh7qIyRD4fgtO4mLk9xa06uBVKWPbiHIXim436OnnbiqKqajgf4qwLpJ/ULsFVrFQJ8sr/cAKIpLUq8LOEG4coC/nVvoHO0WZIsywqfj9oqyQNyXcKyX1kSdSBQKYFKRs69yZSEQ5Y+s/hvWWbR9pIsdtBTrbRs4IlHXYM7h87syykF+Dx/gJhdIAJCN83ViwyhZdxyY9oiq1NZwG1hr78E8GEK0KyBtlafWq9zG7XvY9B07pFJPKy2l+399IhMOb9moV7SAKeHuB9fMyeJd//oQ9F7kssTP44ZdkUvy7E1OG0xBv0yUFg1oCn5L0DsvAGp2blNkprdV; 4:2zCpNY8rt+HJLncFOa18XPhYJxOAhTg0hHEzOAhILRCaIJDBimIcdAwzFnWOv1mo1YEmjo7VSodG25MOUFkyeAQiTswa2oNjiFmeLSDrNkIerGGe+NBrT8t0eCvsupU5FFRpjJFPXNw5c4idWKF8FEak41fDZK7o74qsEckyEpb3HJJv1oJoo38kqEzXExOcxNO0G7VtDCK+gWbmYXRL2756Hu8uwbt237m8LVPDRTShyp7KVUKkeqTHkv0ONaG5NOnlXg2mPMaw7xdv8gyCIw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231311)(944501410)(52105095)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:AM6PR0502MB3975; BCL:0; PCL:0; RULEID:; SRVR:AM6PR0502MB3975; X-Forefront-PRVS: 07630F72AD X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(136003)(346002)(396003)(376002)(366004)(69234005)(199004)(189003)(28163001)(1720100001)(2906002)(7696005)(52116002)(5660300001)(21086003)(51416003)(76176011)(7049001)(48376002)(106356001)(97736004)(105586002)(50466002)(50226002)(478600001)(68736007)(966005)(37006003)(316002)(81156014)(16586007)(8676002)(81166006)(8936002)(11346002)(53936002)(16526019)(1076002)(305945005)(69596002)(7736002)(446003)(4326008)(6666003)(486006)(3846002)(956004)(55016002)(53376002)(6306002)(25786009)(6116002)(14444005)(47776003)(6200100001)(53546011)(386003)(26005)(86362001)(36756003)(2616005)(476003)(66066001)(6862004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR0502MB3975; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM6PR0502MB3975; 23:2a6nKGuH20VdWIho6bqtKsPx9BWvWQqP9cwWebJ?= =?us-ascii?Q?QGT2XJ4oerRlYd6T7qvLu4d6zYGDumBTBLxIIAmrF3odmqVGnNBblRtYXpby?= =?us-ascii?Q?umUQ+BuDrZt6EliyiA5kS/DXsTpvu7fuwBjg34wCgSxaeUWhfDLZHJ20t43x?= =?us-ascii?Q?GILR/uvpfn7FHeFRqVRf0whahyu3HZWFYiPJmHK6AS3aAFACS/XcxSNsEIHe?= =?us-ascii?Q?F2hp9ClBdoAs/M+p01k5ssK+9Tx2VeS4G56unPQy4wN1yep48vOXdPv3ONHU?= =?us-ascii?Q?D9beX75++YHvJnD+kPT9rJlKfdEQkmW28Y+dInSeKvczbJOoI/2VH6w3edyJ?= =?us-ascii?Q?x92xn8E9O0tL6PPnbCykHiTEXkUHf4E4dLyW5fKAVfODFXWSYjvntpdx8FCQ?= =?us-ascii?Q?T7okT5nZKuckYVWsdlEK4YJbdhaUW7G10J5TT+whYFwBIQ/pxCTvpDKUGmaU?= =?us-ascii?Q?iDGG6HhLGtgYxDAqGZvZyDAO7+a4QEyeOS3Iqdg4e5eeUp3E0UwsO3RQcJC1?= =?us-ascii?Q?mLwr7EGyWcANwhAIJQMxJ/vv7CJoUDlVisCYBYauFPl5PI5EkpyHxweWd6EM?= =?us-ascii?Q?TTnTmRlbbdUNKG3EU43OFFTI3XElVNZpOVYdvXF9oRwbgsgmA7N3d8G1kr0y?= =?us-ascii?Q?kFGbADBiJMoPgMcvNe5FnAcijUk4NM/uD9WGbatTAROFVGXjG5vKmmWuZ4J4?= =?us-ascii?Q?JAuLrrsrebRUGTNyCn8wKa/JANykcUe21NRII1AjlV3CG/xi34+VCWYH4qWm?= =?us-ascii?Q?Zyf20Idu1JlV8El8TPoGa0PQeAK5Xv11lwLCeNjXYx4UzvC0VnWTENtDidPw?= =?us-ascii?Q?HcZA2GVuh7YTlbiJzWKBpkiVXi1GvzH9wP7eGs21D3WeYHkU26H+eVls3Fv1?= =?us-ascii?Q?TQEwVBEhR45sGG+a6g/EmqDY7Rx5MzD3R9kKyf6tzZuN4WXMcwYud9tVSUfF?= =?us-ascii?Q?86GwxeSDVttqd75NBVpLQmo9x0ceosdj8qnf/30nob0woe2qQGLNlvrZmdWw?= =?us-ascii?Q?3FIfE3XUcQDPT07XNFm14HikQdAtKHg5vwVlAFeYLYl47yp/O1o4Wzg/yq4+?= =?us-ascii?Q?u/g/92YGdxqdGrkxUeOv+RtWoTp7ky38PI7vIVAOtgJLcTmgaBRowFMcFDFf?= =?us-ascii?Q?SM5f8EsjHsri5oXrfvF0qFGD4d3+f/2bv+/DLAcAx99C2e/6Ra2XhoBRJICh?= =?us-ascii?Q?o+9NP+Gsi/RrZ0Gb/PgG1W4ZXgKuoS7MAO/T+pi/XJxLcrjRSSK96pbFcbi7?= =?us-ascii?Q?sdlRwz6Eilzf4Dihw+/vUcj1IUp9V5aRoOhsBRPgC+yG66+XFh9zK6LA+rnk?= =?us-ascii?Q?c86uxMKQ7hq+e+EKxSM9+sM1u5GOnGF/39Whbcwpgp8Ag1RUuCyQ8mxlTlSo?= =?us-ascii?Q?WL7WY2ClxhoVLbdLnmsaRxONjrHp9LwDKeNrc4pPooUSe7/VcaozkZaPYuv4?= =?us-ascii?Q?119PZ9hVQ/NaRxROwj/0prZ3b8GfuhLk=3D?= X-Microsoft-Antispam-Message-Info: /D6AVv8QEfbhqvTdNME8xc/4p8EvH+473myLRYZlQKc/nzVaf7ctcitQ89HWksB4aQQ9sCtRu1cgoFAjBig8SKMKSVSZ+IeJWV/AtUD1+++RMlOf98xl9RSJVBEGpSx7VoKZEDnAN45Y8O/9CgU5twAnJA2Lg1nofMczb90GFqPWCxqdwhz0cq1Kd0vP30Crv2chlqHIt0PEx3cx8/JZw8TRCd6dMMXBh61zWkq4UEgiV0CIQSyz5x/zTCmGGdjKH350OJyURri+FD9A6NC5U2NRIbqa5zSyYS/Ijikk7Dsiv6hgeMCRxp8I6KJ6+62w2WqjdvpsH2UecJiQRYYsSmJwrd+juXquIdib1jTbn9o= X-Microsoft-Exchange-Diagnostics: 1; AM6PR0502MB3975; 6:JthWy56tib9E4BrYDVvRV3U1rYdCyuvMScvtmY4+IOa3A+9/+q+VOrGIgWDveeInTPnN0PTmNHTaNH+V2xjF978ARXGwe8llD20CXXyAMFOwKDPYCkysrHEoeGJsSH4X1qqQe3cZkZLFDOnrNL9r0E6zPeQRrydN3a/3xsnF4RgSkI8bb7M40f4OE8cb/esGaLV49A816szfYCb6GjLy+CQILKNOP4uhJYs4LM3kO7/IurSQ3ZlgAvaVbdDe6zbh+h4CSdBfCG13Imnn3+2krWKzP8k7VDA+VvwsWKRyVAOuqjgFdnc1bE3xqmoy6oxpyEH7GqpyieoJOT3oyo+sChR4p8Q9OJExEU07qjML0ImdPXQypfVarB2VlvlHkLLD+5H6SS/V1KgbQ3Q0L7oRZYa2jCWmJjVyJshxXiMM4GWFKjGkhii4cjgp1iOI/czdXLVF0SYpxcy6x2nBvIz6Wg==; 5:MqN5FoJOFuYPQA8Xto6TS5AlYKrwS51e6CwOeCIGzmPEBpeJVfQAexmvbw8FMWFJdz3o4cUDIzXl5kHgFPRhmkxlXuWlVOvQp1j4rAoPWqjlkkpi/g6p0ZKzVHiSfC6mhN8FKlr9LavRfTVY5xRVra9S1Rcu/D1SPfHu6tHhlH4=; 7:+bN/HTogrA1oZ0kw2sp01QXBXbdt1UitPqaTtKaIZoaqU4bFO4aO7ZBxk7pJ0VcwnJM+kZtFULpfR8IPbRh80tttLHkmQtC5TLROb1cDAiZw4HJeFDNe8H19PsctgPsSxPquPo3JxeYnDPhuJh7Ehkj6p3Gmd3Jm16tIWORN8deRt08+6o5TB3siw4YYavKFovA86d7p6UBZDQ0cYbvTe8AbSM23Zk8hEsW3Vx5vDZRNsWCxOMlOB0f4PMQpIwL0 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Aug 2018 20:43:28.7299 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 11a76de1-03d4-4c26-3e72-08d6015d6d1f X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0502MB3975 Subject: [dpdk-stable] patch 'net/mlx5: preserve promiscuous flag for flow isolation mode' has been queued to LTS release 17.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Aug 2018 20:43:30 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/15/18. So please shout if anyone has objections. Thanks. Yongseok --- >>From eea864f748d36d540ebdf4db48107e31683f5b96 Mon Sep 17 00:00:00 2001 From: Yongseok Koh Date: Thu, 2 Aug 2018 14:06:31 -0700 Subject: [PATCH] net/mlx5: preserve promiscuous flag for flow isolation mode [ backported from upstream commit 24b068ad71229139f74a1c45bd45dcf9f4611f89 ] mlx5_dev_ops_isolate doesn't have APIs for enabling/disabling promiscuous mode as it can't be enabled in flow isolation mode. If the function pointers are null, librte APIs such as rte_eth_promiscuous_enable/disable() fail to set the flag (dev->data->promiscuous). The flag is used when starting traffic by mlx5_traffic_enable(). When switching out of flow isolation mode, promiscuous mode will not be set even though it has been enabled. Fixes: 0887aa7f27f3 ("net/mlx5: add new operations for isolated mode") Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5.c | 2 ++ drivers/net/mlx5/mlx5_rxmode.c | 8 ++++++++ 2 files changed, 10 insertions(+) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 76f76c41b..8f7fac15c 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -345,6 +345,8 @@ const struct eth_dev_ops mlx5_dev_ops_isolate = { .dev_set_link_down = mlx5_set_link_down, .dev_set_link_up = mlx5_set_link_up, .dev_close = mlx5_dev_close, + .promiscuous_enable = mlx5_promiscuous_enable, + .promiscuous_disable = mlx5_promiscuous_disable, .link_update = mlx5_link_update, .stats_get = mlx5_stats_get, .stats_reset = mlx5_stats_reset, diff --git a/drivers/net/mlx5/mlx5_rxmode.c b/drivers/net/mlx5/mlx5_rxmode.c index 23eae7c12..d81fd3d20 100644 --- a/drivers/net/mlx5/mlx5_rxmode.c +++ b/drivers/net/mlx5/mlx5_rxmode.c @@ -60,9 +60,17 @@ void mlx5_promiscuous_enable(struct rte_eth_dev *dev) { + struct priv *priv = dev->data->dev_private; int ret; dev->data->promiscuous = 1; + if (priv->isolated) { + DRV_LOG(WARNING, + "port %u cannot enable promiscuous mode" + " in flow isolation mode", + dev->data->port_id); + return; + } ret = mlx5_traffic_restart(dev); if (ret) DRV_LOG(ERR, "port %u cannot enable promiscuous mode: %s", -- 2.11.0