From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30073.outbound.protection.outlook.com [40.107.3.73]) by dpdk.org (Postfix) with ESMTP id 3A106493D for ; Mon, 13 Aug 2018 22:43:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3nPB8ZlPCg5BwjhRXevUPBrKWWsPmuKYmVWh5W02f18=; b=LuSNqY+NohUSwG1a3tlq9EOprOc+28kFMxL54gXDsAz1GSexdBWPJb/bMHxUCFGvqvcb+9ODlRw00RYbaPVEUsiuPnyFn72YchW2sR2oTPbLyCIrbedXzZngHMYz5CEMwfy/r6lwmkxK6JH2+xkADlSDFwDZ0N1mkxQCdnNZbYQ= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by AM6PR0502MB3975.eurprd05.prod.outlook.com (2603:10a6:209:1c::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1017.15; Mon, 13 Aug 2018 20:43:29 +0000 From: Yongseok Koh To: Yongseok Koh Cc: dpdk stable Date: Mon, 13 Aug 2018 13:42:59 -0700 Message-Id: <20180813204300.25514-6-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180813204300.25514-1-yskoh@mellanox.com> References: <20180813204300.25514-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: CY4PR13CA0017.namprd13.prod.outlook.com (2603:10b6:903:32::27) To AM6PR0502MB3975.eurprd05.prod.outlook.com (2603:10a6:209:1c::30) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 16e83481-e0c3-499c-fa73-08d6015d6dbc X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:AM6PR0502MB3975; X-Microsoft-Exchange-Diagnostics: 1; AM6PR0502MB3975; 3:w342lSwN+QtWv/yR5/4fhf6UeS8xC0b6jCVOQdDbJ/TxBIb5nruxoPBC6zXwu3nlzypKs8xeeT0Yayo/qzyeItCFYDZShnbOVl66vD1CmJYuL3E094dxUeLIfDGMOr94s4monsoFXaD0sEoclW1WJyTlnI0hSETDywTQfM0TzY2za+K5QTIE+SlKesDhcVJSEVfBg020pOMzOWyWr08MpBU0AKCCExeMe4Lv/+KnsEV7jqG1gO2Jwt8/uP3rSs2U; 25:PaA1N8i7v8a0SflJhIpXp5SHfUqQRVLpU4je+Olu6OpL/c4XR1X/tv6BvgZ2u+pEciJUyT83S77ZTFEq8rhxBiNwBRDb0hmIHMU5NV4M8EV1QzZWdA85MD0Nd4xxNPnHHn5JR377VAuNCrVeENLBkbP00KH6/0gPipui2/zKJySkbyuDwXgL3z/jvsQWDFJMOAYXGWK4HhWI2K4E+8ed8fXVeb9nIg2CtHBjqm24DuD/aOwRHXkxDdKEe4d47rT26Fd5mDr5MrxlqaekuIKuhivnBCoAPYi05VW7YyPZKyc7IXBNxO2a78jVGUh0FJEsH1ArUiTszaf03sFYbz5hnw==; 31:2/sNFdl4eMdJbpwtCsWjqLRLu/2edNCmk4JtFb8UK+pj8bkcqXdMkB8NZeBOapI+bZOsGQIre2gjHegjmLod3BGvkEpwPvKzdeushzHsqvOrMXdPZL2Thfwg+5WA8YeVYWb7mEbyIZcpD1gMeE0KZhyZE3NzopRBv37Txo05e0TYumj2myvK66basVUby9Xl18i5v+tBh20Z5k7uPU4tGbJmPrqK4WEGap0npkzG0uw= X-MS-TrafficTypeDiagnostic: AM6PR0502MB3975: X-Microsoft-Exchange-Diagnostics: 1; AM6PR0502MB3975; 20:QA8TGWgT/v1KkQ4TVDAcTsz2ZaOyLW9p+tRvD/XzxH6MmmlKtXf1TtlNyHMu3wZuZdcl0QAAQftSFpvE68i6Hj0GglSR8cbzDMMdNUUjV9D3LZ9cK6YHkt8vmEm9UckgOnNhqxpGbGd777XWld4q8tyjmsZRG6zFh/f7kXMXTuJ7pcdRjxWmBAp69EwaGSMjyoZXsEfCr4DYqO8PDWv1/o8fGU6yXUUr59kdNPTsFcLYdJq5UXPc40RI4/SBfsydCsAncK88YyQnNmUuvfkSs05QiFg/BupGuHsgbY0BFL5U2qNt1sll+wYZ6f/+D2FiRmpbt9gb7TavF/wrx5jP0dcNjVx4qxqah520o6hQZm10LxwAok98Lpy9R0qavEg99NcDo+k4yD5LDZi+WsOoJJrU/2hD4suBPKWE8amkOVzZvNzy7omZV+wpUCIckPUfgzeVF2XDYOKhKS4GDwp3nsPVoxJA7EDTATe+3/roKkRhI9SnmumYTueWlVJX2+yd; 4:OKZaAJ89FojgmOJV5fB79VnCIJOW56x5RI8zz44lXmUeKyCDN7bCLDDxTBNNxdmfSWIoAhhB6d8SGrxiiIKzTK4Ff5e5Pc7wmSkOoXusXrWgYkpN64wysg5qIzEC8HpoeG+HHTo2f6qfLkk6symOHRCgjxYBlsUASzWgnN+djen5zlHMdJonJmvcB5QDBsDN2CQfEIYn/kd4wrubiamavFXovPpV76y7RjVc+2+wX8PaUAI/X5YEti3tmksjOuvC6oMEHaFlCkTXrgG9TATzPw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(3231311)(944501410)(52105095)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(20161123564045)(20161123558120)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:AM6PR0502MB3975; BCL:0; PCL:0; RULEID:; SRVR:AM6PR0502MB3975; X-Forefront-PRVS: 07630F72AD X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(136003)(346002)(396003)(376002)(366004)(69234005)(199004)(189003)(28163001)(1720100001)(2906002)(7696005)(52116002)(5660300001)(21086003)(51416003)(76176011)(7049001)(48376002)(106356001)(97736004)(105586002)(50466002)(50226002)(478600001)(68736007)(966005)(37006003)(316002)(81156014)(16586007)(8676002)(81166006)(8936002)(11346002)(53936002)(16526019)(1076002)(305945005)(69596002)(7736002)(446003)(4326008)(6666003)(486006)(3846002)(956004)(55016002)(53376002)(6306002)(25786009)(6116002)(14444005)(47776003)(6200100001)(53546011)(386003)(26005)(86362001)(36756003)(2616005)(476003)(66066001)(6862004); DIR:OUT; SFP:1101; SCL:1; SRVR:AM6PR0502MB3975; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM6PR0502MB3975; 23:85u/TejFbpv96Jn7eV+bZssWiA1oUUf5IKDezij?= =?us-ascii?Q?iw2v+IIZwDTiN5A35ncGYtR9ST+eF1s1+NSQPAzQiEDU98xSyYH9nEtrsC9R?= =?us-ascii?Q?/29/o75PzaThFWpX16N5KUyUjuRNnSPnnxpIR70oWNiK4MNy6EvBGRWPpQN6?= =?us-ascii?Q?g8w7P/ueQEHIGKidl+QcNtTC3Tu0HNlGmy+07UbeuXcrRL1Qrc6qNzN5f4H8?= =?us-ascii?Q?W9U5j/tshySlbI3tK1IpwamitFJPcfii84MC6SxXzheHz5TpFFqHRZZSX2Id?= =?us-ascii?Q?Xvh3Gd397muknizHW1OhFK6aOPL3WjCbf0z9nJpNT8ZEmvvm3DIzNR8IJAp0?= =?us-ascii?Q?hUWKAic7NfrTqWTZ8YmuaTl8VarDnVWBEfRoUf0uiuT6HgEazLtWik4mo83v?= =?us-ascii?Q?cs+alz+KMTClEx282A+3/VpEIFCukLGx9CnHJBtHembBo7k9vOskOlteZ2Uv?= =?us-ascii?Q?U8LyKmg6mSBDj4uMsx6vhX7jz9cay7V91IUhWnweNY1OAl9ATMnRZfqKxC5M?= =?us-ascii?Q?GT/hewXryqQ1iY+ynaX++pBdjvz8pKg/tORut/djYKmGeqVaPSRxHNDiO99M?= =?us-ascii?Q?ANVC0tYfiBF3UA8JHBOkh43+aSCWFr2t0X5MnE/zU6bpEaTVD5ECU/eNZlZF?= =?us-ascii?Q?iXIHWsRRN4pr9R/6gCMN5Yl1CQto5zZ6Zps4hJWrshfQbbPtPUPdQTfgHajr?= =?us-ascii?Q?3mB6RyIE6MRJgMsW5ZGQ2kAbSLvIvO8U9So5QyE3ejK0R49e5tysWIsTMRsi?= =?us-ascii?Q?bUXOPzL++1FweGMonyqRtf31yURAe+CWPG2S2nskmoPhFtdptmzpbFUH4+l4?= =?us-ascii?Q?j+OB1KYmxx95jhrUB6NKu8XYgV/j4UlLucB5TiCw1MF8MRWnxeMxKKot4IKz?= =?us-ascii?Q?5mwXI6Ba8ZLGZvwjslDaRj2NOe2TlII4po8XCLnqWDmV0LVmeWbSkIw1GNOf?= =?us-ascii?Q?dNPg0ElOs62109GHM79KJk1IZTSOvpLimQGHYjo0Emhsp46yWdVLYHBIUXXA?= =?us-ascii?Q?ALFwe92IG97oi2+m1wZZHOvw0iAa4VrGBoFyvHiTIOWnlxJRC1D17olvl0oA?= =?us-ascii?Q?sZDGJULHxeEMCgnwSpkXuUJDuNW+xHjHIuGTk31QEGSD9m9vSJi4uobtjIRT?= =?us-ascii?Q?vSjaCyYupUK5bqZc8q84b6cQYk2i87B4qkK2P+w9bMVG/Mg9oj1QI+Kqri2f?= =?us-ascii?Q?AGVo3uI8gmpSpIZyiFjF9e8eSwgu2xQlGobvZnNg9x1vBsbMO1AgJ9p6aNjH?= =?us-ascii?Q?LcleUV48kFhzJds9xCnnRQM2aUrSmuYgHcC7maOiZAMjkcBd4DA+o7ocNl7t?= =?us-ascii?Q?yL+g07WUdF6cBLAYJGD+P4kmVtIXQlRAy1Y+A+Qvsu0l1YnUPSnKe/GDCy1F?= =?us-ascii?Q?oH6cccJcFPlfkS+U0XBuBmYYtU369KExi58thUW/Mra4LXfvjDCBFPhFjE8Q?= =?us-ascii?Q?K5gmB7vyD/O2PVFYhiLEKwNt6r1jRHxc=3D?= X-Microsoft-Antispam-Message-Info: EjBl2UF5TSrVTBFPLh71EpwdmA+huQ+uFPpvTt4PkKypvcI7HqJatvBXl+3kTQStokGWe21QCMeAw5kRLWvVok0B/ZOs5+i5jm6tRSd0h/GEsbOCBf2w6B3ow50gSYV1cN2fvz7b5RU7I8nr4e8ooz5Ib031kxt+atVpHxqK6d6iYDhNXanHYwLOHx22+XsM4dWLx5bga1unm7TGugpnO17Rn0jfVY+Xsa928nxOVOo65DqHNhKQ7daReWFV3TAMcqmjflZnR0pQX97HLrlpFK1+wo4VEaa8w3SYJsg3GgVtwL1PyuHa+gtNqu/7CgbAx42cHidzeaXpW1Xu0HFHkKC6ZQPowff/kWhf/BIevag= X-Microsoft-Exchange-Diagnostics: 1; AM6PR0502MB3975; 6:7cQUr036Gi6SGW+yqnx6SDifnFv8y4kaeh/kNpAupsvZdcDm8Grl3vmnr/zOp0QExYX5ZFZoboWKPJczHe/IsAMvTt+nzun/8ucDtHD4WBtTO2vCJREYwMOnQvr1hwnNTTBnW28pR/coKfKYySXApgNff8ELUXTV55D0AhLqv+3BgSnrbm/SvqByuGrN2E+hWvPN1ffWF4BEo5VbLqlmfcjvx9Ephal+JQ9j+QoaWel/i5QF4lv863UYUzAUTtCzfd7t945L0xlrMfVek+CDLVgrepiaU/ln9W9BwTpDropOwc3tsqGWyYIxChUAW6V/zWSX9TmQv++Yzce4lTDrHnTp6ClxHzJkNEFg/KUQpYwRYI9dGoU3U5DgfrXjq+fDd75V516suiEriteZTYWLYitsLDjvRnvHhP69adD8XvaZlzB22D82YTtgbMGjKWQyLqsSUZs/Cv8aOGYa6mh6dw==; 5:6zJb8OYCLpM5SL0kgWhoux8fuQh9E6pDZXnB8H8bzFgfuL39bqjeeU9vRhDIFUs6yvlb+MO+DO+bcotQ5ps+0NYBCT77LtBYAClDekSnwF/ka4nSTkx4iWkn/DfLsxLi1PWkFi6JAbvFXoHvuJPBx/op7dKnLrMh5CCUp/yGdiA=; 7:UfSyWg5iO+zqtVYg4frE1p+2PnYwGP2FzTnxDbNYS2/Ok1sNjlvj2mT1Xgbhdrju6JvT5epr7x5mt0zpE5HjNiLTnCrTm8/aactcSv2RrXT0xRmbVvIwue6KEl34P3LSkPVJukCl2dVJOLlAT3zVuN8v465GAUDlVuh/DSaiKgB8WcbmAccdxLwaFVlFzcJIxUcdMDvBPJt6VPl3PO7xr2S8p2McdsujG74KfoyMaoy2C9TWg/Rn9yUUmx1eMbap SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Aug 2018 20:43:29.7626 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 16e83481-e0c3-499c-fa73-08d6015d6dbc X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR0502MB3975 Subject: [dpdk-stable] patch 'net/mlx5: preserve allmulticast flag for flow isolation mode' has been queued to LTS release 17.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Aug 2018 20:43:31 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/15/18. So please shout if anyone has objections. Thanks. Yongseok --- >>From bf7ed5439d7bc7be5a094113f85c4c5951771e32 Mon Sep 17 00:00:00 2001 From: Yongseok Koh Date: Thu, 2 Aug 2018 14:06:32 -0700 Subject: [PATCH] net/mlx5: preserve allmulticast flag for flow isolation mode [ backported from upstream commit 2547ee74580d376a680729567dae8bc757fba438 ] mlx5_dev_ops_isolate doesn't have APIs for enabling/disabling allmulti mode as it can't be enabled in flow isolation mode. If the function pointers are null, librte APIs such as rte_eth_allmulticast_enable/disable() fail to set the flag (dev->data->all_multicast). The flag is used when starting traffic by mlx5_traffic_enable(). When switching out of flow isolation mode, allmulti mode will not be set even though it has been enabled. Fixes: 0887aa7f27f3 ("net/mlx5: add new operations for isolated mode") Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5.c | 2 ++ drivers/net/mlx5/mlx5_rxmode.c | 8 ++++++++ 2 files changed, 10 insertions(+) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 8f7fac15c..36f3a0565 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -347,6 +347,8 @@ const struct eth_dev_ops mlx5_dev_ops_isolate = { .dev_close = mlx5_dev_close, .promiscuous_enable = mlx5_promiscuous_enable, .promiscuous_disable = mlx5_promiscuous_disable, + .allmulticast_enable = mlx5_allmulticast_enable, + .allmulticast_disable = mlx5_allmulticast_disable, .link_update = mlx5_link_update, .stats_get = mlx5_stats_get, .stats_reset = mlx5_stats_reset, diff --git a/drivers/net/mlx5/mlx5_rxmode.c b/drivers/net/mlx5/mlx5_rxmode.c index d81fd3d20..617138c13 100644 --- a/drivers/net/mlx5/mlx5_rxmode.c +++ b/drivers/net/mlx5/mlx5_rxmode.c @@ -104,9 +104,17 @@ mlx5_promiscuous_disable(struct rte_eth_dev *dev) void mlx5_allmulticast_enable(struct rte_eth_dev *dev) { + struct priv *priv = dev->data->dev_private; int ret; dev->data->all_multicast = 1; + if (priv->isolated) { + DRV_LOG(WARNING, + "port %u cannot enable allmulticast mode" + " in flow isolation mode", + dev->data->port_id); + return; + } ret = mlx5_traffic_restart(dev); if (ret) DRV_LOG(ERR, "port %u cannot enable allmulicast mode: %s", -- 2.11.0