* [dpdk-stable] [PATCH] net/mlx5: fix silent error for unsupported flow items
@ 2018-07-18 8:37 Nelio Laranjeiro
2018-07-27 1:27 ` Yongseok Koh
0 siblings, 1 reply; 4+ messages in thread
From: Nelio Laranjeiro @ 2018-07-18 8:37 UTC (permalink / raw)
To: stable, Yongseok Koh, Luca Boccassi
Not supported items are causing a silent error which does not stops the
conversion of the flow rule. This silent error ends in case of a flow
create by segmentation fault.
Fixes: 2097d0d1e2cc ("net/mlx5: support basic flow items and actions")
Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
---
The commit impacts the following stable branches:
v17.02, v17.05, v17.08, v17.11, v18.02, v18.05
---
drivers/net/mlx5/mlx5_flow.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index f48b68945..8ebc0928b 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -801,8 +801,10 @@ mlx5_flow_convert_items_validate(const struct rte_flow_item items[],
break;
}
}
- if (!token)
+ if (!token) {
+ ret = -ENOTSUP;
goto exit_item_not_supported;
+ }
cur_item = token;
ret = mlx5_flow_item_validate(items,
(const uint8_t *)cur_item->mask,
--
2.18.0
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [PATCH] net/mlx5: fix silent error for unsupported flow items
2018-07-18 8:37 [dpdk-stable] [PATCH] net/mlx5: fix silent error for unsupported flow items Nelio Laranjeiro
@ 2018-07-27 1:27 ` Yongseok Koh
2018-08-20 6:40 ` Nélio Laranjeiro
0 siblings, 1 reply; 4+ messages in thread
From: Yongseok Koh @ 2018-07-27 1:27 UTC (permalink / raw)
To: Nélio Laranjeiro; +Cc: stable, Luca Boccassi
Hi, Nelio
This patch has already been included by different title. Can you confirm the
patch in the following link is identical to yours and I can skip it for 17.11.4?
https://git.dpdk.org/dpdk-stable/commit/?h=17.11&id=fa532bac18bc3cf8efc9a9ecac12b5fa0b3e0d78
Thanks,
Yongseok
> On Jul 18, 2018, at 1:37 AM, Nelio Laranjeiro <nelio.laranjeiro@6wind.com> wrote:
>
> Not supported items are causing a silent error which does not stops the
> conversion of the flow rule. This silent error ends in case of a flow
> create by segmentation fault.
>
> Fixes: 2097d0d1e2cc ("net/mlx5: support basic flow items and actions")
>
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
>
> ---
>
> The commit impacts the following stable branches:
> v17.02, v17.05, v17.08, v17.11, v18.02, v18.05
> ---
> drivers/net/mlx5/mlx5_flow.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
> index f48b68945..8ebc0928b 100644
> --- a/drivers/net/mlx5/mlx5_flow.c
> +++ b/drivers/net/mlx5/mlx5_flow.c
> @@ -801,8 +801,10 @@ mlx5_flow_convert_items_validate(const struct rte_flow_item items[],
> break;
> }
> }
> - if (!token)
> + if (!token) {
> + ret = -ENOTSUP;
> goto exit_item_not_supported;
> + }
> cur_item = token;
> ret = mlx5_flow_item_validate(items,
> (const uint8_t *)cur_item->mask,
> --
> 2.18.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [PATCH] net/mlx5: fix silent error for unsupported flow items
2018-07-27 1:27 ` Yongseok Koh
@ 2018-08-20 6:40 ` Nélio Laranjeiro
2018-08-20 18:48 ` Luca Boccassi
0 siblings, 1 reply; 4+ messages in thread
From: Nélio Laranjeiro @ 2018-08-20 6:40 UTC (permalink / raw)
To: Yongseok Koh; +Cc: stable, Luca Boccassi
On Fri, Jul 27, 2018 at 01:27:34AM +0000, Yongseok Koh wrote:
> Hi, Nelio
>
> This patch has already been included by different title. Can you confirm the
> patch in the following link is identical to yours and I can skip it for 17.11.4?
>
> https://git.dpdk.org/dpdk-stable/commit/?h=17.11&id=fa532bac18bc3cf8efc9a9ecac12b5fa0b3e0d78
>
>
> Thanks,
> Yongseok
>[...]
Indeed, in this case the same patch should also be backported to the
other stable versions.
Regards,
--
Nélio Laranjeiro
6WIND
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-stable] [PATCH] net/mlx5: fix silent error for unsupported flow items
2018-08-20 6:40 ` Nélio Laranjeiro
@ 2018-08-20 18:48 ` Luca Boccassi
0 siblings, 0 replies; 4+ messages in thread
From: Luca Boccassi @ 2018-08-20 18:48 UTC (permalink / raw)
To: Nélio Laranjeiro; +Cc: stable
On Mon, 2018-08-20 at 08:40 +0200, Nélio Laranjeiro wrote:
> On Fri, Jul 27, 2018 at 01:27:34AM +0000, Yongseok Koh wrote:
> > Hi, Nelio
> >
> > This patch has already been included by different title. Can you
> > confirm the
> > patch in the following link is identical to yours and I can skip it
> > for 17.11.4?
> >
> > https://git.dpdk.org/dpdk-stable/commit/?h=17.11&id=fa532bac18bc3cf
> > 8efc9a9ecac12b5fa0b3e0d78
> >
> >
> > Thanks,
> > Yongseok
> > [...]
>
> Indeed, in this case the same patch should also be backported to the
> other stable versions.
Hi,
Does that also include 16.11? The patch as-is does not apply, and that
file does not exist in 16.11.
--
Kind regards,
Luca Boccassi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-20 18:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-18 8:37 [dpdk-stable] [PATCH] net/mlx5: fix silent error for unsupported flow items Nelio Laranjeiro
2018-07-27 1:27 ` Yongseok Koh
2018-08-20 6:40 ` Nélio Laranjeiro
2018-08-20 18:48 ` Luca Boccassi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).