* [dpdk-stable] [PATCH] test/event: fix eth Rx adapter autotest for skeleton PMD
@ 2018-09-05 12:03 Nikhil Rao
2018-09-05 13:51 ` [dpdk-stable] [PATCH v2 1/2] " Nikhil Rao
2018-09-25 7:19 ` [dpdk-stable] [PATCH v3 " Nikhil Rao
0 siblings, 2 replies; 6+ messages in thread
From: Nikhil Rao @ 2018-09-05 12:03 UTC (permalink / raw)
To: jerin.jacob; +Cc: dev, Nikhil Rao, vipin.varghese, stable
skeleton PMD does not support
RTE_EVENT_ETH_RX_ADAPTER_CAP_MULTI_EVENTQ and
implicit_release_disable so make the Rx queue_id = -1 and
initialize the event port configuration to zero.
Fixes: ec36d881f56d ("eventdev: add implicit release disable capability")
Fixes: 2a9c83ae3b2e ("test/eventdev: add multi-ports test")
Cc: vipin.varghese@intel.com
CC: stable@dpdk.org
Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
---
test/test/test_event_eth_rx_adapter.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/test/test/test_event_eth_rx_adapter.c b/test/test/test_event_eth_rx_adapter.c
index 2337e54..29d0ff5 100644
--- a/test/test/test_event_eth_rx_adapter.c
+++ b/test/test/test_event_eth_rx_adapter.c
@@ -317,7 +317,7 @@ struct event_eth_rx_adapter_test_params {
{
int err;
struct rte_event_dev_info dev_info;
- struct rte_event_port_conf rx_p_conf;
+ struct rte_event_port_conf rx_p_conf = {0};
err = rte_event_dev_info_get(TEST_DEV_ID, &dev_info);
TEST_ASSERT(err == 0, "Expected 0 got %d", err);
@@ -503,7 +503,7 @@ struct event_eth_rx_adapter_test_params {
port_index = 0;
for (; port_index < rte_eth_dev_count_total(); port_index += 1) {
err = rte_event_eth_rx_adapter_queue_add(TEST_INST_ID,
- port_index, 0,
+ port_index, -1,
&queue_config);
TEST_ASSERT(err == 0, "Expected 0 got %d", err);
}
@@ -512,7 +512,7 @@ struct event_eth_rx_adapter_test_params {
port_index = 0;
for (; port_index < rte_eth_dev_count_total(); port_index += 1) {
err = rte_event_eth_rx_adapter_queue_del(TEST_INST_ID,
- port_index, 0);
+ port_index, -1);
TEST_ASSERT(err == 0, "Expected 0 got %d", err);
}
--
1.8.3.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [dpdk-stable] [PATCH v2 1/2] test/event: fix eth Rx adapter autotest for skeleton PMD
2018-09-05 12:03 [dpdk-stable] [PATCH] test/event: fix eth Rx adapter autotest for skeleton PMD Nikhil Rao
@ 2018-09-05 13:51 ` Nikhil Rao
2018-09-10 13:44 ` Jerin Jacob
2018-09-25 7:19 ` [dpdk-stable] [PATCH v3 " Nikhil Rao
1 sibling, 1 reply; 6+ messages in thread
From: Nikhil Rao @ 2018-09-05 13:51 UTC (permalink / raw)
To: jerin.jacob; +Cc: dev, Nikhil Rao, vipin.varghese, stable
skeleton PMD does not support
RTE_EVENT_ETH_RX_ADAPTER_CAP_MULTI_EVENTQ and
implicit_release_disable so make the Rx queue_id = -1 and
initialize the event port configuration to zero.
Fixes: ec36d881f56d ("eventdev: add implicit release disable capability")
Fixes: 2a9c83ae3b2e ("test/eventdev: add multi-ports test")
Cc: vipin.varghese@intel.com
CC: stable@dpdk.org
Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
---
v2:
* add include patch to fix Rx adapter intr autotest as it is
dependent on the first patch.
test/test/test_event_eth_rx_adapter.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/test/test/test_event_eth_rx_adapter.c b/test/test/test_event_eth_rx_adapter.c
index 2337e54..29d0ff5 100644
--- a/test/test/test_event_eth_rx_adapter.c
+++ b/test/test/test_event_eth_rx_adapter.c
@@ -317,7 +317,7 @@ struct event_eth_rx_adapter_test_params {
{
int err;
struct rte_event_dev_info dev_info;
- struct rte_event_port_conf rx_p_conf;
+ struct rte_event_port_conf rx_p_conf = {0};
err = rte_event_dev_info_get(TEST_DEV_ID, &dev_info);
TEST_ASSERT(err == 0, "Expected 0 got %d", err);
@@ -503,7 +503,7 @@ struct event_eth_rx_adapter_test_params {
port_index = 0;
for (; port_index < rte_eth_dev_count_total(); port_index += 1) {
err = rte_event_eth_rx_adapter_queue_add(TEST_INST_ID,
- port_index, 0,
+ port_index, -1,
&queue_config);
TEST_ASSERT(err == 0, "Expected 0 got %d", err);
}
@@ -512,7 +512,7 @@ struct event_eth_rx_adapter_test_params {
port_index = 0;
for (; port_index < rte_eth_dev_count_total(); port_index += 1) {
err = rte_event_eth_rx_adapter_queue_del(TEST_INST_ID,
- port_index, 0);
+ port_index, -1);
TEST_ASSERT(err == 0, "Expected 0 got %d", err);
}
--
1.8.3.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-stable] [PATCH v2 1/2] test/event: fix eth Rx adapter autotest for skeleton PMD
2018-09-05 13:51 ` [dpdk-stable] [PATCH v2 1/2] " Nikhil Rao
@ 2018-09-10 13:44 ` Jerin Jacob
0 siblings, 0 replies; 6+ messages in thread
From: Jerin Jacob @ 2018-09-10 13:44 UTC (permalink / raw)
To: Nikhil Rao; +Cc: dev, vipin.varghese, stable
-----Original Message-----
> Date: Wed, 5 Sep 2018 19:21:05 +0530
> From: Nikhil Rao <nikhil.rao@intel.com>
> To: jerin.jacob@caviumnetworks.com
> CC: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>,
> vipin.varghese@intel.com, stable@dpdk.org
> Subject: [PATCH v2 1/2] test/event: fix eth Rx adapter autotest for
> skeleton PMD
> X-Mailer: git-send-email 1.8.3.1
>
> External Email
>
> skeleton PMD does not support
> RTE_EVENT_ETH_RX_ADAPTER_CAP_MULTI_EVENTQ and
> implicit_release_disable so make the Rx queue_id = -1 and
> initialize the event port configuration to zero.
>
> Fixes: ec36d881f56d ("eventdev: add implicit release disable capability")
> Fixes: 2a9c83ae3b2e ("test/eventdev: add multi-ports test")
> Cc: vipin.varghese@intel.com
> CC: stable@dpdk.org
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> ---
>
> v2:
> * add include patch to fix Rx adapter intr autotest as it is
> dependent on the first patch.
>
> test/test/test_event_eth_rx_adapter.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/test/test/test_event_eth_rx_adapter.c b/test/test/test_event_eth_rx_adapter.c
> index 2337e54..29d0ff5 100644
> --- a/test/test/test_event_eth_rx_adapter.c
> +++ b/test/test/test_event_eth_rx_adapter.c
> @@ -317,7 +317,7 @@ struct event_eth_rx_adapter_test_params {
> {
> int err;
> struct rte_event_dev_info dev_info;
> - struct rte_event_port_conf rx_p_conf;
> + struct rte_event_port_conf rx_p_conf = {0};
Some old compiler does not support this scheme. Can you do memset to
zero to make more portable.
>
> err = rte_event_dev_info_get(TEST_DEV_ID, &dev_info);
> TEST_ASSERT(err == 0, "Expected 0 got %d", err);
> @@ -503,7 +503,7 @@ struct event_eth_rx_adapter_test_params {
> port_index = 0;
> for (; port_index < rte_eth_dev_count_total(); port_index += 1) {
> err = rte_event_eth_rx_adapter_queue_add(TEST_INST_ID,
> - port_index, 0,
> + port_index, -1,
> &queue_config);
> TEST_ASSERT(err == 0, "Expected 0 got %d", err);
> }
> @@ -512,7 +512,7 @@ struct event_eth_rx_adapter_test_params {
> port_index = 0;
> for (; port_index < rte_eth_dev_count_total(); port_index += 1) {
> err = rte_event_eth_rx_adapter_queue_del(TEST_INST_ID,
> - port_index, 0);
> + port_index, -1);
> TEST_ASSERT(err == 0, "Expected 0 got %d", err);
> }
>
> --
> 1.8.3.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-stable] [PATCH v3 1/2] test/event: fix eth Rx adapter autotest for skeleton PMD
2018-09-05 12:03 [dpdk-stable] [PATCH] test/event: fix eth Rx adapter autotest for skeleton PMD Nikhil Rao
2018-09-05 13:51 ` [dpdk-stable] [PATCH v2 1/2] " Nikhil Rao
@ 2018-09-25 7:19 ` Nikhil Rao
2018-09-29 11:59 ` Jerin Jacob
2018-10-01 10:09 ` Jerin Jacob
1 sibling, 2 replies; 6+ messages in thread
From: Nikhil Rao @ 2018-09-25 7:19 UTC (permalink / raw)
To: jerin.jacob; +Cc: dev, Nikhil Rao, vipin.varghese, stable
skeleton PMD does not support
RTE_EVENT_ETH_RX_ADAPTER_CAP_MULTI_EVENTQ and
implicit_release_disable so make the Rx queue_id = -1 and
initialize the event port configuration to zero.
Fixes: ec36d881f56d ("eventdev: add implicit release disable capability")
Fixes: 2a9c83ae3b2e ("test/eventdev: add multi-ports test")
Cc: vipin.varghese@intel.com
CC: stable@dpdk.org
Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
---
test/test/test_event_eth_rx_adapter.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
v2:
* include patch to fix Rx adapter intr autotest as it is
dependent on the first patch in this series.
v3:
* use memset to initialize structure in place of assignment.
diff --git a/test/test/test_event_eth_rx_adapter.c b/test/test/test_event_eth_rx_adapter.c
index d6d137e..080ff04 100644
--- a/test/test/test_event_eth_rx_adapter.c
+++ b/test/test/test_event_eth_rx_adapter.c
@@ -312,6 +312,8 @@ struct event_eth_rx_adapter_test_params {
struct rte_event_dev_info dev_info;
struct rte_event_port_conf rx_p_conf;
+ memset(&rx_p_conf, 0, sizeof(rx_p_conf));
+
err = rte_event_dev_info_get(TEST_DEV_ID, &dev_info);
TEST_ASSERT(err == 0, "Expected 0 got %d", err);
@@ -493,7 +495,7 @@ struct event_eth_rx_adapter_test_params {
port_index = 0;
for (; port_index < rte_eth_dev_count_total(); port_index += 1) {
err = rte_event_eth_rx_adapter_queue_add(TEST_INST_ID,
- port_index, 0,
+ port_index, -1,
&queue_config);
TEST_ASSERT(err == 0, "Expected 0 got %d", err);
}
@@ -502,7 +504,7 @@ struct event_eth_rx_adapter_test_params {
port_index = 0;
for (; port_index < rte_eth_dev_count_total(); port_index += 1) {
err = rte_event_eth_rx_adapter_queue_del(TEST_INST_ID,
- port_index, 0);
+ port_index, -1);
TEST_ASSERT(err == 0, "Expected 0 got %d", err);
}
--
1.8.3.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-stable] [PATCH v3 1/2] test/event: fix eth Rx adapter autotest for skeleton PMD
2018-09-25 7:19 ` [dpdk-stable] [PATCH v3 " Nikhil Rao
@ 2018-09-29 11:59 ` Jerin Jacob
2018-10-01 10:09 ` Jerin Jacob
1 sibling, 0 replies; 6+ messages in thread
From: Jerin Jacob @ 2018-09-29 11:59 UTC (permalink / raw)
To: Nikhil Rao; +Cc: dev, vipin.varghese, stable
-----Original Message-----
> Date: Tue, 25 Sep 2018 12:49:04 +0530
> From: Nikhil Rao <nikhil.rao@intel.com>
> To: jerin.jacob@caviumnetworks.com
> CC: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>,
> vipin.varghese@intel.com, stable@dpdk.org
> Subject: [PATCH v3 1/2] test/event: fix eth Rx adapter autotest for
> skeleton PMD
> X-Mailer: git-send-email 1.8.3.1
>
> skeleton PMD does not support
> RTE_EVENT_ETH_RX_ADAPTER_CAP_MULTI_EVENTQ and
> implicit_release_disable so make the Rx queue_id = -1 and
> initialize the event port configuration to zero.
>
> Fixes: ec36d881f56d ("eventdev: add implicit release disable capability")
> Fixes: 2a9c83ae3b2e ("test/eventdev: add multi-ports test")
> Cc: vipin.varghese@intel.com
> CC: stable@dpdk.org
>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [dpdk-stable] [PATCH v3 1/2] test/event: fix eth Rx adapter autotest for skeleton PMD
2018-09-25 7:19 ` [dpdk-stable] [PATCH v3 " Nikhil Rao
2018-09-29 11:59 ` Jerin Jacob
@ 2018-10-01 10:09 ` Jerin Jacob
1 sibling, 0 replies; 6+ messages in thread
From: Jerin Jacob @ 2018-10-01 10:09 UTC (permalink / raw)
To: Nikhil Rao; +Cc: dev, vipin.varghese, stable
-----Original Message-----
> Date: Tue, 25 Sep 2018 12:49:04 +0530
> From: Nikhil Rao <nikhil.rao@intel.com>
> To: jerin.jacob@caviumnetworks.com
> CC: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>,
> vipin.varghese@intel.com, stable@dpdk.org
> Subject: [PATCH v3 1/2] test/event: fix eth Rx adapter autotest for
> skeleton PMD
> X-Mailer: git-send-email 1.8.3.1
>
>
> skeleton PMD does not support
> RTE_EVENT_ETH_RX_ADAPTER_CAP_MULTI_EVENTQ and
> implicit_release_disable so make the Rx queue_id = -1 and
> initialize the event port configuration to zero.
>
> Fixes: ec36d881f56d ("eventdev: add implicit release disable capability")
> Fixes: 2a9c83ae3b2e ("test/eventdev: add multi-ports test")
> Cc: vipin.varghese@intel.com
> CC: stable@dpdk.org
>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
Series applied to dpdk-next-eventdev/master. Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-10-01 10:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-05 12:03 [dpdk-stable] [PATCH] test/event: fix eth Rx adapter autotest for skeleton PMD Nikhil Rao
2018-09-05 13:51 ` [dpdk-stable] [PATCH v2 1/2] " Nikhil Rao
2018-09-10 13:44 ` Jerin Jacob
2018-09-25 7:19 ` [dpdk-stable] [PATCH v3 " Nikhil Rao
2018-09-29 11:59 ` Jerin Jacob
2018-10-01 10:09 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).