patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Nikhil Rao <nikhil.rao@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH] test/event: remove RSS config in eth Rx adapter test
Date: Thu, 20 Sep 2018 10:29:55 +0530	[thread overview]
Message-ID: <20180920045952.GA2003@jerin> (raw)
In-Reply-To: <1536140526-7668-1-git-send-email-nikhil.rao@intel.com>

-----Original Message-----
> Date: Wed, 5 Sep 2018 15:12:06 +0530
> From: Nikhil Rao <nikhil.rao@intel.com>
> To: jerin.jacob@caviumnetworks.com
> CC: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>, stable@dpdk.org
> Subject: [PATCH] test/event: remove RSS config in eth Rx adapter test
> X-Mailer: git-send-email 1.8.3.1
> 
> External Email
> 
> Remove RSS config as it is not required (this also fixes an
> error with a hardcoded RSS config not supported by the NIC)
> 
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> Fixes: 8863a1fbfc66 ("ethdev: add supported hash function check")
> CC: stable@dpdk.org
> ---
>  test/test/test_event_eth_rx_adapter.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/test/test/test_event_eth_rx_adapter.c b/test/test/test_event_eth_rx_adapter.c
> index 2337e54..4cca77f 100644
> --- a/test/test/test_event_eth_rx_adapter.c
> +++ b/test/test/test_event_eth_rx_adapter.c
> @@ -117,13 +117,6 @@ struct event_eth_rx_adapter_test_params {
>                         .mq_mode = ETH_MQ_RX_RSS,

Ideally you need to set .mq_mode as ETH_MQ_RX_NONE to disable RSS.

>                         .max_rx_pkt_len = ETHER_MAX_LEN
>                 },
> -               .rx_adv_conf = {
> -                       .rss_conf = {
> -                               .rss_hf = ETH_RSS_IP |
> -                                       ETH_RSS_TCP |
> -                                       ETH_RSS_UDP,
> -                       }
> -               }
>         };
> 
>         return port_init_common(port, &port_conf_default, mp);
> --
> 1.8.3.1
> 

  reply	other threads:[~2018-09-20  5:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-05  9:42 Nikhil Rao
2018-09-20  4:59 ` Jerin Jacob [this message]
2018-09-24  8:31 ` [dpdk-stable] [PATCH v2] test/event: fix " Nikhil Rao
2018-09-24  8:53   ` [dpdk-stable] [PATCH v3] " Nikhil Rao
2018-09-25  3:15     ` Jerin Jacob
2018-09-28 13:02       ` [dpdk-stable] [dpdk-dev] " Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180920045952.GA2003@jerin \
    --to=jerin.jacob@caviumnetworks.com \
    --cc=dev@dpdk.org \
    --cc=nikhil.rao@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).