patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] test/event: remove RSS config in eth Rx adapter test
@ 2018-09-05  9:42 Nikhil Rao
  2018-09-20  4:59 ` Jerin Jacob
  2018-09-24  8:31 ` [dpdk-stable] [PATCH v2] test/event: fix " Nikhil Rao
  0 siblings, 2 replies; 6+ messages in thread
From: Nikhil Rao @ 2018-09-05  9:42 UTC (permalink / raw)
  To: jerin.jacob; +Cc: dev, Nikhil Rao, stable

Remove RSS config as it is not required (this also fixes an
error with a hardcoded RSS config not supported by the NIC)

Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
Fixes: 8863a1fbfc66 ("ethdev: add supported hash function check")
CC: stable@dpdk.org
---
 test/test/test_event_eth_rx_adapter.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/test/test/test_event_eth_rx_adapter.c b/test/test/test_event_eth_rx_adapter.c
index 2337e54..4cca77f 100644
--- a/test/test/test_event_eth_rx_adapter.c
+++ b/test/test/test_event_eth_rx_adapter.c
@@ -117,13 +117,6 @@ struct event_eth_rx_adapter_test_params {
 			.mq_mode = ETH_MQ_RX_RSS,
 			.max_rx_pkt_len = ETHER_MAX_LEN
 		},
-		.rx_adv_conf = {
-			.rss_conf = {
-				.rss_hf = ETH_RSS_IP |
-					ETH_RSS_TCP |
-					ETH_RSS_UDP,
-			}
-		}
 	};
 
 	return port_init_common(port, &port_conf_default, mp);
-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-stable] [PATCH] test/event: remove RSS config in eth Rx adapter test
  2018-09-05  9:42 [dpdk-stable] [PATCH] test/event: remove RSS config in eth Rx adapter test Nikhil Rao
@ 2018-09-20  4:59 ` Jerin Jacob
  2018-09-24  8:31 ` [dpdk-stable] [PATCH v2] test/event: fix " Nikhil Rao
  1 sibling, 0 replies; 6+ messages in thread
From: Jerin Jacob @ 2018-09-20  4:59 UTC (permalink / raw)
  To: Nikhil Rao; +Cc: dev, stable

-----Original Message-----
> Date: Wed, 5 Sep 2018 15:12:06 +0530
> From: Nikhil Rao <nikhil.rao@intel.com>
> To: jerin.jacob@caviumnetworks.com
> CC: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>, stable@dpdk.org
> Subject: [PATCH] test/event: remove RSS config in eth Rx adapter test
> X-Mailer: git-send-email 1.8.3.1
> 
> External Email
> 
> Remove RSS config as it is not required (this also fixes an
> error with a hardcoded RSS config not supported by the NIC)
> 
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> Fixes: 8863a1fbfc66 ("ethdev: add supported hash function check")
> CC: stable@dpdk.org
> ---
>  test/test/test_event_eth_rx_adapter.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/test/test/test_event_eth_rx_adapter.c b/test/test/test_event_eth_rx_adapter.c
> index 2337e54..4cca77f 100644
> --- a/test/test/test_event_eth_rx_adapter.c
> +++ b/test/test/test_event_eth_rx_adapter.c
> @@ -117,13 +117,6 @@ struct event_eth_rx_adapter_test_params {
>                         .mq_mode = ETH_MQ_RX_RSS,

Ideally you need to set .mq_mode as ETH_MQ_RX_NONE to disable RSS.

>                         .max_rx_pkt_len = ETHER_MAX_LEN
>                 },
> -               .rx_adv_conf = {
> -                       .rss_conf = {
> -                               .rss_hf = ETH_RSS_IP |
> -                                       ETH_RSS_TCP |
> -                                       ETH_RSS_UDP,
> -                       }
> -               }
>         };
> 
>         return port_init_common(port, &port_conf_default, mp);
> --
> 1.8.3.1
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dpdk-stable] [PATCH v2] test/event: fix RSS config in eth Rx adapter test
  2018-09-05  9:42 [dpdk-stable] [PATCH] test/event: remove RSS config in eth Rx adapter test Nikhil Rao
  2018-09-20  4:59 ` Jerin Jacob
@ 2018-09-24  8:31 ` Nikhil Rao
  2018-09-24  8:53   ` [dpdk-stable] [PATCH v3] " Nikhil Rao
  1 sibling, 1 reply; 6+ messages in thread
From: Nikhil Rao @ 2018-09-24  8:31 UTC (permalink / raw)
  To: jerin.jacob; +Cc: dev, Nikhil Rao, stable

Remove RSS config as it is not required. The hardcoded RSS
configuraton also generates an error on NICs that don't support
it.

Fixes: 8863a1fbfc66 ("ethdev: add supported hash function check")
CC: stable@dpdk.org

Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
---
 test/test/test_event_eth_rx_adapter.c | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/test/test/test_event_eth_rx_adapter.c b/test/test/test_event_eth_rx_adapter.c
index 28f2146..3c19ee0 100644
--- a/test/test/test_event_eth_rx_adapter.c
+++ b/test/test/test_event_eth_rx_adapter.c
@@ -98,8 +98,7 @@ struct event_eth_rx_adapter_test_params {
 {
 	static const struct rte_eth_conf port_conf_default = {
 		.rxmode = {
-			.mq_mode = ETH_MQ_RX_RSS,
-			.max_rx_pkt_len = ETHER_MAX_LEN
+			.mq_mode = ETH_MQ_RX_NONE,
 		},
 		.intr_conf = {
 			.rxq = 1,
@@ -114,16 +113,8 @@ struct event_eth_rx_adapter_test_params {
 {
 	static const struct rte_eth_conf port_conf_default = {
 		.rxmode = {
-			.mq_mode = ETH_MQ_RX_RSS,
-			.max_rx_pkt_len = ETHER_MAX_LEN
+			.mq_mode = ETH_MQ_RX_NONE,
 		},
-		.rx_adv_conf = {
-			.rss_conf = {
-				.rss_hf = ETH_RSS_IP |
-					ETH_RSS_TCP |
-					ETH_RSS_UDP,
-			}
-		}
 	};
 
 	return port_init_common(port, &port_conf_default, mp);
-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dpdk-stable] [PATCH v3] test/event: fix RSS config in eth Rx adapter test
  2018-09-24  8:31 ` [dpdk-stable] [PATCH v2] test/event: fix " Nikhil Rao
@ 2018-09-24  8:53   ` Nikhil Rao
  2018-09-25  3:15     ` Jerin Jacob
  0 siblings, 1 reply; 6+ messages in thread
From: Nikhil Rao @ 2018-09-24  8:53 UTC (permalink / raw)
  To: jerin.jacob; +Cc: dev, Nikhil Rao, stable

Remove RSS config as it is not required. The hardcoded RSS
configuration also generates an error on NICs that don't support
it.

Fixes: 8863a1fbfc66 ("ethdev: add supported hash function check")
CC: stable@dpdk.org

Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
---
v2:
- use ETH_MQ_RX_NONE to disable RSS (Jerin Jacob)

v3:
- fix typo in commit message (checkpatch warning)

 test/test/test_event_eth_rx_adapter.c | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

diff --git a/test/test/test_event_eth_rx_adapter.c b/test/test/test_event_eth_rx_adapter.c
index 28f2146..3c19ee0 100644
--- a/test/test/test_event_eth_rx_adapter.c
+++ b/test/test/test_event_eth_rx_adapter.c
@@ -98,8 +98,7 @@ struct event_eth_rx_adapter_test_params {
 {
 	static const struct rte_eth_conf port_conf_default = {
 		.rxmode = {
-			.mq_mode = ETH_MQ_RX_RSS,
-			.max_rx_pkt_len = ETHER_MAX_LEN
+			.mq_mode = ETH_MQ_RX_NONE,
 		},
 		.intr_conf = {
 			.rxq = 1,
@@ -114,16 +113,8 @@ struct event_eth_rx_adapter_test_params {
 {
 	static const struct rte_eth_conf port_conf_default = {
 		.rxmode = {
-			.mq_mode = ETH_MQ_RX_RSS,
-			.max_rx_pkt_len = ETHER_MAX_LEN
+			.mq_mode = ETH_MQ_RX_NONE,
 		},
-		.rx_adv_conf = {
-			.rss_conf = {
-				.rss_hf = ETH_RSS_IP |
-					ETH_RSS_TCP |
-					ETH_RSS_UDP,
-			}
-		}
 	};
 
 	return port_init_common(port, &port_conf_default, mp);
-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-stable] [PATCH v3] test/event: fix RSS config in eth Rx adapter test
  2018-09-24  8:53   ` [dpdk-stable] [PATCH v3] " Nikhil Rao
@ 2018-09-25  3:15     ` Jerin Jacob
  2018-09-28 13:02       ` [dpdk-stable] [dpdk-dev] " Jerin Jacob
  0 siblings, 1 reply; 6+ messages in thread
From: Jerin Jacob @ 2018-09-25  3:15 UTC (permalink / raw)
  To: Nikhil Rao; +Cc: dev, stable

-----Original Message-----
> Date: Mon, 24 Sep 2018 14:23:47 +0530
> From: Nikhil Rao <nikhil.rao@intel.com>
> To: jerin.jacob@caviumnetworks.com
> CC: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>, stable@dpdk.org
> Subject: [PATCH v3] test/event: fix RSS config in eth Rx adapter test
> X-Mailer: git-send-email 1.8.3.1
> 
> 
> Remove RSS config as it is not required. The hardcoded RSS
> configuration also generates an error on NICs that don't support
> it.
> 
> Fixes: 8863a1fbfc66 ("ethdev: add supported hash function check")
> CC: stable@dpdk.org
> 
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>

Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>

Please use  --in-reply-to for new version.
Search  --in-reply-to in the below link for more details.
http://doc.dpdk.org/guides/contributing/patches.html

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH v3] test/event: fix RSS config in eth Rx adapter test
  2018-09-25  3:15     ` Jerin Jacob
@ 2018-09-28 13:02       ` Jerin Jacob
  0 siblings, 0 replies; 6+ messages in thread
From: Jerin Jacob @ 2018-09-28 13:02 UTC (permalink / raw)
  To: Nikhil Rao; +Cc: dev, stable

-----Original Message-----
> Date: Tue, 25 Sep 2018 08:45:49 +0530
> From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> To: Nikhil Rao <nikhil.rao@intel.com>
> CC: dev@dpdk.org, stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v3] test/event: fix RSS config in eth Rx
>  adapter test
> User-Agent: Mutt/1.10.1 (2018-07-13)
> 
> 
> -----Original Message-----
> > Date: Mon, 24 Sep 2018 14:23:47 +0530
> > From: Nikhil Rao <nikhil.rao@intel.com>
> > To: jerin.jacob@caviumnetworks.com
> > CC: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>, stable@dpdk.org
> > Subject: [PATCH v3] test/event: fix RSS config in eth Rx adapter test
> > X-Mailer: git-send-email 1.8.3.1
> >
> >
> > Remove RSS config as it is not required. The hardcoded RSS
> > configuration also generates an error on NICs that don't support
> > it.
> >
> > Fixes: 8863a1fbfc66 ("ethdev: add supported hash function check")
> > CC: stable@dpdk.org
> >
> > Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> 
> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> 

Applied to dpdk-next-eventdev/master. Thanks.

> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-09-28 13:03 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-05  9:42 [dpdk-stable] [PATCH] test/event: remove RSS config in eth Rx adapter test Nikhil Rao
2018-09-20  4:59 ` Jerin Jacob
2018-09-24  8:31 ` [dpdk-stable] [PATCH v2] test/event: fix " Nikhil Rao
2018-09-24  8:53   ` [dpdk-stable] [PATCH v3] " Nikhil Rao
2018-09-25  3:15     ` Jerin Jacob
2018-09-28 13:02       ` [dpdk-stable] [dpdk-dev] " Jerin Jacob

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).