From: Jerin Jacob <jerin.jacob@caviumnetworks.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Nikhil Rao <nikhil.rao@intel.com>, dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v2] eventdev: fix port id argument in Rx adapter caps API
Date: Tue, 25 Sep 2018 15:26:27 +0530 [thread overview]
Message-ID: <20180925095626.GA20972@jerin> (raw)
In-Reply-To: <2681112.ibEmUdxJTb@xps>
-----Original Message-----
> Date: Tue, 25 Sep 2018 11:50:06 +0200
> From: Thomas Monjalon <thomas@monjalon.net>
> To: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> Cc: Nikhil Rao <nikhil.rao@intel.com>, dev@dpdk.org, stable@dpdk.org
> Subject: Re: [PATCH v2] eventdev: fix port id argument in Rx adapter caps
> API
>
>
> 25/09/2018 11:15, Jerin Jacob:
> > -----Original Message-----
> > > Date: Tue, 25 Sep 2018 14:19:12 +0530
> > > From: Nikhil Rao <nikhil.rao@intel.com>
> > > To: jerin.jacob@caviumnetworks.com
> > > CC: dev@dpdk.org, Nikhil Rao <nikhil.rao@intel.com>, stable@dpdk.org
> > > Subject: [PATCH v2] eventdev: fix port id argument in Rx adapter caps API
> > > X-Mailer: git-send-email 1.8.3.1
> > >
> > >
> > > Make the ethernet port id passed into
> > > rte_event_eth_rx_adapter_caps_get() 16 bit.
> > >
> > > Also, update the event rx adapter test to use 16 bit
> > > ethernet port ids.
> > >
> > > Fixes: c2189c907dd1 ("eventdev: make ethdev port identifiers 16-bit")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
> > > Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
> > > ---
> > >
> > > v2:
> > > * squash changes to autotest and library into a single patch (Jerin Jacob)
> > > * add update to release notes (Jerin Jacob)
> > >
> > > lib/librte_eventdev/rte_eventdev.h | 2 +-
> > > lib/librte_eventdev/rte_eventdev.c | 2 +-
> > > test/test/test_event_eth_rx_adapter.c | 6 +++---
> > > doc/guides/rel_notes/release_18_11.rst | 4 +++-
> > > lib/librte_eventdev/Makefile | 2 +-
> >
> > Missing version update in lib/librte_eventdev/meson.build. See version=
> >
> > > 5 files changed, 9 insertions(+), 7 deletions(-)
> > >
> > > ABI Changes
> > > -----------
> > > @@ -162,7 +164,7 @@ The libraries prepended with a plus sign were incremented in this version.
> > > librte_distributor.so.1
> > > librte_eal.so.8
> > > librte_ethdev.so.10
> > > - librte_eventdev.so.4
> > > + + librte_eventdev.so.6
> >
> > Can you send a separate standalone patch to fixup doc/guides/rel_notes/release_18_08.rst
> > release notes. The version(change to librte_eventdev.so.5) should have been
> > updated in change set in 3810ae4357.
> >
> > +Thomas,
> > In case if he has difference in opinion on updating released release note file.
>
> I prefer such changes being atomic.
Me too. But the offending change set(3810ae4357) is old
➜ [master][dpdk.org] $ git describe 3810ae4357
v18.05-389-g3810ae435
Do you prefer to have patch to update the release_18_08.rst file or ignore it?
>
>
next prev parent reply other threads:[~2018-09-25 9:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-05 12:21 [dpdk-stable] [PATCH 1/2] " Nikhil Rao
2018-09-05 12:21 ` [dpdk-stable] [PATCH 2/2] test/event: change ethernet port ids to be 16 bit Nikhil Rao
2018-09-17 14:14 ` [dpdk-stable] [PATCH 1/2] eventdev: fix port id argument in Rx adapter caps API Jerin Jacob
2018-09-25 8:49 ` [dpdk-stable] [PATCH v2] " Nikhil Rao
2018-09-25 9:15 ` Jerin Jacob
2018-09-25 9:50 ` Thomas Monjalon
2018-09-25 9:56 ` Jerin Jacob [this message]
2018-09-25 12:52 ` Thomas Monjalon
2018-09-25 9:49 ` [dpdk-stable] [PATCH v3] " Nikhil Rao
2018-09-28 14:54 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180925095626.GA20972@jerin \
--to=jerin.jacob@caviumnetworks.com \
--cc=dev@dpdk.org \
--cc=nikhil.rao@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).