From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 45A421B3B8 for ; Wed, 3 Oct 2018 18:52:53 +0200 (CEST) Received: by mail-wr1-f66.google.com with SMTP id x12-v6so6921426wru.8 for ; Wed, 03 Oct 2018 09:52:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QK9K4bXrEbaPPggllawGzPRLdaUMdjCetJ5v5XkjuRE=; b=cK9CmCQggZCvbnjXm2AVJLa+wOWNgqYVQf7w0QxfcZmwIKUTkMwi4BYUMvievNhI/p YlR3dWa8woEwOleJ2h/APZYKV+szoZMlyQOIwREKCa4OEUBY7n4/BNM1hqbr/IOzV1tt b6CKzg4jTctrH+0P2iR5NGkEYMTy1S7N+RB9au78bnEVPxHgNqmtKwKam895sVwP6N3o V10ACokswbIwp0FjmHz/ibG0UsPCymNyOScMzlCjY7nZtlZ9flAotl/iq6Zd/we905On hdq7FOdihvg9onNfNltOvAEV0wE1/Y9o71GX+CPmoY8oSBK1JCnWHfl8cVgXI10rZ7k8 3SGg== X-Gm-Message-State: ABuFfogU3eTEdxTDjOWMAuuWQHjaYNtNPYO3dQy1zkQdmCvJsw6bb7Pq x1sGuTq0yhA2rob5r2lQX3k= X-Google-Smtp-Source: ACcGV63if3G8kv+xSWWk7XRzPAxp4wEZi8y8DPiybQkMgzT24iK7UDpam18yFL3W0eUsAWXaAIujsQ== X-Received: by 2002:adf:c748:: with SMTP id b8-v6mr2010748wrh.134.1538585572866; Wed, 03 Oct 2018 09:52:52 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id l67-v6sm4899780wma.20.2018.10.03.09.52.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 03 Oct 2018 09:52:51 -0700 (PDT) From: Luca Boccassi To: Tiwei Bie Cc: Maxime Coquelin , dpdk stable Date: Wed, 3 Oct 2018 17:52:36 +0100 Message-Id: <20181003165239.8531-3-bluca@debian.org> X-Mailer: git-send-email 2.19.0 In-Reply-To: <20181003165239.8531-1-bluca@debian.org> References: <20181003162121.16364-1-bluca@debian.org> <20181003165239.8531-1-bluca@debian.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/virtio: add missing supported features' has been queued to LTS release 16.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 03 Oct 2018 16:52:53 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/05/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Luca Boccassi --- >>From 02be74f19bd0dbd4226a1e028731755c3e914f28 Mon Sep 17 00:00:00 2001 From: Tiwei Bie Date: Fri, 21 Sep 2018 20:52:43 +0800 Subject: [PATCH] net/virtio: add missing supported features [ upstream commit 66908eff12627c3dd09b0e1f3801d57b425f2e23 ] The virtio features VIRTIO_NET_F_CSUM, VIRTIO_NET_F_HOST_TSO4 and VIRTIO_NET_F_HOST_TSO6 are supported by the virtio PMD. But they are missing in the supported feature set. And since below commit: commit 4174a7b59d05 ("net/virtio: improve Tx offload features negotiation") Virtio PMD will announce the Tx offloading capabilities based on the features read from the device. And virtio-user won't report the features which are not in virtio-PMD's supported feature set. So since that commit, virtio-user won't announce the DEV_TX_OFFLOAD_UDP_CKSUM, DEV_TX_OFFLOAD_TCP_CKSUM and DEV_TX_OFFLOAD_TCP_TSO offloading capabilities even if the vhost backend supports them. This patch adds these missing features, and virtio-user will report them if the backend supports them. Fixes: 142678d42959 ("net/virtio-user: fix wrongly get/set features") Signed-off-by: Tiwei Bie Reviewed-by: Maxime Coquelin --- drivers/net/virtio/virtio_ethdev.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_ethdev.h b/drivers/net/virtio/virtio_ethdev.h index c491ec1b02..5122792a3a 100644 --- a/drivers/net/virtio/virtio_ethdev.h +++ b/drivers/net/virtio/virtio_ethdev.h @@ -74,7 +74,11 @@ (VIRTIO_PMD_DEFAULT_GUEST_FEATURES | \ 1u << VIRTIO_NET_F_GUEST_CSUM | \ 1u << VIRTIO_NET_F_GUEST_TSO4 | \ - 1u << VIRTIO_NET_F_GUEST_TSO6) + 1u << VIRTIO_NET_F_GUEST_TSO6 | \ + 1u << VIRTIO_NET_F_CSUM | \ + 1u << VIRTIO_NET_F_HOST_TSO4 | \ + 1u << VIRTIO_NET_F_HOST_TSO6) + /* * CQ function prototype */ -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-10-03 17:44:54.640397853 +0100 +++ 0003-net-virtio-add-missing-supported-features.patch 2018-10-03 17:44:54.566534589 +0100 @@ -1,8 +1,10 @@ -From 66908eff12627c3dd09b0e1f3801d57b425f2e23 Mon Sep 17 00:00:00 2001 +From 02be74f19bd0dbd4226a1e028731755c3e914f28 Mon Sep 17 00:00:00 2001 From: Tiwei Bie Date: Fri, 21 Sep 2018 20:52:43 +0800 Subject: [PATCH] net/virtio: add missing supported features +[ upstream commit 66908eff12627c3dd09b0e1f3801d57b425f2e23 ] + The virtio features VIRTIO_NET_F_CSUM, VIRTIO_NET_F_HOST_TSO4 and VIRTIO_NET_F_HOST_TSO6 are supported by the virtio PMD. But they are missing in the supported feature set. And since @@ -22,19 +24,18 @@ report them if the backend supports them. Fixes: 142678d42959 ("net/virtio-user: fix wrongly get/set features") -Cc: stable@dpdk.org Signed-off-by: Tiwei Bie Reviewed-by: Maxime Coquelin --- - drivers/net/virtio/virtio_ethdev.h | 5 ++++- - 1 file changed, 4 insertions(+), 1 deletion(-) + drivers/net/virtio/virtio_ethdev.h | 6 +++++- + 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/virtio/virtio_ethdev.h b/drivers/net/virtio/virtio_ethdev.h -index b726ad1084..e0f80e5a48 100644 +index c491ec1b02..5122792a3a 100644 --- a/drivers/net/virtio/virtio_ethdev.h +++ b/drivers/net/virtio/virtio_ethdev.h -@@ -40,7 +40,10 @@ +@@ -74,7 +74,11 @@ (VIRTIO_PMD_DEFAULT_GUEST_FEATURES | \ 1u << VIRTIO_NET_F_GUEST_CSUM | \ 1u << VIRTIO_NET_F_GUEST_TSO4 | \ @@ -43,9 +44,10 @@ + 1u << VIRTIO_NET_F_CSUM | \ + 1u << VIRTIO_NET_F_HOST_TSO4 | \ + 1u << VIRTIO_NET_F_HOST_TSO6) - ++ /* * CQ function prototype + */ -- 2.19.0