From: Ilya Maximets <i.maximets@samsung.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
dev@dpdk.org, tiwei.bie@intel.com, zhihong.wang@intel.com,
jfreimann@redhat.com, nicknickolaev@gmail.com,
bruce.richardson@intel.com, alejandro.lucero@netronome.com
Cc: dgilbert@redhat.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v3 18/19] vhost: add flag to enable postcopy live-migration
Date: Mon, 8 Oct 2018 19:25:16 +0300 [thread overview]
Message-ID: <20181008162251eucas1p29fb65b432d9b202d635f37240baa2630~brrCTgLSL0635706357eucas1p2Z@eucas1p2.samsung.com> (raw)
In-Reply-To: <20181005142201eucas1p1359f104e0fc99b03019452350b44f631~avFrXXPTu2477524775eucas1p1A@eucas1p1.samsung.com>
Have you missed this mail while preparing v4?
Best regards, Ilya Maximets.
On 05.10.2018 17:24, Ilya Maximets wrote:
> I think it'll be nice to have a warning in case zero-copy
> and postcopy enabled at the same time. This warning will
> clarify for users why postcopy is not enabled.
> What do you think?
>
> Maybe we can also move the check from the previous patch to
> rte_vhost_driver_register() like it done for VIRTIO_F_IN_ORDER ?
> We can't change the set of enabled features in runtime anyway.
>
> Best regards, Ilya Maximets.
>
> On 04.10.2018 11:14, Maxime Coquelin wrote:
>> Postcopy live-migration feature require the application to
>> not populate the guest memory. As the vhost library cannot
>> prevent the application to that (e.g. preventing the
>> application to call mlockall()), the feature is disabled by
>> default.
>>
>> The application should only enable the feature if it does not
>> force the guest memory to be populated.
>>
>> In case the user passes the RTE_VHOST_USER_POSTCOPY_SUPPORT
>> flag at registration but the feature was not compiled,
>> registration fails.
>>
>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>> ---
>> doc/guides/prog_guide/vhost_lib.rst | 8 ++++++++
>> lib/librte_vhost/rte_vhost.h | 1 +
>> lib/librte_vhost/socket.c | 19 +++++++++++++++++--
>> 3 files changed, 26 insertions(+), 2 deletions(-)
>>
>> diff --git a/doc/guides/prog_guide/vhost_lib.rst b/doc/guides/prog_guide/vhost_lib.rst
>> index 77af4d775..c77df338f 100644
>> --- a/doc/guides/prog_guide/vhost_lib.rst
>> +++ b/doc/guides/prog_guide/vhost_lib.rst
>> @@ -106,6 +106,14 @@ The following is an overview of some key Vhost API functions:
>> Enabling this flag with these Qemu version results in Qemu being blocked
>> when multiple queue pairs are declared.
>>
>> + - ``RTE_VHOST_USER_POSTCOPY_SUPPORT``
>> +
>> + Postcopy live-migration support will be enabled when this flag is set.
>> + It is disabled by default.
>> +
>> + Enabling this flag should only be done when the calling application does
>> + not pre-fault the guest shared memory, otherwise migration would fail.
>> +
>> * ``rte_vhost_driver_set_features(path, features)``
>>
>> This function sets the feature bits the vhost-user driver supports. The
>> diff --git a/lib/librte_vhost/rte_vhost.h b/lib/librte_vhost/rte_vhost.h
>> index b3cc6990d..b26afbffa 100644
>> --- a/lib/librte_vhost/rte_vhost.h
>> +++ b/lib/librte_vhost/rte_vhost.h
>> @@ -28,6 +28,7 @@ extern "C" {
>> #define RTE_VHOST_USER_NO_RECONNECT (1ULL << 1)
>> #define RTE_VHOST_USER_DEQUEUE_ZERO_COPY (1ULL << 2)
>> #define RTE_VHOST_USER_IOMMU_SUPPORT (1ULL << 3)
>> +#define RTE_VHOST_USER_POSTCOPY_SUPPORT (1ULL << 4)
>>
>> /** Protocol features. */
>> #ifndef VHOST_USER_PROTOCOL_F_MQ
>> diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c
>> index c04d3d305..3df303be8 100644
>> --- a/lib/librte_vhost/socket.c
>> +++ b/lib/librte_vhost/socket.c
>> @@ -51,6 +51,8 @@ struct vhost_user_socket {
>> uint64_t supported_features;
>> uint64_t features;
>>
>> + uint64_t protocol_features;
>> +
>> /*
>> * Device id to identify a specific backend device.
>> * It's set to -1 for the default software implementation.
>> @@ -731,7 +733,7 @@ rte_vhost_driver_get_protocol_features(const char *path,
>> did = vsocket->vdpa_dev_id;
>> vdpa_dev = rte_vdpa_get_device(did);
>> if (!vdpa_dev || !vdpa_dev->ops->get_protocol_features) {
>> - *protocol_features = VHOST_USER_PROTOCOL_FEATURES;
>> + *protocol_features = vsocket->protocol_features;
>> goto unlock_exit;
>> }
>>
>> @@ -744,7 +746,7 @@ rte_vhost_driver_get_protocol_features(const char *path,
>> goto unlock_exit;
>> }
>>
>> - *protocol_features = VHOST_USER_PROTOCOL_FEATURES
>> + *protocol_features = vsocket->protocol_features
>> & vdpa_protocol_features;
>>
>> unlock_exit:
>> @@ -863,6 +865,7 @@ rte_vhost_driver_register(const char *path, uint64_t flags)
>> vsocket->use_builtin_virtio_net = true;
>> vsocket->supported_features = VIRTIO_NET_SUPPORTED_FEATURES;
>> vsocket->features = VIRTIO_NET_SUPPORTED_FEATURES;
>> + vsocket->protocol_features = VHOST_USER_PROTOCOL_FEATURES;
>>
>> /* Dequeue zero copy can't assure descriptors returned in order */
>> if (vsocket->dequeue_zero_copy) {
>> @@ -875,6 +878,18 @@ rte_vhost_driver_register(const char *path, uint64_t flags)
>> vsocket->features &= ~(1ULL << VIRTIO_F_IOMMU_PLATFORM);
>> }
>>
>> + if (!(flags & RTE_VHOST_USER_POSTCOPY_SUPPORT)) {
>> + vsocket->protocol_features &=
>> + ~(1ULL << VHOST_USER_PROTOCOL_F_PAGEFAULT);
>> + } else {
>> +#ifndef RTE_LIBRTE_VHOST_POSTCOPY
>> + RTE_LOG(ERR, VHOST_CONFIG,
>> + "Postcopy requested but not compiled\n");
>> + ret = -1;
>> + goto out_mutex;
>> +#endif
>> + }
>> +
>> if ((flags & RTE_VHOST_USER_CLIENT) != 0) {
>> vsocket->reconnect = !(flags & RTE_VHOST_USER_NO_RECONNECT);
>> if (vsocket->reconnect && reconn_tid == 0) {
>>
>
>
next prev parent reply other threads:[~2018-10-08 16:22 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 8:13 [dpdk-stable] [PATCH v3 00/19] vhost: add postcopy live-migration support Maxime Coquelin
2018-10-04 8:13 ` [dpdk-stable] [PATCH v3 01/19] vhost: fix messages error checks Maxime Coquelin
2018-10-04 14:48 ` Ilya Maximets
2018-10-04 8:13 ` [dpdk-stable] [PATCH v3 02/19] vhost: fix return code of messages requiring replies Maxime Coquelin
2018-10-04 14:48 ` Ilya Maximets
2018-10-04 8:13 ` [dpdk-stable] [PATCH v3 03/19] vhost: clarify reply-ack in case a reply was already sent Maxime Coquelin
2018-10-04 14:50 ` Ilya Maximets
2018-10-04 8:13 ` [dpdk-stable] [PATCH v3 04/19] vhost: fix payload size of reply Maxime Coquelin
2018-10-04 14:49 ` Ilya Maximets
2018-10-04 8:13 ` [dpdk-stable] [PATCH v3 05/19] vhost: fix error handling when mem table gets updated Maxime Coquelin
2018-10-04 14:59 ` Ilya Maximets
2018-10-04 15:06 ` Maxime Coquelin
2018-10-04 15:11 ` Ilya Maximets
2018-10-04 8:13 ` [dpdk-stable] [PATCH v3 06/19] vhost: define postcopy protocol flag Maxime Coquelin
2018-10-04 14:59 ` Ilya Maximets
2018-10-04 8:13 ` [dpdk-stable] [PATCH v3 07/19] vhost: add number of fds to vhost-user messages and use it Maxime Coquelin
2018-10-05 9:56 ` Ilya Maximets
2018-10-08 12:56 ` Maxime Coquelin
2018-10-04 8:13 ` [dpdk-stable] [PATCH v3 08/19] vhost: pass socket fd to message handling callbacks Maxime Coquelin
2018-10-04 8:13 ` [dpdk-stable] [PATCH v3 09/19] vhost: enable fds passing when sending vhost-user messages Maxime Coquelin
2018-10-04 8:13 ` [dpdk-stable] [PATCH v3 10/19] vhost: add config flag for postcopy feature Maxime Coquelin
2018-10-05 11:55 ` Ilya Maximets
2018-10-04 8:13 ` [dpdk-stable] [PATCH v3 11/19] vhost: introduce postcopy's advise message Maxime Coquelin
2018-10-05 11:58 ` Ilya Maximets
2018-10-05 13:36 ` Maxime Coquelin
2018-10-04 8:13 ` [dpdk-stable] [PATCH v3 12/19] vhost: add support for postcopy's listen message Maxime Coquelin
2018-10-05 12:02 ` Ilya Maximets
2018-10-04 8:13 ` [dpdk-stable] [PATCH v3 13/19] vhost: register new regions with userfaultfd Maxime Coquelin
2018-10-05 12:34 ` Ilya Maximets
2018-10-08 13:03 ` Maxime Coquelin
2018-10-04 8:13 ` [dpdk-stable] [PATCH v3 14/19] vhost: avoid useless VhostUserMemory copy Maxime Coquelin
2018-10-05 12:37 ` Ilya Maximets
2018-10-04 8:13 ` [dpdk-stable] [PATCH v3 15/19] vhost: send userfault range addresses back to qemu Maxime Coquelin
2018-10-04 8:14 ` [dpdk-stable] [PATCH v3 16/19] vhost: add support to postcopy's end request Maxime Coquelin
2018-10-04 8:14 ` [dpdk-stable] [PATCH v3 17/19] vhost: enable postcopy protocol feature Maxime Coquelin
2018-10-04 8:14 ` [dpdk-stable] [PATCH v3 18/19] vhost: add flag to enable postcopy live-migration Maxime Coquelin
2018-10-05 14:24 ` Ilya Maximets
2018-10-08 16:25 ` Ilya Maximets [this message]
2018-10-08 16:54 ` Maxime Coquelin
2018-10-04 8:14 ` [dpdk-stable] [PATCH v3 19/19] net/vhost: add parameter to enable postcopy support Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20181008162251eucas1p29fb65b432d9b202d635f37240baa2630~brrCTgLSL0635706357eucas1p2Z@eucas1p2.samsung.com' \
--to=i.maximets@samsung.com \
--cc=alejandro.lucero@netronome.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dgilbert@redhat.com \
--cc=jfreimann@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=nicknickolaev@gmail.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).