From: Tiwei Bie <tiwei.bie@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev@dpdk.org, zhihong.wang@intel.com, jfreimann@redhat.com,
nicknickolaev@gmail.com, i.maximets@samsung.com,
bruce.richardson@intel.com, alejandro.lucero@netronome.com,
dgilbert@redhat.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v4 03/19] vhost: clarify reply-ack in case a reply was already sent
Date: Tue, 9 Oct 2018 16:12:17 +0800 [thread overview]
Message-ID: <20181009081217.GB24789@debian> (raw)
In-Reply-To: <20181008152557.14275-4-maxime.coquelin@redhat.com>
On Mon, Oct 08, 2018 at 05:25:41PM +0200, Maxime Coquelin wrote:
> For messages that require a reply, a second ack should not be
> sent when reply-ack protocol feature is negotiated, even if
> the corresponding flag is set in the message.
>
> The code is compliant with the spec but it isn't clear it is,
> so this patch adds a comment to make it explicit.
>
> Suggested-by: Ilya Maximets <i.maximets@samsung.com>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> Acked-by: Ilya Maximets <i.maximets@samsung.com>
> ---
> lib/librte_vhost/vhost_user.c | 5 +++++
> 1 file changed, 5 insertions(+)
Reviewed-by: Tiwei Bie <tiwei.bie@intel.com>
next prev parent reply other threads:[~2018-10-09 8:13 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 15:25 [dpdk-stable] [PATCH v4 00/19] vhost: add postcopy live-migration support Maxime Coquelin
2018-10-08 15:25 ` [dpdk-stable] [PATCH v4 01/19] vhost: fix messages error checks Maxime Coquelin
2018-10-09 8:03 ` Tiwei Bie
2018-10-09 12:20 ` Maxime Coquelin
2018-10-09 12:54 ` Tiwei Bie
2018-10-09 17:53 ` Maxime Coquelin
2018-10-08 15:25 ` [dpdk-stable] [PATCH v4 02/19] vhost: fix return code of messages requiring replies Maxime Coquelin
2018-10-09 8:05 ` Tiwei Bie
2018-10-08 15:25 ` [dpdk-stable] [PATCH v4 03/19] vhost: clarify reply-ack in case a reply was already sent Maxime Coquelin
2018-10-09 8:12 ` Tiwei Bie [this message]
2018-10-08 15:25 ` [dpdk-stable] [PATCH v4 04/19] vhost: fix payload size of reply Maxime Coquelin
2018-10-09 10:21 ` Tiwei Bie
2018-10-09 10:30 ` Maxime Coquelin
2018-10-09 10:34 ` [dpdk-stable] [dpdk-dev] " Maxime Coquelin
2018-10-09 11:02 ` Tiwei Bie
2018-10-08 15:25 ` [dpdk-stable] [PATCH v4 05/19] vhost: fix error handling when mem table gets updated Maxime Coquelin
2018-10-09 11:35 ` Tiwei Bie
2018-10-09 11:47 ` Maxime Coquelin
2018-10-08 15:25 ` [dpdk-stable] [PATCH v4 06/19] vhost: define postcopy protocol flag Maxime Coquelin
2018-10-09 11:41 ` Tiwei Bie
2018-10-09 11:47 ` Maxime Coquelin
2018-10-08 15:25 ` [dpdk-stable] [PATCH v4 07/19] vhost: add number of fds to vhost-user messages and use it Maxime Coquelin
2018-10-08 15:25 ` [dpdk-stable] [PATCH v4 08/19] vhost: pass socket fd to message handling callbacks Maxime Coquelin
2018-10-08 15:25 ` [dpdk-stable] [PATCH v4 09/19] vhost: enable fds passing when sending vhost-user messages Maxime Coquelin
2018-10-08 15:25 ` [dpdk-stable] [PATCH v4 10/19] vhost: add config flag for postcopy feature Maxime Coquelin
2018-10-08 15:25 ` [dpdk-stable] [PATCH v4 11/19] vhost: introduce postcopy's advise message Maxime Coquelin
2018-10-08 16:22 ` Ilya Maximets
2018-10-09 7:59 ` Maxime Coquelin
2018-10-08 15:25 ` [dpdk-stable] [PATCH v4 12/19] vhost: add support for postcopy's listen message Maxime Coquelin
2018-10-08 15:25 ` [dpdk-stable] [PATCH v4 13/19] vhost: register new regions with userfaultfd Maxime Coquelin
2018-10-08 15:25 ` [dpdk-stable] [PATCH v4 14/19] vhost: avoid useless VhostUserMemory copy Maxime Coquelin
2018-10-08 15:25 ` [dpdk-stable] [PATCH v4 15/19] vhost: send userfault range addresses back to qemu Maxime Coquelin
2018-10-08 15:25 ` [dpdk-stable] [PATCH v4 16/19] vhost: add support to postcopy's end request Maxime Coquelin
2018-10-08 15:25 ` [dpdk-stable] [PATCH v4 17/19] vhost: enable postcopy protocol feature Maxime Coquelin
2018-10-08 15:25 ` [dpdk-stable] [PATCH v4 18/19] vhost: add flag to enable postcopy live-migration Maxime Coquelin
2018-10-08 15:25 ` [dpdk-stable] [PATCH v4 19/19] net/vhost: add parameter to enable postcopy support Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181009081217.GB24789@debian \
--to=tiwei.bie@intel.com \
--cc=alejandro.lucero@netronome.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dgilbert@redhat.com \
--cc=i.maximets@samsung.com \
--cc=jfreimann@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=nicknickolaev@gmail.com \
--cc=stable@dpdk.org \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).