From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id 9E2C21E2F for ; Mon, 29 Oct 2018 13:54:02 +0100 (CET) Received: by mail-wr1-f68.google.com with SMTP id n5-v6so8526791wrw.12 for ; Mon, 29 Oct 2018 05:54:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fCz8vclhBj5W2tDzfQItSdy19Wng8Bcj/XCE8TEU2D8=; b=LJmJ+JJTmwjly9Wr7KakQARtONLzKpqGftBLe2IOaSh4NaTm6G+3e4N0o7SzGBos/J q2O+mXiLuKGh+31FApxf7hIuIsxU9BTbYjZX/q5ORo3ckaFypRVW7BTXs6FN/mVFk4Bq Wbrgfu9v2JHCSSHZZ7Cc4vi6BOw2m34O01HV60DYuyRA8U+/YVA8U7P60FTOXJVIcYAk Q/LumWgJ3LytJLNbPEN5YZJ1TuAPA2wLIeXL7t8RmvzUJMPsjNXokcw2k/W4J5sHharS Cv5qve9RHKgrmUfbJIj9dCE1elb5H25QftSvGRa0i1yfRedCeEEjKNuoy4gpMhv3IgUI poiA== X-Gm-Message-State: AGRZ1gK1rprZJVUnsHRA9fMyIIdAWd57BCmpwjWvoNr7pRYFtUTmB5Ie ndNe0gD49e03wSgDgYY8EOo= X-Google-Smtp-Source: AJdET5dAx2axHJhlTRlLT8Lxuiafw17tRGzHb2ZSnjURMe0MeLVwUjaNHt9CN8DeiqqI1m2AvUEJfg== X-Received: by 2002:a5d:51cb:: with SMTP id n11-v6mr3480823wrv.121.1540817642145; Mon, 29 Oct 2018 05:54:02 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id j72-v6sm7026507wrj.7.2018.10.29.05.54.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Oct 2018 05:54:01 -0700 (PDT) From: Luca Boccassi To: Yipeng Wang Cc: Bruce Richardson , dpdk stable Date: Mon, 29 Oct 2018 12:53:19 +0000 Message-Id: <20181029125329.17729-10-bluca@debian.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181029125329.17729-1-bluca@debian.org> References: <20181015115144.27626-1-bluca@debian.org> <20181029125329.17729-1-bluca@debian.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'hash: remove unnecessary pause' has been queued to LTS release 16.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Oct 2018 12:54:02 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/31/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Luca Boccassi --- >>From 4992ddc0bf16e7d290542bc8258b07b844707e69 Mon Sep 17 00:00:00 2001 From: Yipeng Wang Date: Fri, 26 Oct 2018 02:53:41 -0700 Subject: [PATCH] hash: remove unnecessary pause [ upstream commit 2d28bb5ddd0fb7c3bed44f3f3fbc7a7bc449ea7a ] There is a rte_pause in hash table reset function. Since the loop is not a polling loop on shared data structure, the rte_pause is not needed. Fixes: b26473ff8f4a ("hash: add reset function") Signed-off-by: Yipeng Wang Acked-by: Bruce Richardson --- lib/librte_hash/rte_cuckoo_hash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_hash/rte_cuckoo_hash.c b/lib/librte_hash/rte_cuckoo_hash.c index 5aaa6ccd0..2414c7f2d 100644 --- a/lib/librte_hash/rte_cuckoo_hash.c +++ b/lib/librte_hash/rte_cuckoo_hash.c @@ -407,7 +407,7 @@ rte_hash_reset(struct rte_hash *h) /* clear the free ring */ while (rte_ring_dequeue(h->free_slots, &ptr) == 0) - rte_pause(); + continue; /* Repopulate the free slots ring. Entry zero is reserved for key misses */ if (h->hw_trans_mem_support) -- 2.19.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-10-29 12:48:14.660503844 +0000 +++ 0010-hash-remove-unnecessary-pause.patch 2018-10-29 12:48:14.446417982 +0000 @@ -1,50 +1,35 @@ -From 2d28bb5ddd0fb7c3bed44f3f3fbc7a7bc449ea7a Mon Sep 17 00:00:00 2001 +From 4992ddc0bf16e7d290542bc8258b07b844707e69 Mon Sep 17 00:00:00 2001 From: Yipeng Wang Date: Fri, 26 Oct 2018 02:53:41 -0700 Subject: [PATCH] hash: remove unnecessary pause +[ upstream commit 2d28bb5ddd0fb7c3bed44f3f3fbc7a7bc449ea7a ] + There is a rte_pause in hash table reset function. Since the loop is not a polling loop on shared data structure, the rte_pause is not needed. Fixes: b26473ff8f4a ("hash: add reset function") -Cc: stable@dpdk.org Signed-off-by: Yipeng Wang Acked-by: Bruce Richardson --- - lib/librte_hash/rte_cuckoo_hash.c | 5 ++--- - 1 file changed, 2 insertions(+), 3 deletions(-) + lib/librte_hash/rte_cuckoo_hash.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_hash/rte_cuckoo_hash.c b/lib/librte_hash/rte_cuckoo_hash.c -index 0648a2294..5ddcccd87 100644 +index 5aaa6ccd0..2414c7f2d 100644 --- a/lib/librte_hash/rte_cuckoo_hash.c +++ b/lib/librte_hash/rte_cuckoo_hash.c -@@ -27,7 +27,6 @@ - #include - #include - #include --#include - - #include "rte_hash.h" - #include "rte_cuckoo_hash.h" -@@ -574,14 +573,14 @@ rte_hash_reset(struct rte_hash *h) +@@ -407,7 +407,7 @@ rte_hash_reset(struct rte_hash *h) /* clear the free ring */ while (rte_ring_dequeue(h->free_slots, &ptr) == 0) - rte_pause(); + continue; - /* clear free extendable bucket ring and memory */ - if (h->ext_table_support) { - memset(h->buckets_ext, 0, h->num_buckets * - sizeof(struct rte_hash_bucket)); - while (rte_ring_dequeue(h->free_ext_bkts, &ptr) == 0) -- rte_pause(); -+ continue; - } - /* Repopulate the free slots ring. Entry zero is reserved for key misses */ + if (h->hw_trans_mem_support) -- 2.19.1