From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id 039FA2965 for ; Mon, 29 Oct 2018 13:54:06 +0100 (CET) Received: by mail-wm1-f65.google.com with SMTP id s10-v6so8101194wmc.5 for ; Mon, 29 Oct 2018 05:54:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9KMlGlrSHRw4pOT8amYvq7ZjYTxBfRbBdykCWu7c+EU=; b=ujavqZs+UkUkxayiSkqLuI6GgErMjt7PCz1aV/TL4f0BGXvXYR1dyKE69G7wzZu82v M7/WpW3JB1YZKJMhIw8WG40NQ5Bt1xUMqi3bvj9dMaTL/OodndkMOUo5vqMOcHVyOFnN UkiAJQOo5YJeNjtHWuPQ6JIWjxLFdz4ddHWphZGaR1VUcYYbA1HVREXfEGzGNi1dUTX2 LLJaamBW/BWCoFsJEM9N1B+B68lyZSLC2puDoxGPPGoXtmpL651iqZCqjtwQtY1zg4B5 bbR+JOIIXpXa/8+p/XeLR41Nume3OEFN+HGXs19sBpLbChVZLtPeyioxlfQYx/PeFbU7 Zu1A== X-Gm-Message-State: AGRZ1gLSdzWzwOwWp3WikyDWpPIrVM4X6kxECKGGXl2CnCdMtHWUifRw 4Y+8p5PJPk7ZAZGGg6nfi+Y= X-Google-Smtp-Source: AJdET5dnyUcIZv3Ki70LPM64s4TJDXLmXLQFUA+TgQwcZG+Q7iJkc8bIGypYc2qDVlCZlP7hJlG/7A== X-Received: by 2002:a1c:f312:: with SMTP id q18-v6mr13457362wmq.14.1540817645660; Mon, 29 Oct 2018 05:54:05 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id 21-v6sm682036wmv.5.2018.10.29.05.54.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 29 Oct 2018 05:54:04 -0700 (PDT) From: Luca Boccassi To: Huaibin Wang Cc: Laurent Hardy , Qi Zhang , dpdk stable Date: Mon, 29 Oct 2018 12:53:21 +0000 Message-Id: <20181029125329.17729-12-bluca@debian.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181029125329.17729-1-bluca@debian.org> References: <20181015115144.27626-1-bluca@debian.org> <20181029125329.17729-1-bluca@debian.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/i40e: keep promiscuous on if allmulticast is enabled' has been queued to LTS release 16.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Oct 2018 12:54:06 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/31/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Luca Boccassi --- >>From 89e87d547ca6760be0349ad569003f467360c1d8 Mon Sep 17 00:00:00 2001 From: Huaibin Wang Date: Fri, 19 Oct 2018 11:45:21 +0200 Subject: [PATCH] net/i40e: keep promiscuous on if allmulticast is enabled [ upstream commit 815037b92b3437754183fb256a967a7e82d3820a ] Promisc should not be disabled if the all multicast mode is enabled. Patch keeps the promiscuous on if all multicast mode is on, this behavior is also consistent with the implementation done on ixgbe pmd. Signed-off-by: Huaibin Wang Signed-off-by: Laurent Hardy Acked-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 2ce0e7025..f98be9429 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -2085,6 +2085,10 @@ i40e_dev_promiscuous_disable(struct rte_eth_dev *dev) if (status != I40E_SUCCESS) PMD_DRV_LOG(ERR, "Failed to disable unicast promiscuous"); + /* must remain in all_multicast mode */ + if (dev->data->all_multicast == 1) + return; + status = i40e_aq_set_vsi_multicast_promiscuous(hw, vsi->seid, false, NULL); if (status != I40E_SUCCESS) -- 2.19.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-10-29 12:48:14.695908377 +0000 +++ 0012-net-i40e-keep-promiscuous-on-if-allmulticast-is-enab.patch 2018-10-29 12:48:14.454417982 +0000 @@ -1,15 +1,15 @@ -From 815037b92b3437754183fb256a967a7e82d3820a Mon Sep 17 00:00:00 2001 +From 89e87d547ca6760be0349ad569003f467360c1d8 Mon Sep 17 00:00:00 2001 From: Huaibin Wang Date: Fri, 19 Oct 2018 11:45:21 +0200 Subject: [PATCH] net/i40e: keep promiscuous on if allmulticast is enabled +[ upstream commit 815037b92b3437754183fb256a967a7e82d3820a ] + Promisc should not be disabled if the all multicast mode is enabled. Patch keeps the promiscuous on if all multicast mode is on, this behavior is also consistent with the implementation done on ixgbe pmd. -Cc: stable@dpdk.org - Signed-off-by: Huaibin Wang Signed-off-by: Laurent Hardy Acked-by: Qi Zhang @@ -18,10 +18,10 @@ 1 file changed, 4 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c -index f7a685c8c..6c503debc 100644 +index 2ce0e7025..f98be9429 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c -@@ -2587,6 +2587,10 @@ i40e_dev_promiscuous_disable(struct rte_eth_dev *dev) +@@ -2085,6 +2085,10 @@ i40e_dev_promiscuous_disable(struct rte_eth_dev *dev) if (status != I40E_SUCCESS) PMD_DRV_LOG(ERR, "Failed to disable unicast promiscuous");