From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by dpdk.org (Postfix) with ESMTP id A7A553237 for ; Mon, 19 Nov 2018 13:26:07 +0100 (CET) Received: by mail-wm1-f43.google.com with SMTP id w7-v6so5115937wmc.1 for ; Mon, 19 Nov 2018 04:26:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Y93DHCgoOT1hQ7zgSLPPLJBFzPTX8oGS7jOYZrI9HAc=; b=YOBsNZf83vS+Q1Dgc4RVf3UUuEMgC4hUZQcuXFctGJwhBEL9NQLP/HTFBLBfYZD2AH 6Qf+v/j4mJi5ztrcE15jaq35w3lQCggF97SF/iLS+ha1vrwReTpuyh8xugjb1bNGETAW WiuO+toH6G8YkTY6qdqMPQcsErY81CBkzAuef6hykdOAQzxUjmY5lcbOC7POgXBoJt4X q3fKLF30EdfvaCzl7DL6EBC6l/BG/7j0OVnyf72deOr+2KqA5HaodMz3nTjVOWLIP+d+ g9taPZUdnHsvS7Awcn4y8qWpSKWakjhyr5QK0hPgO0/3aghrQFmOQoaWjcdvVEJ3lEjR WOqg== X-Gm-Message-State: AGRZ1gIel6/4tOWbXk1YrhpWBhKVUMw7XxI8IeawlDRq/AQeNN/sz+bZ 1xJoiE6PmeyqBVts6foqvKXsp5/M X-Google-Smtp-Source: AFSGD/UPHilxw0SaKjlxcVoBWyHgLvC0mu7MSxVbLvvkDSZWkQKg1H7Vv1+w8toP6lwDS7/wjcNOUQ== X-Received: by 2002:a1c:85c5:: with SMTP id h188-v6mr6840914wmd.59.1542630367261; Mon, 19 Nov 2018 04:26:07 -0800 (PST) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id t187-v6sm25548029wmt.45.2018.11.19.04.26.06 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 19 Nov 2018 04:26:06 -0800 (PST) From: Luca Boccassi To: Ferruh Yigit Cc: dpdk stable Date: Mon, 19 Nov 2018 12:25:32 +0000 Message-Id: <20181119122538.14207-15-bluca@debian.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181119122538.14207-1-bluca@debian.org> References: <20181108180111.25873-1-bluca@debian.org> <20181119122538.14207-1-bluca@debian.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'test/reorder: fix out of bound access' has been queued to LTS release 16.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Nov 2018 12:26:07 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/21/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Luca Boccassi --- >>From ab8f3afb3afe3edc6b253a23fda956144f362b2c Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Tue, 13 Nov 2018 23:31:37 +0000 Subject: [PATCH] test/reorder: fix out of bound access [ upstream commit 1af9bc9c60291e43aa26f8ee92371c8b04a9b55f ] The value of array index 'i' is out of bound because of the previous loop it has been used. Assuming intention is using '0' since the check before free is robufs[0] check, fixing according. Fixes: ecd867faa860 ("test/reorder: fix freeing mbuf twice") Signed-off-by: Ferruh Yigit --- app/test/test_reorder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_reorder.c b/app/test/test_reorder.c index add455111..d7dab3210 100644 --- a/app/test/test_reorder.c +++ b/app/test/test_reorder.c @@ -300,7 +300,7 @@ test_reorder_drain(void) goto exit; } if (robufs[0] != NULL) - rte_pktmbuf_free(robufs[i]); + rte_pktmbuf_free(robufs[0]); /* Insert more packets * RB[] = {NULL, NULL, NULL, NULL} -- 2.19.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-19 12:15:18.419511907 +0000 +++ 0015-test-reorder-fix-out-of-bound-access.patch 2018-11-19 12:15:18.107611433 +0000 @@ -1,8 +1,10 @@ -From 1af9bc9c60291e43aa26f8ee92371c8b04a9b55f Mon Sep 17 00:00:00 2001 +From ab8f3afb3afe3edc6b253a23fda956144f362b2c Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Tue, 13 Nov 2018 23:31:37 +0000 Subject: [PATCH] test/reorder: fix out of bound access +[ upstream commit 1af9bc9c60291e43aa26f8ee92371c8b04a9b55f ] + The value of array index 'i' is out of bound because of the previous loop it has been used. @@ -10,18 +12,17 @@ check, fixing according. Fixes: ecd867faa860 ("test/reorder: fix freeing mbuf twice") -Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit --- - test/test/test_reorder.c | 2 +- + app/test/test_reorder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -diff --git a/test/test/test_reorder.c b/test/test/test_reorder.c -index ccee4d086..58fa9c71b 100644 ---- a/test/test/test_reorder.c -+++ b/test/test/test_reorder.c -@@ -269,7 +269,7 @@ test_reorder_drain(void) +diff --git a/app/test/test_reorder.c b/app/test/test_reorder.c +index add455111..d7dab3210 100644 +--- a/app/test/test_reorder.c ++++ b/app/test/test_reorder.c +@@ -300,7 +300,7 @@ test_reorder_drain(void) goto exit; } if (robufs[0] != NULL)