From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 681A04F9C for ; Tue, 20 Nov 2018 20:14:34 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C7A11C04A5B1; Tue, 20 Nov 2018 19:14:33 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.36.118.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8527760141; Tue, 20 Nov 2018 19:14:32 +0000 (UTC) From: Kevin Traynor To: Jerin Jacob Cc: Vikas Aggarwal , Santosh Shukla , dpdk stable Date: Tue, 20 Nov 2018 19:12:00 +0000 Message-Id: <20181120191252.30277-10-ktraynor@redhat.com> In-Reply-To: <20181120191252.30277-1-ktraynor@redhat.com> References: <20181120191252.30277-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 20 Nov 2018 19:14:33 +0000 (UTC) Subject: [dpdk-stable] patch 'net/octeontx: fix packet corruption on Tx' has been queued to stable release 18.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2018 19:14:34 -0000 Hi, FYI, your patch has been queued to stable release 18.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/23/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Kevin Traynor --- >>From 84348f7544c863d670138449a0c285406829572c Mon Sep 17 00:00:00 2001 From: Jerin Jacob Date: Fri, 17 Aug 2018 20:00:22 +0530 Subject: [PATCH] net/octeontx: fix packet corruption on Tx [ upstream commit 9f92552eb997819d8af80b0634849070075cce2a ] LMTST does not guarantee packet content get synced with L2C when HW access the packet for transmitting. Adding coherent IO write barrier will make sure HW sees the correct packet if its modified. Fixes: 9e747589bd4c ("net/octeontx: add packet transmit burst function") Reported-by: Vikas Aggarwal Signed-off-by: Jerin Jacob Acked-by: Santosh Shukla --- drivers/net/octeontx/octeontx_rxtx.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/octeontx/octeontx_rxtx.c b/drivers/net/octeontx/octeontx_rxtx.c index a9149b4e1..f861313e6 100644 --- a/drivers/net/octeontx/octeontx_rxtx.c +++ b/drivers/net/octeontx/octeontx_rxtx.c @@ -64,4 +64,5 @@ octeontx_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) count = 0; + rte_cio_wmb(); while (count < nb_pkts) { res = __octeontx_xmit_pkts(dq->lmtline_va, dq->ioreg_va, -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-20 17:53:07.710126248 +0000 +++ 0010-net-octeontx-fix-packet-corruption-on-Tx.patch 2018-11-20 17:53:07.000000000 +0000 @@ -1,8 +1,10 @@ -From 9f92552eb997819d8af80b0634849070075cce2a Mon Sep 17 00:00:00 2001 +From 84348f7544c863d670138449a0c285406829572c Mon Sep 17 00:00:00 2001 From: Jerin Jacob Date: Fri, 17 Aug 2018 20:00:22 +0530 Subject: [PATCH] net/octeontx: fix packet corruption on Tx +[ upstream commit 9f92552eb997819d8af80b0634849070075cce2a ] + LMTST does not guarantee packet content get synced with L2C when HW access the packet for transmitting. @@ -10,7 +12,6 @@ packet if its modified. Fixes: 9e747589bd4c ("net/octeontx: add packet transmit burst function") -Cc: stable@dpdk.org Reported-by: Vikas Aggarwal Signed-off-by: Jerin Jacob