From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id C9FD8326C for ; Tue, 20 Nov 2018 20:14:35 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3CDAE3082AF3; Tue, 20 Nov 2018 19:14:35 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.36.118.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2229E601A7; Tue, 20 Nov 2018 19:14:33 +0000 (UTC) From: Kevin Traynor To: Ilya Maximets Cc: Ferruh Yigit , dpdk stable Date: Tue, 20 Nov 2018 19:12:01 +0000 Message-Id: <20181120191252.30277-11-ktraynor@redhat.com> In-Reply-To: <20181120191252.30277-1-ktraynor@redhat.com> References: <20181120191252.30277-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.45]); Tue, 20 Nov 2018 19:14:35 +0000 (UTC) Subject: [dpdk-stable] patch 'doc: fix style and syntax in flow API guide' has been queued to stable release 18.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2018 19:14:36 -0000 Hi, FYI, your patch has been queued to stable release 18.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/23/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Kevin Traynor --- >>From 36107fc61e8d157e0ff4f8a960e48bd96bedaf6a Mon Sep 17 00:00:00 2001 From: Ilya Maximets Date: Thu, 23 Aug 2018 11:05:54 +0300 Subject: [PATCH] doc: fix style and syntax in flow API guide [ upstream commit 1334586b669c1d27aec2bffd0b1ed9f542cd7d19 ] Fixes: 3e0ceb9f17ff ("doc: add basic howto for flow API") Signed-off-by: Ilya Maximets Acked-by: Ferruh Yigit --- doc/guides/howto/rte_flow.rst | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/doc/guides/howto/rte_flow.rst b/doc/guides/howto/rte_flow.rst index caa4e1afd..c71152161 100644 --- a/doc/guides/howto/rte_flow.rst +++ b/doc/guides/howto/rte_flow.rst @@ -33,5 +33,5 @@ Code /* create the attribute structure */ - struct rte_flow_attr attr = {.ingress = 1}; + struct rte_flow_attr attr = { .ingress = 1 }; struct rte_flow_item pattern[MAX_PATTERN_IN_FLOW]; struct rte_flow_action actions[MAX_ACTIONS_IN_FLOW]; @@ -63,6 +63,6 @@ Code /* validate and create the flow rule */ - if (!rte_flow_validate(port_id, &attr, pattern, actions, &error) - flow = rte_flow_create(port_id, &attr, pattern, actions, &error) + if (!rte_flow_validate(port_id, &attr, pattern, actions, &error)) + flow = rte_flow_create(port_id, &attr, pattern, actions, &error); Output @@ -121,5 +121,5 @@ clarity):: tpmd> flow create 0 ingress pattern eth / vlan / ipv4 dst spec 192.168.3.0 dst mask 255.255.255.0 / - end actions drop / end + end actions drop / end Code @@ -161,6 +161,6 @@ Code /* validate and create the flow rule */ - if (!rte_flow_validate(port_id, &attr, pattern, actions, &error) - flow = rte_flow_create(port_id, &attr, pattern, actions, &error) + if (!rte_flow_validate(port_id, &attr, pattern, actions, &error)) + flow = rte_flow_create(port_id, &attr, pattern, actions, &error); Output @@ -228,5 +228,5 @@ Code .. code-block:: c - struct rte_flow_attr attr = {.ingress = 1}; + struct rte_flow_attr attr = { .ingress = 1 }; struct rte_flow_item pattern[MAX_PATTERN_IN_FLOW]; struct rte_flow_action actions[MAX_ACTIONS_IN_FLOW]; @@ -251,10 +251,10 @@ Code /* create the queue action */ actions[0].type = RTE_FLOW_ACTION_TYPE_QUEUE; - actions[0].conf = &queue + actions[0].conf = &queue; actions[1].type = RTE_FLOW_ACTION_TYPE_END; /* validate and create the flow rule */ - if (!rte_flow_validate(port_id, &attr, pattern, actions, &error) - flow = rte_flow_create(port_id, &attr, pattern, actions, &error) + if (!rte_flow_validate(port_id, &attr, pattern, actions, &error)) + flow = rte_flow_create(port_id, &attr, pattern, actions, &error); Output -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-20 17:53:07.731985720 +0000 +++ 0011-doc-fix-style-and-syntax-in-flow-API-guide.patch 2018-11-20 17:53:07.000000000 +0000 @@ -1,10 +1,11 @@ -From 1334586b669c1d27aec2bffd0b1ed9f542cd7d19 Mon Sep 17 00:00:00 2001 +From 36107fc61e8d157e0ff4f8a960e48bd96bedaf6a Mon Sep 17 00:00:00 2001 From: Ilya Maximets Date: Thu, 23 Aug 2018 11:05:54 +0300 Subject: [PATCH] doc: fix style and syntax in flow API guide +[ upstream commit 1334586b669c1d27aec2bffd0b1ed9f542cd7d19 ] + Fixes: 3e0ceb9f17ff ("doc: add basic howto for flow API") -Cc: stable@dpdk.org Signed-off-by: Ilya Maximets Acked-by: Ferruh Yigit