From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id A32CA326C for ; Tue, 20 Nov 2018 20:14:45 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1611137E79; Tue, 20 Nov 2018 19:14:45 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.36.118.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 35A7560141; Tue, 20 Nov 2018 19:14:44 +0000 (UTC) From: Kevin Traynor To: Alejandro Lucero Cc: dpdk stable Date: Tue, 20 Nov 2018 19:12:08 +0000 Message-Id: <20181120191252.30277-18-ktraynor@redhat.com> In-Reply-To: <20181120191252.30277-1-ktraynor@redhat.com> References: <20181120191252.30277-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 20 Nov 2018 19:14:45 +0000 (UTC) Subject: [dpdk-stable] patch 'net/nfp: fix live MAC changes not supported' has been queued to stable release 18.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2018 19:14:45 -0000 Hi, FYI, your patch has been queued to stable release 18.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/23/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Kevin Traynor --- >>From 41173dafb949dd68e4bb590fd63a1612dac55242 Mon Sep 17 00:00:00 2001 From: Alejandro Lucero Date: Fri, 24 Aug 2018 15:25:36 +0100 Subject: [PATCH] net/nfp: fix live MAC changes not supported [ upstream commit 7712a1c660661005225c3f7ccbca09a6296e2751 ] Some NFP firmwares support live changes to the MAC address, but this is not always true and the firmware advertises it accordingly. This patch checks if firmware does not support live changes and sets RTE_ETH_DEV_NOLIVE_MAC_ADDR in that case. Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index 6e5e305f1..ee743e975 100644 --- a/drivers/net/nfp/nfp_net.c +++ b/drivers/net/nfp/nfp_net.c @@ -2887,4 +2887,7 @@ nfp_net_init(struct rte_eth_dev *eth_dev) ð_dev->data->mac_addrs[0]); + if (!(hw->cap & NFP_NET_CFG_CTRL_LIVE_ADDR)) + eth_dev->data->dev_flags |= RTE_ETH_DEV_NOLIVE_MAC_ADDR; + PMD_INIT_LOG(INFO, "port %d VendorID=0x%x DeviceID=0x%x " "mac=%02x:%02x:%02x:%02x:%02x:%02x", -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-20 17:53:07.902358310 +0000 +++ 0018-net-nfp-fix-live-MAC-changes-not-supported.patch 2018-11-20 17:53:07.000000000 +0000 @@ -1,16 +1,16 @@ -From 7712a1c660661005225c3f7ccbca09a6296e2751 Mon Sep 17 00:00:00 2001 +From 41173dafb949dd68e4bb590fd63a1612dac55242 Mon Sep 17 00:00:00 2001 From: Alejandro Lucero Date: Fri, 24 Aug 2018 15:25:36 +0100 Subject: [PATCH] net/nfp: fix live MAC changes not supported +[ upstream commit 7712a1c660661005225c3f7ccbca09a6296e2751 ] + Some NFP firmwares support live changes to the MAC address, but this is not always true and the firmware advertises it accordingly. This patch checks if firmware does not support live changes and sets RTE_ETH_DEV_NOLIVE_MAC_ADDR in that case. -Cc: stable@dpdk.org - Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 3 +++