From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 6DAF629C6 for ; Tue, 20 Nov 2018 20:13:12 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9267088314; Tue, 20 Nov 2018 19:13:11 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.36.118.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8040660141; Tue, 20 Nov 2018 19:13:10 +0000 (UTC) From: Kevin Traynor To: Jerin Jacob Cc: Ferruh Yigit , dpdk stable Date: Tue, 20 Nov 2018 19:11:52 +0000 Message-Id: <20181120191252.30277-2-ktraynor@redhat.com> In-Reply-To: <20181120191252.30277-1-ktraynor@redhat.com> References: <20181120191252.30277-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Tue, 20 Nov 2018 19:13:11 +0000 (UTC) Subject: [dpdk-stable] patch 'mk: disable OcteonTx for buggy compilers only on arm64' has been queued to stable release 18.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2018 19:13:12 -0000 Hi, FYI, your patch has been queued to stable release 18.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/23/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Kevin Traynor --- >>From d8fe9387cdb33b2cb5b27e4b14b3d3d87dd3a622 Mon Sep 17 00:00:00 2001 From: Jerin Jacob Date: Mon, 3 Sep 2018 15:01:10 +0530 Subject: [PATCH] mk: disable OcteonTx for buggy compilers only on arm64 [ upstream commit f3af3e44a444cdfe3fa7b3e2c042be351401eb23 ] Disable octeontx for gcc 4.8.5 as the compiler is emitting "internal compiler error" for aarch64. The GCC "internal compiler error" was observed only for arm64 architecture so disable the PMD only for arm64. Fixes: 4f760550a093 ("mk: disable OcteonTx for buggy compilers") Signed-off-by: Jerin Jacob Acked-by: Ferruh Yigit --- mk/toolchain/gcc/rte.toolchain-compat.mk | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk b/mk/toolchain/gcc/rte.toolchain-compat.mk index 1e4434fa9..44904295c 100644 --- a/mk/toolchain/gcc/rte.toolchain-compat.mk +++ b/mk/toolchain/gcc/rte.toolchain-compat.mk @@ -80,5 +80,6 @@ else endif - # Disable octeontx event PMD for gcc < 4.8.6 + # Disable octeontx event PMD for gcc < 4.8.6 & ARCH=arm64 + ifeq ($(CONFIG_RTE_ARCH), arm64) ifeq ($(shell test $(GCC_VERSION)$(GCC_PATCHLEVEL) -lt 486 && echo 1), 1) CONFIG_RTE_LIBRTE_PMD_OCTEONTX_SSOVF=d @@ -86,4 +87,5 @@ else CONFIG_RTE_LIBRTE_OCTEONTX_PMD=d endif + endif endif -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-20 17:53:07.529736432 +0000 +++ 0002-mk-disable-OcteonTx-for-buggy-compilers-only-on-arm6.patch 2018-11-20 17:53:07.000000000 +0000 @@ -1,15 +1,16 @@ -From f3af3e44a444cdfe3fa7b3e2c042be351401eb23 Mon Sep 17 00:00:00 2001 +From d8fe9387cdb33b2cb5b27e4b14b3d3d87dd3a622 Mon Sep 17 00:00:00 2001 From: Jerin Jacob Date: Mon, 3 Sep 2018 15:01:10 +0530 Subject: [PATCH] mk: disable OcteonTx for buggy compilers only on arm64 +[ upstream commit f3af3e44a444cdfe3fa7b3e2c042be351401eb23 ] + Disable octeontx for gcc 4.8.5 as the compiler is emitting "internal compiler error" for aarch64. The GCC "internal compiler error" was observed only for arm64 architecture so disable the PMD only for arm64. Fixes: 4f760550a093 ("mk: disable OcteonTx for buggy compilers") -Cc: stable@dpdk.org Signed-off-by: Jerin Jacob Acked-by: Ferruh Yigit