From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id A21B829C6 for ; Tue, 20 Nov 2018 20:14:51 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E46E887638; Tue, 20 Nov 2018 19:14:50 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.36.118.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id C8B3A604A4; Tue, 20 Nov 2018 19:14:49 +0000 (UTC) From: Kevin Traynor To: Shagun Agrawal Cc: Rahul Lakkireddy , dpdk stable Date: Tue, 20 Nov 2018 19:12:12 +0000 Message-Id: <20181120191252.30277-22-ktraynor@redhat.com> In-Reply-To: <20181120191252.30277-1-ktraynor@redhat.com> References: <20181120191252.30277-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 20 Nov 2018 19:14:51 +0000 (UTC) Subject: [dpdk-stable] patch 'net/cxgbe: fix memory access when parsing flow match items' has been queued to stable release 18.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2018 19:14:51 -0000 Hi, FYI, your patch has been queued to stable release 18.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/23/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Kevin Traynor --- >>From bee23facb8194fdbbfd08884cc1b0227a69a7ada Mon Sep 17 00:00:00 2001 From: Shagun Agrawal Date: Mon, 27 Aug 2018 18:23:31 +0530 Subject: [PATCH] net/cxgbe: fix memory access when parsing flow match items [ upstream commit 450f99ce7b34cb27f6727cea478292428b328a70 ] Coverity issue: 293096 Fixes: ee61f5113b17 ("net/cxgbe: parse and validate flows") Signed-off-by: Shagun Agrawal Signed-off-by: Rahul Lakkireddy --- drivers/net/cxgbe/cxgbe_flow.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/cxgbe/cxgbe_flow.c b/drivers/net/cxgbe/cxgbe_flow.c index 01c945f1b..038d479d6 100644 --- a/drivers/net/cxgbe/cxgbe_flow.c +++ b/drivers/net/cxgbe/cxgbe_flow.c @@ -455,8 +455,8 @@ cxgbe_rtef_parse_items(struct rte_flow *flow, for (i = items; i->type != RTE_FLOW_ITEM_TYPE_END; i++) { - struct chrte_fparse *idx = &flow->item_parser[i->type]; + struct chrte_fparse *idx; int ret; - if (i->type > ARRAY_SIZE(parseitem)) + if (i->type >= ARRAY_SIZE(parseitem)) return rte_flow_error_set(e, ENOTSUP, RTE_FLOW_ERROR_TYPE_ITEM, @@ -479,4 +479,5 @@ cxgbe_rtef_parse_items(struct rte_flow *flow, return ret; + idx = &flow->item_parser[i->type]; if (!idx || !idx->fptr) { return rte_flow_error_set(e, ENOTSUP, -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-20 17:53:07.999631124 +0000 +++ 0022-net-cxgbe-fix-memory-access-when-parsing-flow-match-.patch 2018-11-20 17:53:07.000000000 +0000 @@ -1,11 +1,12 @@ -From 450f99ce7b34cb27f6727cea478292428b328a70 Mon Sep 17 00:00:00 2001 +From bee23facb8194fdbbfd08884cc1b0227a69a7ada Mon Sep 17 00:00:00 2001 From: Shagun Agrawal Date: Mon, 27 Aug 2018 18:23:31 +0530 Subject: [PATCH] net/cxgbe: fix memory access when parsing flow match items +[ upstream commit 450f99ce7b34cb27f6727cea478292428b328a70 ] + Coverity issue: 293096 Fixes: ee61f5113b17 ("net/cxgbe: parse and validate flows") -Cc: stable@dpdk.org Signed-off-by: Shagun Agrawal Signed-off-by: Rahul Lakkireddy