From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 7A61429C6 for ; Tue, 20 Nov 2018 20:13:21 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CFE3B5F72C; Tue, 20 Nov 2018 19:13:20 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.36.118.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1E3E4600C3; Tue, 20 Nov 2018 19:13:18 +0000 (UTC) From: Kevin Traynor To: Honnappa Nagarahalli Cc: Raslan Darawsheh , Thomas F Herbert , Phil Yang , Gavin Hu , Jerin Jacob , dpdk stable Date: Tue, 20 Nov 2018 19:11:53 +0000 Message-Id: <20181120191252.30277-3-ktraynor@redhat.com> In-Reply-To: <20181120191252.30277-1-ktraynor@redhat.com> References: <20181120191252.30277-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 20 Nov 2018 19:13:20 +0000 (UTC) Subject: [dpdk-stable] patch 'build: enable ARM NEON flag when __aarch64__ defined' has been queued to stable release 18.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2018 19:13:21 -0000 Hi, FYI, your patch has been queued to stable release 18.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/23/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Kevin Traynor --- >>From c968864af7328c22849e40c2b7bac93359077804 Mon Sep 17 00:00:00 2001 From: Honnappa Nagarahalli Date: Sun, 2 Sep 2018 13:35:28 -0500 Subject: [PATCH] build: enable ARM NEON flag when __aarch64__ defined [ upstream commit 68acaa86ae639e3cdd94e419f546045a1b0ce6ca ] GCC version 4.8.5 does not pre-define __ARM_NEON. NEON is not optional for ArmV8. Hence NEON related code can be enabled when __aarch64__ is defined. Bugzilla ID: 82 Reported-by: Raslan Darawsheh Reported-by: Thomas F Herbert Signed-off-by: Honnappa Nagarahalli Reviewed-by: Phil Yang Reviewed-by: Gavin Hu Acked-by: Jerin Jacob --- config/arm/meson.build | 3 ++- mk/rte.cpuflags.mk | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/config/arm/meson.build b/config/arm/meson.build index 40dbc87f7..94cca490e 100644 --- a/config/arm/meson.build +++ b/config/arm/meson.build @@ -158,5 +158,6 @@ endif message(machine_args) -if cc.get_define('__ARM_NEON', args: machine_args) != '' +if (cc.get_define('__ARM_NEON', args: machine_args) != '' or + cc.get_define('__aarch64__', args: machine_args) != '') dpdk_conf.set('RTE_MACHINE_CPUFLAG_NEON', 1) compile_time_cpuflags += ['RTE_CPUFLAG_NEON'] diff --git a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk index 60713137d..43ed84155 100644 --- a/mk/rte.cpuflags.mk +++ b/mk/rte.cpuflags.mk @@ -90,5 +90,5 @@ endif # ARM flags -ifneq ($(filter $(AUTO_CPUFLAGS),__ARM_NEON),) +ifneq ($(filter __ARM_NEON __aarch64__,$(AUTO_CPUFLAGS)),) CPUFLAGS += NEON endif -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-20 17:53:07.551337834 +0000 +++ 0003-build-enable-ARM-NEON-flag-when-__aarch64__-defined.patch 2018-11-20 17:53:07.000000000 +0000 @@ -1,14 +1,15 @@ -From 68acaa86ae639e3cdd94e419f546045a1b0ce6ca Mon Sep 17 00:00:00 2001 +From c968864af7328c22849e40c2b7bac93359077804 Mon Sep 17 00:00:00 2001 From: Honnappa Nagarahalli Date: Sun, 2 Sep 2018 13:35:28 -0500 Subject: [PATCH] build: enable ARM NEON flag when __aarch64__ defined +[ upstream commit 68acaa86ae639e3cdd94e419f546045a1b0ce6ca ] + GCC version 4.8.5 does not pre-define __ARM_NEON. NEON is not optional for ArmV8. Hence NEON related code can be enabled when __aarch64__ is defined. Bugzilla ID: 82 -Cc: stable@dpdk.org Reported-by: Raslan Darawsheh Reported-by: Thomas F Herbert