From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 111E44F9C for ; Tue, 20 Nov 2018 20:15:12 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6ECB07F6C5; Tue, 20 Nov 2018 19:15:11 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.36.118.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1ECF6600C3; Tue, 20 Nov 2018 19:15:09 +0000 (UTC) From: Kevin Traynor To: Igor Romanov Cc: Andrew Rybchenko , Chas Williams , dpdk stable Date: Tue, 20 Nov 2018 19:12:23 +0000 Message-Id: <20181120191252.30277-33-ktraynor@redhat.com> In-Reply-To: <20181120191252.30277-1-ktraynor@redhat.com> References: <20181120191252.30277-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Tue, 20 Nov 2018 19:15:11 +0000 (UTC) Subject: [dpdk-stable] patch 'net/bonding: use evenly distributed default RSS RETA' has been queued to stable release 18.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2018 19:15:12 -0000 Hi, FYI, your patch has been queued to stable release 18.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/23/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Kevin Traynor --- >>From 90b53605f7c08a069ebb2da4b0fcabbeb81378b8 Mon Sep 17 00:00:00 2001 From: Igor Romanov Date: Wed, 29 Aug 2018 08:48:30 +0100 Subject: [PATCH] net/bonding: use evenly distributed default RSS RETA [ upstream commit 617d1ac2fd22e9a82d305c0607853f4ee0f7277b ] Default Redirection Table that is set in bonding driver is distributed evenly over all Rx queues only within every RETA group (the first RETA entries in every group are always start with zero). But in the most drivers, default RETA is distributed over all Rx queues without sequence resets in the beginning of a new group, which implies more balanced per-core load. Change the default RETA to be evenly distributed over all Rx queues considering the whole table. Fixes: 734ce47f71e0 ("bonding: support RSS dynamic configuration") Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko Acked-by: Chas Williams --- drivers/net/bonding/rte_eth_bond_pmd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index b84f32263..0f5ab09e3 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c @@ -3294,5 +3294,7 @@ bond_ethdev_configure(struct rte_eth_dev *dev) internals->reta_conf[i].mask = ~0LL; for (j = 0; j < RTE_RETA_GROUP_SIZE; j++) - internals->reta_conf[i].reta[j] = j % dev->data->nb_rx_queues; + internals->reta_conf[i].reta[j] = + (i * RTE_RETA_GROUP_SIZE + j) % + dev->data->nb_rx_queues; } } -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-20 17:53:08.260343828 +0000 +++ 0033-net-bonding-use-evenly-distributed-default-RSS-RETA.patch 2018-11-20 17:53:07.000000000 +0000 @@ -1,8 +1,10 @@ -From 617d1ac2fd22e9a82d305c0607853f4ee0f7277b Mon Sep 17 00:00:00 2001 +From 90b53605f7c08a069ebb2da4b0fcabbeb81378b8 Mon Sep 17 00:00:00 2001 From: Igor Romanov Date: Wed, 29 Aug 2018 08:48:30 +0100 Subject: [PATCH] net/bonding: use evenly distributed default RSS RETA +[ upstream commit 617d1ac2fd22e9a82d305c0607853f4ee0f7277b ] + Default Redirection Table that is set in bonding driver is distributed evenly over all Rx queues only within every RETA group (the first RETA entries in every group are always start with zero). But in the most @@ -14,7 +16,6 @@ considering the whole table. Fixes: 734ce47f71e0 ("bonding: support RSS dynamic configuration") -Cc: stable@dpdk.org Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko