From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 85E545688 for ; Tue, 20 Nov 2018 20:15:16 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CEBDA3084242; Tue, 20 Nov 2018 19:15:15 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.36.118.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 80FD9600C3; Tue, 20 Nov 2018 19:15:14 +0000 (UTC) From: Kevin Traynor To: Kamil Chalupnik Cc: Yuan Peng , Amr Mokhtar , dpdk stable Date: Tue, 20 Nov 2018 19:12:26 +0000 Message-Id: <20181120191252.30277-36-ktraynor@redhat.com> In-Reply-To: <20181120191252.30277-1-ktraynor@redhat.com> References: <20181120191252.30277-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Tue, 20 Nov 2018 19:15:15 +0000 (UTC) Subject: [dpdk-stable] patch 'app/bbdev: fix inputs mbuf creation' has been queued to stable release 18.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2018 19:15:17 -0000 Hi, FYI, your patch has been queued to stable release 18.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/23/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Kevin Traynor --- >>From e16283448e9e4557b95ca248eca666a5bf9d807f Mon Sep 17 00:00:00 2001 From: Kamil Chalupnik Date: Fri, 17 Aug 2018 09:19:19 +0200 Subject: [PATCH] app/bbdev: fix inputs mbuf creation [ upstream commit ad45893579346d999520e1aa91e7f74c51083d4b ] Omitting inputs and outputs mbuf creation for BaseBand Null Device as inputs and outputs data do not exist for Null Device Fixes: b2a4654f082b ("mempool: check for zero size creation") Signed-off-by: Kamil Chalupnik Tested-by: Yuan Peng Acked-by: Amr Mokhtar --- app/test-bbdev/test_bbdev_perf.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/app/test-bbdev/test_bbdev_perf.c b/app/test-bbdev/test_bbdev_perf.c index 6861edc47..fbe6cc91c 100644 --- a/app/test-bbdev/test_bbdev_perf.c +++ b/app/test-bbdev/test_bbdev_perf.c @@ -268,5 +268,5 @@ create_mbuf_pool(struct op_data_entries *entries, uint8_t dev_id, static int create_mempools(struct active_device *ad, int socket_id, - enum rte_bbdev_op_type op_type, uint16_t num_ops) + enum rte_bbdev_op_type org_op_type, uint16_t num_ops) { struct rte_mempool *mp; @@ -274,4 +274,5 @@ create_mempools(struct active_device *ad, int socket_id, char pool_name[RTE_MEMPOOL_NAMESIZE]; const char *op_type_str; + enum rte_bbdev_op_type op_type = org_op_type; struct op_data_entries *in = &test_vector.entries[DATA_INPUT]; @@ -290,4 +291,7 @@ create_mempools(struct active_device *ad, int socket_id, OPS_POOL_SIZE_MIN)); + if (org_op_type == RTE_BBDEV_OP_NONE) + op_type = RTE_BBDEV_OP_TURBO_ENC; + op_type_str = rte_bbdev_op_type_str(op_type); TEST_ASSERT_NOT_NULL(op_type_str, "Invalid op type: %u", op_type); @@ -304,4 +308,8 @@ create_mempools(struct active_device *ad, int socket_id, ad->ops_mempool = mp; + /* Do not create inputs and outputs mbufs for BaseBand Null Device */ + if (org_op_type == RTE_BBDEV_OP_NONE) + return TEST_SUCCESS; + /* Inputs */ mbuf_pool_size = optimal_mempool_size(ops_pool_size * in->nb_segments); @@ -1059,6 +1067,4 @@ run_test_case_on_device(test_case_function *test_case_func, uint8_t dev_id, socket_id = GET_SOCKET(info.socket_id); - if (op_type == RTE_BBDEV_OP_NONE) - op_type = RTE_BBDEV_OP_TURBO_ENC; f_ret = create_mempools(ad, socket_id, op_type, get_num_ops()); @@ -1067,4 +1073,6 @@ run_test_case_on_device(test_case_function *test_case_func, uint8_t dev_id, goto fail; } + if (op_type == RTE_BBDEV_OP_NONE) + op_type = RTE_BBDEV_OP_TURBO_ENC; f_ret = init_test_op_params(op_params, test_vector.op_type, -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-20 17:53:08.330243411 +0000 +++ 0036-app-bbdev-fix-inputs-mbuf-creation.patch 2018-11-20 17:53:07.000000000 +0000 @@ -1,13 +1,14 @@ -From ad45893579346d999520e1aa91e7f74c51083d4b Mon Sep 17 00:00:00 2001 +From e16283448e9e4557b95ca248eca666a5bf9d807f Mon Sep 17 00:00:00 2001 From: Kamil Chalupnik Date: Fri, 17 Aug 2018 09:19:19 +0200 Subject: [PATCH] app/bbdev: fix inputs mbuf creation +[ upstream commit ad45893579346d999520e1aa91e7f74c51083d4b ] + Omitting inputs and outputs mbuf creation for BaseBand Null Device as inputs and outputs data do not exist for Null Device Fixes: b2a4654f082b ("mempool: check for zero size creation") -Cc: stable@dpdk.org Signed-off-by: Kamil Chalupnik Tested-by: Yuan Peng