From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 4ABED5688 for ; Tue, 20 Nov 2018 20:15:47 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9AC113164694; Tue, 20 Nov 2018 19:15:46 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.36.118.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5D3A6600C3; Tue, 20 Nov 2018 19:15:45 +0000 (UTC) From: Kevin Traynor To: Phil Yang Cc: Gavin Hu , Bernard Iremonger , dpdk stable Date: Tue, 20 Nov 2018 19:12:36 +0000 Message-Id: <20181120191252.30277-46-ktraynor@redhat.com> In-Reply-To: <20181120191252.30277-1-ktraynor@redhat.com> References: <20181120191252.30277-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Tue, 20 Nov 2018 19:15:46 +0000 (UTC) Subject: [dpdk-stable] patch 'app/testpmd: optimize mbuf pool allocation' has been queued to stable release 18.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2018 19:15:47 -0000 Hi, FYI, your patch has been queued to stable release 18.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/23/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Kevin Traynor --- >>From a145f78370a0d0b0cf7fcc1d2e9233d13d90af92 Mon Sep 17 00:00:00 2001 From: Phil Yang Date: Wed, 12 Sep 2018 09:54:26 +0800 Subject: [PATCH] app/testpmd: optimize mbuf pool allocation [ upstream commit dbfb8ec7094c7115c6d620929de2aedfc9e440aa ] By default, testpmd will create membuf pool for all NUMA nodes and ignore EAL configuration. Count the number of available NUMA according to EAL core mask or core list configuration. Optimized by only creating membuf pool for those nodes. Fixes: c9cafcc82de8 ("app/testpmd: fix mempool creation by socket id") Signed-off-by: Phil Yang Acked-by: Gavin Hu Acked-by: Bernard Iremonger --- app/test-pmd/testpmd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index ee48db2a3..a56af2b5c 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -477,4 +477,6 @@ set_default_fwd_lcores_config(void) nb_lc = 0; for (i = 0; i < RTE_MAX_LCORE; i++) { + if (!rte_lcore_is_enabled(i)) + continue; sock_num = rte_lcore_to_socket_id(i); if (new_socket_id(sock_num)) { @@ -486,6 +488,4 @@ set_default_fwd_lcores_config(void) socket_ids[num_sockets++] = sock_num; } - if (!rte_lcore_is_enabled(i)) - continue; if (i == rte_get_master_lcore()) continue; -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-20 17:53:08.550855839 +0000 +++ 0046-app-testpmd-optimize-mbuf-pool-allocation.patch 2018-11-20 17:53:07.000000000 +0000 @@ -1,8 +1,10 @@ -From dbfb8ec7094c7115c6d620929de2aedfc9e440aa Mon Sep 17 00:00:00 2001 +From a145f78370a0d0b0cf7fcc1d2e9233d13d90af92 Mon Sep 17 00:00:00 2001 From: Phil Yang Date: Wed, 12 Sep 2018 09:54:26 +0800 Subject: [PATCH] app/testpmd: optimize mbuf pool allocation +[ upstream commit dbfb8ec7094c7115c6d620929de2aedfc9e440aa ] + By default, testpmd will create membuf pool for all NUMA nodes and ignore EAL configuration. @@ -11,7 +13,6 @@ nodes. Fixes: c9cafcc82de8 ("app/testpmd: fix mempool creation by socket id") -Cc: stable@dpdk.org Signed-off-by: Phil Yang Acked-by: Gavin Hu @@ -21,17 +22,17 @@ 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c -index 571ecb4ac..001f0e552 100644 +index ee48db2a3..a56af2b5c 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c -@@ -476,4 +476,6 @@ set_default_fwd_lcores_config(void) +@@ -477,4 +477,6 @@ set_default_fwd_lcores_config(void) nb_lc = 0; for (i = 0; i < RTE_MAX_LCORE; i++) { + if (!rte_lcore_is_enabled(i)) + continue; sock_num = rte_lcore_to_socket_id(i); if (new_socket_id(sock_num)) { -@@ -485,6 +487,4 @@ set_default_fwd_lcores_config(void) +@@ -486,6 +488,4 @@ set_default_fwd_lcores_config(void) socket_ids[num_sockets++] = sock_num; } - if (!rte_lcore_is_enabled(i))