From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id 3B5645F2C for ; Wed, 21 Nov 2018 15:09:27 +0100 (CET) Received: by mail-wm1-f66.google.com with SMTP id r63-v6so5672172wma.4 for ; Wed, 21 Nov 2018 06:09:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=4sL5JO9G3CW8o60riTRoFuyMaZ9DYP+NUb9JsJbQ5LA=; b=RkzdEZ5GDrmAj7Dg9m52U4jRWWE4UTwoSOBSg4IkjWThCVdI3dqly8wwPxlOooiG3Y s0h1p/vA7T5RU8Gvo+AMQz8CwUjCIrcpsn5P/e2kYPJyxs7v2KNL9AQX2JlMHI4ZTg1V Iwuu9Pw9zDbjqq7X7qgQwCkGMuzox9IWimSh6gQmMXXMyFyOE4C60beixDkXvSybImyu 3gi1KcIRXtjzhgeCeDORtu7pnQzQj/ZSLMozAh73Cn/K4tCEd7eAf28ojjS4wv4tNdyA ADVQNEz8Z5ELAmZhdQeqJw1R+PgJF4vEF0nfV28IfxjHLRO6e5t1hMpiuqUsdkKA7iI1 VUFw== X-Gm-Message-State: AGRZ1gKFR5QcLBy6WPah8xX5XAkWWRA2sZ0HA9ET62fyvpa1kgufgX7l DiYNtuD/e4JH5rdnZaX6CJjGFX+R X-Google-Smtp-Source: AFSGD/XdStKaWJOyjWI3e5Pl2UVL8v6jRNDPFTsJZq4fIvzB5yox+s43s5iW2/fqWc72f1KyYvcPHA== X-Received: by 2002:a7b:ce12:: with SMTP id m18mr6264830wmc.31.1542809366494; Wed, 21 Nov 2018 06:09:26 -0800 (PST) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id e14-v6sm27889365wrv.93.2018.11.21.06.09.25 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 21 Nov 2018 06:09:25 -0800 (PST) From: Luca Boccassi To: stable@dpdk.org Cc: zhihong.wang@intel.com Date: Wed, 21 Nov 2018 14:09:22 +0000 Message-Id: <20181121140922.32568-1-bluca@debian.org> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] [PATCH 16.11] config: make AVX and AVX512 configurable X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Nov 2018 14:09:27 -0000 From: Zhihong Wang [ backported from upstream commit 1838af33997daa7a2093e3aa7bf95a2d0c9578bf ] Making AVX and AVX512 configurable is useful for performance and power testing. The similar kernel patch at https://patchwork.kernel.org/patch/9618883/. AVX512 support like in rte_memcpy has been in DPDK since 16.04, but it's still unproven in rich use cases in hardware. Therefore it's marked as experimental for now, will enable it after enough field test and possible optimization. Signed-off-by: Zhihong Wang Reviewed-by: Zhiyong Yang Reviewed-by: Yuanhan Liu --- Fixes build failure with gcc 4.8 after the backport of: 8d07c82b239f ("mk: disable gcc AVX512F support") gcc: error: unrecognized command line option '-mno-avx512f' config/common_base | 8 ++++++++ mk/rte.cpuflags.mk | 6 ++++++ 2 files changed, 14 insertions(+) diff --git a/config/common_base b/config/common_base index 802fb5e32..4f4480682 100644 --- a/config/common_base +++ b/config/common_base @@ -98,6 +98,14 @@ CONFIG_RTE_EAL_VFIO=n CONFIG_RTE_MALLOC_DEBUG=n CONFIG_RTE_USE_LIBBSD=n +# +# Recognize/ignore the AVX/AVX512 CPU flags for performance/power testing. +# AVX512 is marked as experimental for now, will enable it after enough +# field test and possible optimization. +# +CONFIG_RTE_ENABLE_AVX=y +CONFIG_RTE_ENABLE_AVX512=n + # Default driver path (or "" to disable) CONFIG_RTE_EAL_PMD_PATH="" diff --git a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk index c7027a0fe..5cef63abd 100644 --- a/mk/rte.cpuflags.mk +++ b/mk/rte.cpuflags.mk @@ -70,8 +70,10 @@ CPUFLAGS += PCLMULQDQ endif ifneq ($(filter $(AUTO_CPUFLAGS),__AVX__),) +ifeq ($(CONFIG_RTE_ENABLE_AVX),y) CPUFLAGS += AVX endif +endif ifneq ($(filter $(AUTO_CPUFLAGS),__RDRND__),) CPUFLAGS += RDRAND @@ -86,10 +88,13 @@ CPUFLAGS += F16C endif ifneq ($(filter $(AUTO_CPUFLAGS),__AVX2__),) +ifeq ($(CONFIG_RTE_ENABLE_AVX),y) CPUFLAGS += AVX2 endif +endif ifneq ($(filter $(AUTO_CPUFLAGS),__AVX512F__),) +ifeq ($(CONFIG_RTE_ENABLE_AVX512),y) CPUFLAGS += AVX512F else # disable AVX512F support of gcc as a workaround for Bug 97 @@ -97,6 +102,7 @@ ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) MACHINE_CFLAGS += -mno-avx512f endif endif +endif # IBM Power CPU flags ifneq ($(filter $(AUTO_CPUFLAGS),__PPC64__),) -- 2.19.1