From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 355C06C9B for ; Wed, 21 Nov 2018 17:05:21 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 934707F6B0; Wed, 21 Nov 2018 16:05:20 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.36.118.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 80E75608E7; Wed, 21 Nov 2018 16:05:19 +0000 (UTC) From: Kevin Traynor To: Martin Harvey Cc: Andrew Rybchenko , dpdk stable Date: Wed, 21 Nov 2018 16:03:52 +0000 Message-Id: <20181121160440.9014-2-ktraynor@redhat.com> In-Reply-To: <20181121160440.9014-1-ktraynor@redhat.com> References: <20181121160440.9014-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 21 Nov 2018 16:05:20 +0000 (UTC) Subject: [dpdk-stable] patch 'net/sfc/base: fix invalid order of memset arguments' has been queued to stable release 18.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Nov 2018 16:05:21 -0000 Hi, FYI, your patch has been queued to stable release 18.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/26/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Kevin Traynor --- >>From 1c8adca23bf84e9312cfe74d25017090bd3293d0 Mon Sep 17 00:00:00 2001 From: Martin Harvey Date: Mon, 10 Sep 2018 10:33:01 +0100 Subject: [PATCH] net/sfc/base: fix invalid order of memset arguments [ upstream commit b1c25748ddf5dcec834eed4d1e97068ebe5e2409 ] Found by PreFAST. Fixes: 3f2f0189dd44 ("net/sfc/base: add signed image layout support") Signed-off-by: Martin Harvey Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/ef10_image.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/sfc/base/ef10_image.c b/drivers/net/sfc/base/ef10_image.c index 6fb7e4764..0d8898762 100644 --- a/drivers/net/sfc/base/ef10_image.c +++ b/drivers/net/sfc/base/ef10_image.c @@ -705,5 +705,5 @@ efx_build_signed_image_write_buffer( */ /* END CSTYLED */ - memset(bufferp, buffer_size, 0xFF); + memset(bufferp, 0xFF, buffer_size); EFX_STATIC_ASSERT(sizeof (chunk_hdr) == SIGNED_IMAGE_CHUNK_HDR_LEN); -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-21 15:59:13.676570117 +0000 +++ 0002-net-sfc-base-fix-invalid-order-of-memset-arguments.patch 2018-11-21 15:59:13.000000000 +0000 @@ -1,12 +1,13 @@ -From b1c25748ddf5dcec834eed4d1e97068ebe5e2409 Mon Sep 17 00:00:00 2001 +From 1c8adca23bf84e9312cfe74d25017090bd3293d0 Mon Sep 17 00:00:00 2001 From: Martin Harvey Date: Mon, 10 Sep 2018 10:33:01 +0100 Subject: [PATCH] net/sfc/base: fix invalid order of memset arguments +[ upstream commit b1c25748ddf5dcec834eed4d1e97068ebe5e2409 ] + Found by PreFAST. Fixes: 3f2f0189dd44 ("net/sfc/base: add signed image layout support") -Cc: stable@dpdk.org Signed-off-by: Martin Harvey Signed-off-by: Andrew Rybchenko