From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 6F4141B108 for ; Wed, 21 Nov 2018 17:06:17 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C91D830041E9; Wed, 21 Nov 2018 16:06:16 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.36.118.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id BBC21608E7; Wed, 21 Nov 2018 16:06:15 +0000 (UTC) From: Kevin Traynor To: Didier Pallard Cc: Konstantin Ananyev , dpdk stable Date: Wed, 21 Nov 2018 16:04:11 +0000 Message-Id: <20181121160440.9014-21-ktraynor@redhat.com> In-Reply-To: <20181121160440.9014-1-ktraynor@redhat.com> References: <20181121160440.9014-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Wed, 21 Nov 2018 16:06:16 +0000 (UTC) Subject: [dpdk-stable] patch 'net/fm10k: fix missing Tx multi-segs capability' has been queued to stable release 18.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Nov 2018 16:06:17 -0000 Hi, FYI, your patch has been queued to stable release 18.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/26/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Kevin Traynor --- >>From 317ec441647fe3d58c05e4746c2fc7b0499fdac4 Mon Sep 17 00:00:00 2001 From: Didier Pallard Date: Wed, 19 Sep 2018 17:04:07 +0200 Subject: [PATCH] net/fm10k: fix missing Tx multi-segs capability [ upstream commit 310e479b5f517ccabab6ba5a07a99378cf7ab5fd ] In former API, ETH_TXQ_FLAGS_NOMULTSEGS was merely a hint indicating that application will never send multisegmented packets, allowing pmd to choose different tx methods accordingly. In new API, DEV_TX_OFFLOAD_MULTI_SEGS became an offload capability that is advertised by pmds, some of them do not advertise it and expect to never receive fragmented packets (octeontx, axgbe) So an ethdev that supports multisegmented packets should properly advertise it. Problem was spotted and tested on e1000, should be also present in fm10k. Fixes: 30f3ce999e6a ("net/fm10k: convert to new Tx offloads API") Signed-off-by: Didier Pallard Acked-by: Konstantin Ananyev --- drivers/net/fm10k/fm10k_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c index 541a49b75..aebe8b5a5 100644 --- a/drivers/net/fm10k/fm10k_ethdev.c +++ b/drivers/net/fm10k/fm10k_ethdev.c @@ -1983,4 +1983,5 @@ static uint64_t fm10k_get_tx_port_offloads_capa(struct rte_eth_dev *dev) return (uint64_t)(DEV_TX_OFFLOAD_VLAN_INSERT | + DEV_TX_OFFLOAD_MULTI_SEGS | DEV_TX_OFFLOAD_IPV4_CKSUM | DEV_TX_OFFLOAD_UDP_CKSUM | -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-21 15:59:14.161495984 +0000 +++ 0021-net-fm10k-fix-missing-Tx-multi-segs-capability.patch 2018-11-21 15:59:13.000000000 +0000 @@ -1,8 +1,10 @@ -From 310e479b5f517ccabab6ba5a07a99378cf7ab5fd Mon Sep 17 00:00:00 2001 +From 317ec441647fe3d58c05e4746c2fc7b0499fdac4 Mon Sep 17 00:00:00 2001 From: Didier Pallard Date: Wed, 19 Sep 2018 17:04:07 +0200 Subject: [PATCH] net/fm10k: fix missing Tx multi-segs capability +[ upstream commit 310e479b5f517ccabab6ba5a07a99378cf7ab5fd ] + In former API, ETH_TXQ_FLAGS_NOMULTSEGS was merely a hint indicating that application will never send multisegmented packets, allowing pmd to choose different tx methods accordingly. @@ -16,7 +18,6 @@ fm10k. Fixes: 30f3ce999e6a ("net/fm10k: convert to new Tx offloads API") -Cc: stable@dpdk.org Signed-off-by: Didier Pallard Acked-by: Konstantin Ananyev @@ -25,10 +26,10 @@ 1 file changed, 1 insertion(+) diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c -index 3359df3c8..7cf5b0314 100644 +index 541a49b75..aebe8b5a5 100644 --- a/drivers/net/fm10k/fm10k_ethdev.c +++ b/drivers/net/fm10k/fm10k_ethdev.c -@@ -1976,4 +1976,5 @@ static uint64_t fm10k_get_tx_port_offloads_capa(struct rte_eth_dev *dev) +@@ -1983,4 +1983,5 @@ static uint64_t fm10k_get_tx_port_offloads_capa(struct rte_eth_dev *dev) return (uint64_t)(DEV_TX_OFFLOAD_VLAN_INSERT | + DEV_TX_OFFLOAD_MULTI_SEGS |