From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id B8F501B119 for ; Wed, 21 Nov 2018 17:06:52 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2254C58E3B; Wed, 21 Nov 2018 16:06:52 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.36.118.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id D97F42C8E4; Wed, 21 Nov 2018 16:06:50 +0000 (UTC) From: Kevin Traynor To: Anoob Joseph Cc: Ayuj Verma , Akhil Goyal , dpdk stable Date: Wed, 21 Nov 2018 16:04:33 +0000 Message-Id: <20181121160440.9014-43-ktraynor@redhat.com> In-Reply-To: <20181121160440.9014-1-ktraynor@redhat.com> References: <20181121160440.9014-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Wed, 21 Nov 2018 16:06:52 +0000 (UTC) Subject: [dpdk-stable] patch 'app/test-crypto-perf: fix check for auth key' has been queued to stable release 18.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Nov 2018 16:06:53 -0000 Hi, FYI, your patch has been queued to stable release 18.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/26/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Kevin Traynor --- >>From 14280883c473c0a379076efe2347d903f1672005 Mon Sep 17 00:00:00 2001 From: Anoob Joseph Date: Fri, 14 Sep 2018 14:54:47 +0530 Subject: [PATCH] app/test-crypto-perf: fix check for auth key [ upstream commit c864167ce97d91ed95c68f8f85cf2dbaaae212d3 ] Authentication key is not required for all algorithms. Making sure the null check is done only when 'auth_key_sz' is non-zero. Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") Signed-off-by: Anoob Joseph Signed-off-by: Ayuj Verma Acked-by: Akhil Goyal --- app/test-crypto-perf/main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c index 5c7dadb60..b1e91f14e 100644 --- a/app/test-crypto-perf/main.c +++ b/app/test-crypto-perf/main.c @@ -358,5 +358,7 @@ cperf_check_test_vector(struct cperf_options *opts, if (test_vec->plaintext.length < opts->max_buffer_size) return -1; - if (test_vec->auth_key.data == NULL) + /* Auth key is only required for some algorithms */ + if (opts->auth_key_sz && + test_vec->auth_key.data == NULL) return -1; if (test_vec->auth_key.length != opts->auth_key_sz) -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-21 15:59:14.706251574 +0000 +++ 0043-app-test-crypto-perf-fix-check-for-auth-key.patch 2018-11-21 15:59:13.000000000 +0000 @@ -1,13 +1,14 @@ -From c864167ce97d91ed95c68f8f85cf2dbaaae212d3 Mon Sep 17 00:00:00 2001 +From 14280883c473c0a379076efe2347d903f1672005 Mon Sep 17 00:00:00 2001 From: Anoob Joseph Date: Fri, 14 Sep 2018 14:54:47 +0530 Subject: [PATCH] app/test-crypto-perf: fix check for auth key +[ upstream commit c864167ce97d91ed95c68f8f85cf2dbaaae212d3 ] + Authentication key is not required for all algorithms. Making sure the null check is done only when 'auth_key_sz' is non-zero. Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application") -Cc: stable@dpdk.org Signed-off-by: Anoob Joseph Signed-off-by: Ayuj Verma @@ -17,7 +18,7 @@ 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c -index c9f99a76d..55d97c26b 100644 +index 5c7dadb60..b1e91f14e 100644 --- a/app/test-crypto-perf/main.c +++ b/app/test-crypto-perf/main.c @@ -358,5 +358,7 @@ cperf_check_test_vector(struct cperf_options *opts,