From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 7CE161B117 for ; Wed, 21 Nov 2018 17:07:00 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CEED43B554; Wed, 21 Nov 2018 16:06:59 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.36.118.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id B785F6607E; Wed, 21 Nov 2018 16:06:58 +0000 (UTC) From: Kevin Traynor To: Fiona Trahe Cc: Tomasz Jozwiak , dpdk stable Date: Wed, 21 Nov 2018 16:04:38 +0000 Message-Id: <20181121160440.9014-48-ktraynor@redhat.com> In-Reply-To: <20181121160440.9014-1-ktraynor@redhat.com> References: <20181121160440.9014-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 21 Nov 2018 16:06:59 +0000 (UTC) Subject: [dpdk-stable] patch 'compress/qat: fix checksum on decompression' has been queued to stable release 18.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Nov 2018 16:07:00 -0000 Hi, FYI, your patch has been queued to stable release 18.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/26/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Kevin Traynor --- >>From 4d5adf65e272f0a2e147c72cf763cfc29b613ded Mon Sep 17 00:00:00 2001 From: Fiona Trahe Date: Sat, 22 Sep 2018 14:25:37 +0100 Subject: [PATCH] compress/qat: fix checksum on decompression [ upstream commit 7586c5787375b3947d7d12c91aa99ac4ff58203d ] Checksum was always 0 on QAT decompression due to incorrect use of union variable. Fixes: 6a7ea14819e9 ("compress/qat: add xform processing") Signed-off-by: Fiona Trahe Acked-by: Tomasz Jozwiak --- drivers/compress/qat/qat_comp.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/compress/qat/qat_comp.c b/drivers/compress/qat/qat_comp.c index 38c8a5b82..6f1f2dc25 100644 --- a/drivers/compress/qat/qat_comp.c +++ b/drivers/compress/qat/qat_comp.c @@ -346,15 +346,14 @@ qat_comp_private_xform_create(struct rte_compressdev *dev, ((xform->compress.deflate.huffman == RTE_COMP_HUFFMAN_DEFAULT) && qat->interm_buff_mz == NULL)) - qat_xform->qat_comp_request_type = QAT_COMP_REQUEST_FIXED_COMP_STATELESS; + qat_xform->checksum_type = xform->compress.chksum; } else { qat_xform->qat_comp_request_type = QAT_COMP_REQUEST_DECOMPRESS; + qat_xform->checksum_type = xform->decompress.chksum; } - qat_xform->checksum_type = xform->compress.chksum; - if (qat_comp_create_templates(qat_xform, qat->interm_buff_mz, xform)) { QAT_LOG(ERR, "QAT: Problem with setting compression"); -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-21 15:59:14.824493803 +0000 +++ 0048-compress-qat-fix-checksum-on-decompression.patch 2018-11-21 15:59:13.000000000 +0000 @@ -1,13 +1,14 @@ -From 7586c5787375b3947d7d12c91aa99ac4ff58203d Mon Sep 17 00:00:00 2001 +From 4d5adf65e272f0a2e147c72cf763cfc29b613ded Mon Sep 17 00:00:00 2001 From: Fiona Trahe Date: Sat, 22 Sep 2018 14:25:37 +0100 Subject: [PATCH] compress/qat: fix checksum on decompression +[ upstream commit 7586c5787375b3947d7d12c91aa99ac4ff58203d ] + Checksum was always 0 on QAT decompression due to incorrect use of union variable. Fixes: 6a7ea14819e9 ("compress/qat: add xform processing") -Cc: stable@dpdk.org Signed-off-by: Fiona Trahe Acked-by: Tomasz Jozwiak