From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 6BDD11B119 for ; Wed, 21 Nov 2018 17:07:03 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CB67B300157F; Wed, 21 Nov 2018 16:07:02 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.36.118.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id C915D60A9C; Wed, 21 Nov 2018 16:07:01 +0000 (UTC) From: Kevin Traynor To: Fiona Trahe Cc: Akhil Goyal , dpdk stable Date: Wed, 21 Nov 2018 16:04:40 +0000 Message-Id: <20181121160440.9014-50-ktraynor@redhat.com> In-Reply-To: <20181121160440.9014-1-ktraynor@redhat.com> References: <20181121160440.9014-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Wed, 21 Nov 2018 16:07:02 +0000 (UTC) Subject: [dpdk-stable] patch 'test/crypto: fix number of queue pairs' has been queued to stable release 18.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Nov 2018 16:07:03 -0000 Hi, FYI, your patch has been queued to stable release 18.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/26/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Kevin Traynor --- >>From bd00d0019e5b3c9a01656622c6f3b52f714f89aa Mon Sep 17 00:00:00 2001 From: Fiona Trahe Date: Sat, 22 Sep 2018 14:33:36 +0100 Subject: [PATCH] test/crypto: fix number of queue pairs [ upstream commit 738ad7b42b63fc5067419bf609296f2c4a6a0cb0 ] Some of the tests use a QAT-specific value (2) for maximum nr of queue pairs to create valid/invalid test cases. This has accidentally worked ok as default max_qps for all PMDs is larger. It is incorrect however and would fail if a device had a max lower than the QAT value. Instead use the value returned by the PMD in the rte_cryptodev_get_info query, this value is stored in the ts_params. Fixes: 202d375c60bc ("app/test: add cryptodev unit and performance tests") Signed-off-by: Fiona Trahe Acked-by: Akhil Goyal --- test/test/test_cryptodev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/test/test_cryptodev.c b/test/test/test_cryptodev.c index a6044b261..c63662d91 100644 --- a/test/test/test_cryptodev.c +++ b/test/test/test_cryptodev.c @@ -636,5 +636,5 @@ test_device_configure_invalid_queue_pair_ids(void) /* valid - max value queue pairs */ - ts_params->conf.nb_queue_pairs = MAX_NUM_QPS_PER_QAT_DEVICE; + ts_params->conf.nb_queue_pairs = orig_nb_qps; TEST_ASSERT_SUCCESS(rte_cryptodev_configure(ts_params->valid_devs[0], @@ -668,5 +668,5 @@ test_device_configure_invalid_queue_pair_ids(void) /* invalid - max value + 1 queue pairs */ - ts_params->conf.nb_queue_pairs = MAX_NUM_QPS_PER_QAT_DEVICE + 1; + ts_params->conf.nb_queue_pairs = orig_nb_qps + 1; TEST_ASSERT_FAIL(rte_cryptodev_configure(ts_params->valid_devs[0], @@ -820,5 +820,5 @@ test_queue_pair_descriptor_setup(void) qp_conf.nb_descriptors = DEFAULT_NUM_OPS_INFLIGHT; /*valid */ - qp_id = DEFAULT_NUM_QPS_PER_QAT_DEVICE; /*invalid */ + qp_id = ts_params->conf.nb_queue_pairs; /*invalid */ TEST_ASSERT_FAIL(rte_cryptodev_queue_pair_setup( -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-21 15:59:14.876873177 +0000 +++ 0050-test-crypto-fix-number-of-queue-pairs.patch 2018-11-21 15:59:13.000000000 +0000 @@ -1,8 +1,10 @@ -From 738ad7b42b63fc5067419bf609296f2c4a6a0cb0 Mon Sep 17 00:00:00 2001 +From bd00d0019e5b3c9a01656622c6f3b52f714f89aa Mon Sep 17 00:00:00 2001 From: Fiona Trahe Date: Sat, 22 Sep 2018 14:33:36 +0100 Subject: [PATCH] test/crypto: fix number of queue pairs +[ upstream commit 738ad7b42b63fc5067419bf609296f2c4a6a0cb0 ] + Some of the tests use a QAT-specific value (2) for maximum nr of queue pairs to create valid/invalid test cases. This has accidentally worked ok as default max_qps for all PMDs @@ -12,7 +14,6 @@ rte_cryptodev_get_info query, this value is stored in the ts_params. Fixes: 202d375c60bc ("app/test: add cryptodev unit and performance tests") -Cc: stable@dpdk.org Signed-off-by: Fiona Trahe Acked-by: Akhil Goyal