From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 0BEFA1B108 for ; Wed, 21 Nov 2018 17:05:56 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6A14130001E0; Wed, 21 Nov 2018 16:05:55 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.36.118.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7E7555F7D9; Wed, 21 Nov 2018 16:05:54 +0000 (UTC) From: Kevin Traynor To: Andrew Rybchenko Cc: dpdk stable Date: Wed, 21 Nov 2018 16:03:57 +0000 Message-Id: <20181121160440.9014-7-ktraynor@redhat.com> In-Reply-To: <20181121160440.9014-1-ktraynor@redhat.com> References: <20181121160440.9014-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.46]); Wed, 21 Nov 2018 16:05:55 +0000 (UTC) Subject: [dpdk-stable] patch 'net/sfc/base: fix build because of no declaration' has been queued to stable release 18.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Nov 2018 16:05:56 -0000 Hi, FYI, your patch has been queued to stable release 18.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/26/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Kevin Traynor --- >>From b86a6354b6791a49aaaf515e6c42dae2d490e081 Mon Sep 17 00:00:00 2001 From: Andrew Rybchenko Date: Mon, 10 Sep 2018 10:33:07 +0100 Subject: [PATCH] net/sfc/base: fix build because of no declaration [ upstream commit 5d23ac47e940f78bf6d95e6e52d3e0b9c486b8dd ] Functions declared in mcdi_mon.h are implemented in mcdi_mon.c. The build fails if compiler options require declaration before definition. Fixes: dfb3b1ce15f6 ("net/sfc/base: import monitors access via MCDI") Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/base/mcdi_mon.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/sfc/base/mcdi_mon.c b/drivers/net/sfc/base/mcdi_mon.c index 940bd0265..8c0b6f0d9 100644 --- a/drivers/net/sfc/base/mcdi_mon.c +++ b/drivers/net/sfc/base/mcdi_mon.c @@ -7,4 +7,5 @@ #include "efx.h" #include "efx_impl.h" +#include "mcdi_mon.h" #if EFSYS_OPT_MON_MCDI -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-21 15:59:13.804523845 +0000 +++ 0007-net-sfc-base-fix-build-because-of-no-declaration.patch 2018-11-21 15:59:13.000000000 +0000 @@ -1,13 +1,14 @@ -From 5d23ac47e940f78bf6d95e6e52d3e0b9c486b8dd Mon Sep 17 00:00:00 2001 +From b86a6354b6791a49aaaf515e6c42dae2d490e081 Mon Sep 17 00:00:00 2001 From: Andrew Rybchenko Date: Mon, 10 Sep 2018 10:33:07 +0100 Subject: [PATCH] net/sfc/base: fix build because of no declaration +[ upstream commit 5d23ac47e940f78bf6d95e6e52d3e0b9c486b8dd ] + Functions declared in mcdi_mon.h are implemented in mcdi_mon.c. The build fails if compiler options require declaration before definition. Fixes: dfb3b1ce15f6 ("net/sfc/base: import monitors access via MCDI") -Cc: stable@dpdk.org Signed-off-by: Andrew Rybchenko ---