From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 5645D1B49A for ; Thu, 22 Nov 2018 17:52:04 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B4478169736; Thu, 22 Nov 2018 16:52:03 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.36.118.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8096060E3F; Thu, 22 Nov 2018 16:52:02 +0000 (UTC) From: Kevin Traynor To: Jeff Guo Cc: Ferruh Yigit , dpdk stable Date: Thu, 22 Nov 2018 16:49:15 +0000 Message-Id: <20181122164957.13003-23-ktraynor@redhat.com> In-Reply-To: <20181122164957.13003-1-ktraynor@redhat.com> References: <20181122164957.13003-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 22 Nov 2018 16:52:03 +0000 (UTC) Subject: [dpdk-stable] patch 'igb_uio: fix unexpected removal for hot-unplug' has been queued to stable release 18.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Nov 2018 16:52:04 -0000 Hi, FYI, your patch has been queued to stable release 18.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/28/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Kevin Traynor --- >>From 4b25a4627b057f3d6f7d36110a7dc111aac25724 Mon Sep 17 00:00:00 2001 From: Jeff Guo Date: Thu, 18 Oct 2018 14:27:15 +0800 Subject: [PATCH] igb_uio: fix unexpected removal for hot-unplug [ upstream commit 70efa4116420b6f7a0734711dd603d3024366c79 ] When a device is hot-unplugged, pci_remove will be invoked unexpectedly before pci_release, it will caused kernel hung issue which will throw the error info of "Trying to free already-free IRQ XXX". And on the other hand, if pci_remove before pci_release, the interrupt will not got chance to be disabled. So this patch aim to fix this issue by adding pci_release call in pci_remove, it will gurranty that all pci clean up will be done before pci removal. Signed-off-by: Jeff Guo Acked-by: Ferruh Yigit --- kernel/linux/igb_uio/igb_uio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/linux/igb_uio/igb_uio.c b/kernel/linux/igb_uio/igb_uio.c index fede66cf2..3cf394bdf 100644 --- a/kernel/linux/igb_uio/igb_uio.c +++ b/kernel/linux/igb_uio/igb_uio.c @@ -571,4 +571,6 @@ igbuio_pci_remove(struct pci_dev *dev) struct rte_uio_pci_dev *udev = pci_get_drvdata(dev); + igbuio_pci_release(&udev->info, NULL); + sysfs_remove_group(&dev->dev.kobj, &dev_attr_grp); uio_unregister_device(&udev->info); -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-22 16:47:32.867863759 +0000 +++ 0023-igb_uio-fix-unexpected-removal-for-hot-unplug.patch 2018-11-22 16:47:32.000000000 +0000 @@ -1,8 +1,10 @@ -From 70efa4116420b6f7a0734711dd603d3024366c79 Mon Sep 17 00:00:00 2001 +From 4b25a4627b057f3d6f7d36110a7dc111aac25724 Mon Sep 17 00:00:00 2001 From: Jeff Guo Date: Thu, 18 Oct 2018 14:27:15 +0800 Subject: [PATCH] igb_uio: fix unexpected removal for hot-unplug +[ upstream commit 70efa4116420b6f7a0734711dd603d3024366c79 ] + When a device is hot-unplugged, pci_remove will be invoked unexpectedly before pci_release, it will caused kernel hung issue which will throw the error info of "Trying to free already-free IRQ XXX". And on the other hand,