From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 4ED751B488 for ; Thu, 22 Nov 2018 17:52:18 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A97B77F6C5; Thu, 22 Nov 2018 16:52:17 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.36.118.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4628460E3F; Thu, 22 Nov 2018 16:52:16 +0000 (UTC) From: Kevin Traynor To: Yipeng Wang Cc: Bruce Richardson , Honnappa Nagarahalli , dpdk stable Date: Thu, 22 Nov 2018 16:49:22 +0000 Message-Id: <20181122164957.13003-30-ktraynor@redhat.com> In-Reply-To: <20181122164957.13003-1-ktraynor@redhat.com> References: <20181122164957.13003-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Thu, 22 Nov 2018 16:52:17 +0000 (UTC) Subject: [dpdk-stable] patch 'test/hash: fix bucket size in perf test' has been queued to stable release 18.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Nov 2018 16:52:18 -0000 Hi, FYI, your patch has been queued to stable release 18.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/28/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Kevin Traynor --- >>From b5a4111b1eb2471ab268739054ffeaf057d59bb7 Mon Sep 17 00:00:00 2001 From: Yipeng Wang Date: Fri, 28 Sep 2018 07:11:05 -0700 Subject: [PATCH] test/hash: fix bucket size in perf test [ upstream commit b772a15eb84ce616114880a20ad6ad91bb8970fc ] The bucket size was changed from 4 to 8 but the corresponding perf test was not changed accordingly. In the test, the bucket size and number of buckets are used to map to the underneath rte_hash structure. They are used to test performance of two conditions: keys in primary buckets only and keys in both primary and secondary buckets. Although there is no functional issue with bucket size set to 4, it mismatches the underneath rte_hash structure, which may affect code readability and future extension. Fixes: 58017c98ed53 ("hash: add vectorized comparison") Signed-off-by: Yipeng Wang Acked-by: Bruce Richardson Reviewed-by: Honnappa Nagarahalli --- test/test/test_hash_perf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/test/test/test_hash_perf.c b/test/test/test_hash_perf.c index 33dcb9fcf..fe116326d 100644 --- a/test/test/test_hash_perf.c +++ b/test/test/test_hash_perf.c @@ -21,5 +21,6 @@ #define KEYS_TO_ADD (MAX_ENTRIES * 3 / 4) /* 75% table utilization */ #define NUM_LOOKUPS (KEYS_TO_ADD * 5) /* Loop among keys added, several times */ -#define BUCKET_SIZE 4 +/* BUCKET_SIZE should be same as RTE_HASH_BUCKET_ENTRIES in rte_hash library */ +#define BUCKET_SIZE 8 #define NUM_BUCKETS (MAX_ENTRIES / BUCKET_SIZE) #define MAX_KEYSIZE 64 -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-22 16:47:33.039313907 +0000 +++ 0030-test-hash-fix-bucket-size-in-perf-test.patch 2018-11-22 16:47:32.000000000 +0000 @@ -1,8 +1,10 @@ -From b772a15eb84ce616114880a20ad6ad91bb8970fc Mon Sep 17 00:00:00 2001 +From b5a4111b1eb2471ab268739054ffeaf057d59bb7 Mon Sep 17 00:00:00 2001 From: Yipeng Wang Date: Fri, 28 Sep 2018 07:11:05 -0700 Subject: [PATCH] test/hash: fix bucket size in perf test +[ upstream commit b772a15eb84ce616114880a20ad6ad91bb8970fc ] + The bucket size was changed from 4 to 8 but the corresponding perf test was not changed accordingly. @@ -16,7 +18,6 @@ which may affect code readability and future extension. Fixes: 58017c98ed53 ("hash: add vectorized comparison") -Cc: stable@dpdk.org Signed-off-by: Yipeng Wang Acked-by: Bruce Richardson