From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 54D1E1B49A for ; Thu, 22 Nov 2018 17:52:41 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BAA6061D07; Thu, 22 Nov 2018 16:52:40 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.36.118.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2C29160FD9; Thu, 22 Nov 2018 16:52:38 +0000 (UTC) From: Kevin Traynor To: Yipeng Wang Cc: Bruce Richardson , dpdk stable Date: Thu, 22 Nov 2018 16:49:32 +0000 Message-Id: <20181122164957.13003-40-ktraynor@redhat.com> In-Reply-To: <20181122164957.13003-1-ktraynor@redhat.com> References: <20181122164957.13003-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 22 Nov 2018 16:52:40 +0000 (UTC) Subject: [dpdk-stable] patch 'hash: remove unnecessary pause' has been queued to stable release 18.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Nov 2018 16:52:41 -0000 Hi, FYI, your patch has been queued to stable release 18.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/28/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Kevin Traynor --- >>From 27c9b92a18f2fa0f5f3b64bdff7ca53acbb14a07 Mon Sep 17 00:00:00 2001 From: Yipeng Wang Date: Fri, 26 Oct 2018 02:53:41 -0700 Subject: [PATCH] hash: remove unnecessary pause [ upstream commit 2d28bb5ddd0fb7c3bed44f3f3fbc7a7bc449ea7a ] There is a rte_pause in hash table reset function. Since the loop is not a polling loop on shared data structure, the rte_pause is not needed. Fixes: b26473ff8f4a ("hash: add reset function") Signed-off-by: Yipeng Wang Acked-by: Bruce Richardson --- lib/librte_hash/rte_cuckoo_hash.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/librte_hash/rte_cuckoo_hash.c b/lib/librte_hash/rte_cuckoo_hash.c index 0c9df35d3..9a99a415e 100644 --- a/lib/librte_hash/rte_cuckoo_hash.c +++ b/lib/librte_hash/rte_cuckoo_hash.c @@ -27,5 +27,4 @@ #include #include -#include #include "rte_hash.h" @@ -449,5 +448,5 @@ rte_hash_reset(struct rte_hash *h) /* clear the free ring */ while (rte_ring_dequeue(h->free_slots, &ptr) == 0) - rte_pause(); + continue; /* Repopulate the free slots ring. Entry zero is reserved for key misses */ -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-22 16:47:33.300523998 +0000 +++ 0040-hash-remove-unnecessary-pause.patch 2018-11-22 16:47:32.000000000 +0000 @@ -1,45 +1,39 @@ -From 2d28bb5ddd0fb7c3bed44f3f3fbc7a7bc449ea7a Mon Sep 17 00:00:00 2001 +From 27c9b92a18f2fa0f5f3b64bdff7ca53acbb14a07 Mon Sep 17 00:00:00 2001 From: Yipeng Wang Date: Fri, 26 Oct 2018 02:53:41 -0700 Subject: [PATCH] hash: remove unnecessary pause +[ upstream commit 2d28bb5ddd0fb7c3bed44f3f3fbc7a7bc449ea7a ] + There is a rte_pause in hash table reset function. Since the loop is not a polling loop on shared data structure, the rte_pause is not needed. Fixes: b26473ff8f4a ("hash: add reset function") -Cc: stable@dpdk.org Signed-off-by: Yipeng Wang Acked-by: Bruce Richardson --- - lib/librte_hash/rte_cuckoo_hash.c | 5 ++--- - 1 file changed, 2 insertions(+), 3 deletions(-) + lib/librte_hash/rte_cuckoo_hash.c | 3 +-- + 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/librte_hash/rte_cuckoo_hash.c b/lib/librte_hash/rte_cuckoo_hash.c -index 0648a2294..5ddcccd87 100644 +index 0c9df35d3..9a99a415e 100644 --- a/lib/librte_hash/rte_cuckoo_hash.c +++ b/lib/librte_hash/rte_cuckoo_hash.c -@@ -28,5 +28,4 @@ +@@ -27,5 +27,4 @@ #include #include -#include #include "rte_hash.h" -@@ -575,5 +574,5 @@ rte_hash_reset(struct rte_hash *h) +@@ -449,5 +448,5 @@ rte_hash_reset(struct rte_hash *h) /* clear the free ring */ while (rte_ring_dequeue(h->free_slots, &ptr) == 0) - rte_pause(); + continue; - /* clear free extendable bucket ring and memory */ -@@ -582,5 +581,5 @@ rte_hash_reset(struct rte_hash *h) - sizeof(struct rte_hash_bucket)); - while (rte_ring_dequeue(h->free_ext_bkts, &ptr) == 0) -- rte_pause(); -+ continue; - } - + /* Repopulate the free slots ring. Entry zero is reserved for key misses */ -- 2.19.0