From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 0D9F51B488 for ; Thu, 22 Nov 2018 17:53:07 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 711924E93F; Thu, 22 Nov 2018 16:53:06 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.36.118.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8548460FD9; Thu, 22 Nov 2018 16:53:04 +0000 (UTC) From: Kevin Traynor To: Wei Zhao Cc: Yuan Peng , Qi Zhang , dpdk stable Date: Thu, 22 Nov 2018 16:49:44 +0000 Message-Id: <20181122164957.13003-52-ktraynor@redhat.com> In-Reply-To: <20181122164957.13003-1-ktraynor@redhat.com> References: <20181122164957.13003-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Thu, 22 Nov 2018 16:53:06 +0000 (UTC) Subject: [dpdk-stable] patch 'net/ixgbe: fix RSS flow error return' has been queued to stable release 18.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Nov 2018 16:53:07 -0000 Hi, FYI, your patch has been queued to stable release 18.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/28/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Kevin Traynor --- >>From ae3865036d0a4d64b61aba7ae0dbf7462ad617e2 Mon Sep 17 00:00:00 2001 From: Wei Zhao Date: Tue, 23 Oct 2018 11:38:10 +0800 Subject: [PATCH] net/ixgbe: fix RSS flow error return [ upstream commit 6e8110cca64f69814ccb493efb5471f6e948ba44 ] If hash function is 0, it should disable RSS then return 0. Fixes: 518cc3927b13 ("net/ixgbe: move RSS to flow API") Signed-off-by: Wei Zhao Tested-by: Yuan Peng Acked-by: Qi Zhang --- drivers/net/ixgbe/ixgbe_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c index f82b74a9a..b0172a7d2 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx.c +++ b/drivers/net/ixgbe/ixgbe_rxtx.c @@ -5703,5 +5703,5 @@ ixgbe_config_rss_filter(struct rte_eth_dev *dev, if ((rss_conf.rss_hf & IXGBE_RSS_OFFLOAD_ALL) == 0) { ixgbe_rss_disable(dev); - return -EINVAL; + return 0; } if (rss_conf.rss_key == NULL) -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-22 16:47:33.632436417 +0000 +++ 0052-net-ixgbe-fix-RSS-flow-error-return.patch 2018-11-22 16:47:32.000000000 +0000 @@ -1,12 +1,13 @@ -From 6e8110cca64f69814ccb493efb5471f6e948ba44 Mon Sep 17 00:00:00 2001 +From ae3865036d0a4d64b61aba7ae0dbf7462ad617e2 Mon Sep 17 00:00:00 2001 From: Wei Zhao Date: Tue, 23 Oct 2018 11:38:10 +0800 Subject: [PATCH] net/ixgbe: fix RSS flow error return +[ upstream commit 6e8110cca64f69814ccb493efb5471f6e948ba44 ] + If hash function is 0, it should disable RSS then return 0. Fixes: 518cc3927b13 ("net/ixgbe: move RSS to flow API") -Cc: stable@dpdk.org Signed-off-by: Wei Zhao Tested-by: Yuan Peng @@ -16,7 +17,7 @@ 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c -index 8609f4195..9e2fbba3e 100644 +index f82b74a9a..b0172a7d2 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx.c +++ b/drivers/net/ixgbe/ixgbe_rxtx.c @@ -5703,5 +5703,5 @@ ixgbe_config_rss_filter(struct rte_eth_dev *dev,