From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 574211B49A for ; Thu, 22 Nov 2018 17:53:15 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B878EC057F2A; Thu, 22 Nov 2018 16:53:14 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.36.118.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5DD6460E3F; Thu, 22 Nov 2018 16:53:13 +0000 (UTC) From: Kevin Traynor To: Rosen Xu Cc: Shreyansh Jain , dpdk stable Date: Thu, 22 Nov 2018 16:49:47 +0000 Message-Id: <20181122164957.13003-55-ktraynor@redhat.com> In-Reply-To: <20181122164957.13003-1-ktraynor@redhat.com> References: <20181122164957.13003-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 22 Nov 2018 16:53:14 +0000 (UTC) Subject: [dpdk-stable] patch 'raw/ifpga: check probing error' has been queued to stable release 18.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Nov 2018 16:53:15 -0000 Hi, FYI, your patch has been queued to stable release 18.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/28/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Kevin Traynor --- >>From 2f6edcf4a521dde6c0413f00a89eb3d8cf825c15 Mon Sep 17 00:00:00 2001 From: Rosen Xu Date: Tue, 23 Oct 2018 09:50:49 +0800 Subject: [PATCH] raw/ifpga: check probing error [ upstream commit b6aadd7436bfc1fb2af67aa266588fdd80ca8988 ] Fixes not checking rte_eal_hotplug_add() return value issue. Coverity issue: 323508 Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") Signed-off-by: Rosen Xu Acked-by: Shreyansh Jain --- drivers/raw/ifpga_rawdev/ifpga_rawdev.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c index 3fed05781..32e318fc3 100644 --- a/drivers/raw/ifpga_rawdev/ifpga_rawdev.c +++ b/drivers/raw/ifpga_rawdev/ifpga_rawdev.c @@ -543,4 +543,5 @@ ifpga_cfg_probe(struct rte_vdev_device *dev) char *name = NULL; char dev_name[RTE_RAWDEV_NAME_MAX_LEN]; + int ret = -1; devargs = dev->device.devargs; @@ -584,5 +585,5 @@ ifpga_cfg_probe(struct rte_vdev_device *dev) port, name); - rte_eal_hotplug_add(RTE_STR(IFPGA_BUS_NAME), + ret = rte_eal_hotplug_add(RTE_STR(IFPGA_BUS_NAME), dev_name, devargs->args); end: @@ -592,5 +593,5 @@ end: free(name); - return 0; + return ret; } -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-22 16:47:33.714730084 +0000 +++ 0055-raw-ifpga-check-probing-error.patch 2018-11-22 16:47:32.000000000 +0000 @@ -1,13 +1,14 @@ -From b6aadd7436bfc1fb2af67aa266588fdd80ca8988 Mon Sep 17 00:00:00 2001 +From 2f6edcf4a521dde6c0413f00a89eb3d8cf825c15 Mon Sep 17 00:00:00 2001 From: Rosen Xu Date: Tue, 23 Oct 2018 09:50:49 +0800 Subject: [PATCH] raw/ifpga: check probing error +[ upstream commit b6aadd7436bfc1fb2af67aa266588fdd80ca8988 ] + Fixes not checking rte_eal_hotplug_add() return value issue. Coverity issue: 323508 Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") -Cc: stable@dpdk.org Signed-off-by: Rosen Xu Acked-by: Shreyansh Jain