From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 5C22C1B494 for ; Fri, 23 Nov 2018 11:29:07 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C0435356CD; Fri, 23 Nov 2018 10:29:06 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.36.118.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id B627A413C; Fri, 23 Nov 2018 10:29:05 +0000 (UTC) From: Kevin Traynor To: Jerin Jacob Cc: dpdk stable Date: Fri, 23 Nov 2018 10:26:20 +0000 Message-Id: <20181123102713.17309-16-ktraynor@redhat.com> In-Reply-To: <20181123102713.17309-1-ktraynor@redhat.com> References: <20181123102713.17309-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 23 Nov 2018 10:29:06 +0000 (UTC) Subject: [dpdk-stable] patch 'crypto/scheduler: fix build with gcc 8.2' has been queued to stable release 18.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Nov 2018 10:29:07 -0000 Hi, FYI, your patch has been queued to stable release 18.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/29/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Kevin Traynor --- >>From e6ce271d4197e252debbea4a840243748fb14bf4 Mon Sep 17 00:00:00 2001 From: Jerin Jacob Date: Sat, 3 Nov 2018 14:58:53 +0000 Subject: [PATCH] crypto/scheduler: fix build with gcc 8.2 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit e5e193acf09c9d4b08e8ed7f2bf9a61b5c204fff ] build_error: drivers/crypto/scheduler/scheduler_pmd.c: In function ‘parse_name_arg’: drivers/crypto/scheduler/scheduler_pmd.c:372:2: error: ‘strncpy’ specified bound 64 equals destination size [-Werror=stringop-truncation] strncpy(params->name, value, RTE_CRYPTODEV_NAME_MAX_LEN); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ strncpy may result a not null-terminated string, replaced it with strlcpy Fixes: 503e9c5afb38 ("crypto/scheduler: register as vdev driver") Signed-off-by: Jerin Jacob --- drivers/crypto/scheduler/scheduler_pmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/scheduler/scheduler_pmd.c b/drivers/crypto/scheduler/scheduler_pmd.c index a9221a946..71a48b65c 100644 --- a/drivers/crypto/scheduler/scheduler_pmd.c +++ b/drivers/crypto/scheduler/scheduler_pmd.c @@ -370,5 +370,5 @@ parse_name_arg(const char *key __rte_unused, } - strncpy(params->name, value, RTE_CRYPTODEV_NAME_MAX_LEN); + strlcpy(params->name, value, RTE_CRYPTODEV_NAME_MAX_LEN); return 0; -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-23 10:22:54.657670307 +0000 +++ 0016-crypto-scheduler-fix-build-with-gcc-8.2.patch 2018-11-23 10:22:54.000000000 +0000 @@ -1,4 +1,4 @@ -From e5e193acf09c9d4b08e8ed7f2bf9a61b5c204fff Mon Sep 17 00:00:00 2001 +From e6ce271d4197e252debbea4a840243748fb14bf4 Mon Sep 17 00:00:00 2001 From: Jerin Jacob Date: Sat, 3 Nov 2018 14:58:53 +0000 Subject: [PATCH] crypto/scheduler: fix build with gcc 8.2 @@ -6,6 +6,8 @@ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit +[ upstream commit e5e193acf09c9d4b08e8ed7f2bf9a61b5c204fff ] + build_error: drivers/crypto/scheduler/scheduler_pmd.c: In function ‘parse_name_arg’: @@ -17,7 +19,6 @@ replaced it with strlcpy Fixes: 503e9c5afb38 ("crypto/scheduler: register as vdev driver") -Cc: stable@dpdk.org Signed-off-by: Jerin Jacob --- @@ -25,7 +26,7 @@ 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/scheduler/scheduler_pmd.c b/drivers/crypto/scheduler/scheduler_pmd.c -index 20198ccb0..a1632a2b9 100644 +index a9221a946..71a48b65c 100644 --- a/drivers/crypto/scheduler/scheduler_pmd.c +++ b/drivers/crypto/scheduler/scheduler_pmd.c @@ -370,5 +370,5 @@ parse_name_arg(const char *key __rte_unused,