From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 97C291B494 for ; Fri, 23 Nov 2018 11:29:10 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0290530832DC; Fri, 23 Nov 2018 10:29:10 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.36.118.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id E1A3A413C; Fri, 23 Nov 2018 10:29:08 +0000 (UTC) From: Kevin Traynor To: Ferruh Yigit Cc: dpdk stable Date: Fri, 23 Nov 2018 10:26:22 +0000 Message-Id: <20181123102713.17309-18-ktraynor@redhat.com> In-Reply-To: <20181123102713.17309-1-ktraynor@redhat.com> References: <20181123102713.17309-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Fri, 23 Nov 2018 10:29:10 +0000 (UTC) Subject: [dpdk-stable] patch 'eal: fix build with gcc 9.0' has been queued to stable release 18.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Nov 2018 10:29:11 -0000 Hi, FYI, your patch has been queued to stable release 18.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/29/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Kevin Traynor --- >>From b73ce2d5b1941a65ca48b25309f742ff571dd423 Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Fri, 2 Nov 2018 19:06:06 +0000 Subject: [PATCH] eal: fix build with gcc 9.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 3370975b994d793a89812031d86534916067dd67 ] build error: In function ‘eal_plugin_add’, .../lib/librte_eal/common/eal_common_options.c:225:2: error: ‘strncpy’ output may be truncated copying 4095 bytes from a string of length 4095 [-Werror=stringop-truncation] strncpy(solib->name, path, PATH_MAX-1); strncpy may result a not null-terminated string, replaced it with strlcpy Fixes: f9a08f650211 ("eal: add support for shared object drivers") Signed-off-by: Ferruh Yigit --- lib/librte_eal/common/eal_common_options.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c index 873099acc..eb572587a 100644 --- a/lib/librte_eal/common/eal_common_options.c +++ b/lib/librte_eal/common/eal_common_options.c @@ -221,5 +221,5 @@ eal_plugin_add(const char *path) } memset(solib, 0, sizeof(*solib)); - strncpy(solib->name, path, PATH_MAX-1); + strlcpy(solib->name, path, PATH_MAX-1); solib->name[PATH_MAX-1] = 0; TAILQ_INSERT_TAIL(&solib_list, solib, next); -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-23 10:22:54.704048024 +0000 +++ 0018-eal-fix-build-with-gcc-9.0.patch 2018-11-23 10:22:54.000000000 +0000 @@ -1,4 +1,4 @@ -From 3370975b994d793a89812031d86534916067dd67 Mon Sep 17 00:00:00 2001 +From b73ce2d5b1941a65ca48b25309f742ff571dd423 Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Fri, 2 Nov 2018 19:06:06 +0000 Subject: [PATCH] eal: fix build with gcc 9.0 @@ -6,6 +6,8 @@ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit +[ upstream commit 3370975b994d793a89812031d86534916067dd67 ] + build error: In function ‘eal_plugin_add’, .../lib/librte_eal/common/eal_common_options.c:225:2: @@ -17,7 +19,6 @@ replaced it with strlcpy Fixes: f9a08f650211 ("eal: add support for shared object drivers") -Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit --- @@ -25,10 +26,10 @@ 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/eal_common_options.c b/lib/librte_eal/common/eal_common_options.c -index b82f3ddd1..e31eca5c0 100644 +index 873099acc..eb572587a 100644 --- a/lib/librte_eal/common/eal_common_options.c +++ b/lib/librte_eal/common/eal_common_options.c -@@ -223,5 +223,5 @@ eal_plugin_add(const char *path) +@@ -221,5 +221,5 @@ eal_plugin_add(const char *path) } memset(solib, 0, sizeof(*solib)); - strncpy(solib->name, path, PATH_MAX-1);