From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id F085F1B432 for ; Fri, 23 Nov 2018 11:30:54 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5B1903082141; Fri, 23 Nov 2018 10:30:54 +0000 (UTC) Received: from ktraynor.remote.csb (unknown [10.36.118.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4040A1866A; Fri, 23 Nov 2018 10:30:52 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: Keith Wiles , dpdk stable Date: Fri, 23 Nov 2018 10:27:10 +0000 Message-Id: <20181123102713.17309-66-ktraynor@redhat.com> In-Reply-To: <20181123102713.17309-1-ktraynor@redhat.com> References: <20181123102713.17309-1-ktraynor@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Fri, 23 Nov 2018 10:30:54 +0000 (UTC) Subject: [dpdk-stable] patch 'net/tap: fix file descriptor check' has been queued to stable release 18.08.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Nov 2018 10:30:55 -0000 Hi, FYI, your patch has been queued to stable release 18.08.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/29/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Kevin Traynor --- >>From e001235f8a80b7b6f404d7317a636a905f8d5264 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Tue, 6 Nov 2018 11:30:05 -0800 Subject: [PATCH] net/tap: fix file descriptor check [ upstream commit e0a10f4691c2fa74d228a1c21772456afef1e060 ] Static analysis tools don't like the fact that fd could be zero in the error path. This won't happen in real world because stdin would have to be closed, then other error occurring. Coverity issue: 14079 Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD") Signed-off-by: Stephen Hemminger Acked-by: Keith Wiles --- drivers/net/tap/rte_eth_tap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index e05c7ba72..745405467 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -232,5 +232,5 @@ tun_alloc(struct pmd_internals *pmd, int is_keepalive) error: - if (fd > 0) + if (fd >= 0) close(fd); return -1; -- 2.19.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-23 10:22:55.949553581 +0000 +++ 0066-net-tap-fix-file-descriptor-check.patch 2018-11-23 10:22:54.000000000 +0000 @@ -1,15 +1,16 @@ -From e0a10f4691c2fa74d228a1c21772456afef1e060 Mon Sep 17 00:00:00 2001 +From e001235f8a80b7b6f404d7317a636a905f8d5264 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Tue, 6 Nov 2018 11:30:05 -0800 Subject: [PATCH] net/tap: fix file descriptor check +[ upstream commit e0a10f4691c2fa74d228a1c21772456afef1e060 ] + Static analysis tools don't like the fact that fd could be zero in the error path. This won't happen in real world because stdin would have to be closed, then other error occurring. Coverity issue: 14079 Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD") -Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger Acked-by: Keith Wiles @@ -18,10 +19,10 @@ 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c -index e7817e896..75b82f2b3 100644 +index e05c7ba72..745405467 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c -@@ -249,5 +249,5 @@ tun_alloc(struct pmd_internals *pmd, int is_keepalive) +@@ -232,5 +232,5 @@ tun_alloc(struct pmd_internals *pmd, int is_keepalive) error: - if (fd > 0)