From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 88ADC322C for ; Fri, 30 Nov 2018 00:12:55 +0100 (CET) Received: from Internal Mail-Server by MTLPINE1 (envelope-from yskoh@mellanox.com) with ESMTPS (AES256-SHA encrypted); 30 Nov 2018 01:18:44 +0200 Received: from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx [10.101.0.96]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id wATNCW7A032075; Fri, 30 Nov 2018 01:12:48 +0200 From: Yongseok Koh To: Igor Romanov Cc: Andrew Rybchenko , Chas Williams , dpdk stable Date: Thu, 29 Nov 2018 15:10:04 -0800 Message-Id: <20181129231202.30436-10-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20181129231202.30436-1-yskoh@mellanox.com> References: <20181129231202.30436-1-yskoh@mellanox.com> Subject: [dpdk-stable] patch 'net/bonding: use evenly distributed default RSS RETA' has been queued to LTS release 17.11.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 23:12:55 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/01/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Yongseok --- >>From 80c2c543ecb29442962f2c9a996ed9edbf869340 Mon Sep 17 00:00:00 2001 From: Igor Romanov Date: Wed, 29 Aug 2018 08:48:30 +0100 Subject: [PATCH] net/bonding: use evenly distributed default RSS RETA [ upstream commit 617d1ac2fd22e9a82d305c0607853f4ee0f7277b ] Default Redirection Table that is set in bonding driver is distributed evenly over all Rx queues only within every RETA group (the first RETA entries in every group are always start with zero). But in the most drivers, default RETA is distributed over all Rx queues without sequence resets in the beginning of a new group, which implies more balanced per-core load. Change the default RETA to be evenly distributed over all Rx queues considering the whole table. Fixes: 734ce47f71e0 ("bonding: support RSS dynamic configuration") Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko Acked-by: Chas Williams --- drivers/net/bonding/rte_eth_bond_pmd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index 15da5185e..2f90451a6 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c @@ -3026,7 +3026,9 @@ bond_ethdev_configure(struct rte_eth_dev *dev) for (i = 0; i < RTE_DIM(internals->reta_conf); i++) { internals->reta_conf[i].mask = ~0LL; for (j = 0; j < RTE_RETA_GROUP_SIZE; j++) - internals->reta_conf[i].reta[j] = j % dev->data->nb_rx_queues; + internals->reta_conf[i].reta[j] = + (i * RTE_RETA_GROUP_SIZE + j) % + dev->data->nb_rx_queues; } } -- 2.11.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-29 15:01:45.740604765 -0800 +++ 0010-net-bonding-use-evenly-distributed-default-RSS-RETA.patch 2018-11-29 15:01:44.977970000 -0800 @@ -1,8 +1,10 @@ -From 617d1ac2fd22e9a82d305c0607853f4ee0f7277b Mon Sep 17 00:00:00 2001 +From 80c2c543ecb29442962f2c9a996ed9edbf869340 Mon Sep 17 00:00:00 2001 From: Igor Romanov Date: Wed, 29 Aug 2018 08:48:30 +0100 Subject: [PATCH] net/bonding: use evenly distributed default RSS RETA +[ upstream commit 617d1ac2fd22e9a82d305c0607853f4ee0f7277b ] + Default Redirection Table that is set in bonding driver is distributed evenly over all Rx queues only within every RETA group (the first RETA entries in every group are always start with zero). But in the most @@ -14,7 +16,6 @@ considering the whole table. Fixes: 734ce47f71e0 ("bonding: support RSS dynamic configuration") -Cc: stable@dpdk.org Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko @@ -24,10 +25,10 @@ 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c -index b84f32263..0f5ab09e3 100644 +index 15da5185e..2f90451a6 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c -@@ -3293,7 +3293,9 @@ bond_ethdev_configure(struct rte_eth_dev *dev) +@@ -3026,7 +3026,9 @@ bond_ethdev_configure(struct rte_eth_dev *dev) for (i = 0; i < RTE_DIM(internals->reta_conf); i++) { internals->reta_conf[i].mask = ~0LL; for (j = 0; j < RTE_RETA_GROUP_SIZE; j++)