From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 1D5E51B518 for ; Fri, 30 Nov 2018 00:15:46 +0100 (CET) Received: from Internal Mail-Server by MTLPINE1 (envelope-from yskoh@mellanox.com) with ESMTPS (AES256-SHA encrypted); 30 Nov 2018 01:21:37 +0200 Received: from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx [10.101.0.96]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id wATNCW8q032075; Fri, 30 Nov 2018 01:15:43 +0200 From: Yongseok Koh To: Ferruh Yigit Cc: dpdk stable Date: Thu, 29 Nov 2018 15:11:46 -0800 Message-Id: <20181129231202.30436-112-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20181129231202.30436-1-yskoh@mellanox.com> References: <20181129231202.30436-1-yskoh@mellanox.com> Subject: [dpdk-stable] patch 'test/reorder: fix out of bound access' has been queued to LTS release 17.11.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 23:15:46 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/01/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Yongseok --- >>From 58c39aedb3724255b877df3d6d7e71202031ee20 Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Tue, 13 Nov 2018 23:31:37 +0000 Subject: [PATCH] test/reorder: fix out of bound access [ upstream commit 1af9bc9c60291e43aa26f8ee92371c8b04a9b55f ] The value of array index 'i' is out of bound because of the previous loop it has been used. Assuming intention is using '0' since the check before free is robufs[0] check, fixing according. Fixes: ecd867faa860 ("test/reorder: fix freeing mbuf twice") Signed-off-by: Ferruh Yigit --- test/test/test_reorder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test/test_reorder.c b/test/test/test_reorder.c index 6f2c23069..d5f9d2299 100644 --- a/test/test/test_reorder.c +++ b/test/test/test_reorder.c @@ -298,7 +298,7 @@ test_reorder_drain(void) goto exit; } if (robufs[0] != NULL) - rte_pktmbuf_free(robufs[i]); + rte_pktmbuf_free(robufs[0]); /* Insert more packets * RB[] = {NULL, NULL, NULL, NULL} -- 2.11.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-29 15:01:50.094756381 -0800 +++ 0112-test-reorder-fix-out-of-bound-access.patch 2018-11-29 15:01:45.295962000 -0800 @@ -1,8 +1,10 @@ -From 1af9bc9c60291e43aa26f8ee92371c8b04a9b55f Mon Sep 17 00:00:00 2001 +From 58c39aedb3724255b877df3d6d7e71202031ee20 Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Tue, 13 Nov 2018 23:31:37 +0000 Subject: [PATCH] test/reorder: fix out of bound access +[ upstream commit 1af9bc9c60291e43aa26f8ee92371c8b04a9b55f ] + The value of array index 'i' is out of bound because of the previous loop it has been used. @@ -10,7 +12,6 @@ check, fixing according. Fixes: ecd867faa860 ("test/reorder: fix freeing mbuf twice") -Cc: stable@dpdk.org Signed-off-by: Ferruh Yigit --- @@ -18,10 +19,10 @@ 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test/test_reorder.c b/test/test/test_reorder.c -index ccee4d086..58fa9c71b 100644 +index 6f2c23069..d5f9d2299 100644 --- a/test/test/test_reorder.c +++ b/test/test/test_reorder.c -@@ -269,7 +269,7 @@ test_reorder_drain(void) +@@ -298,7 +298,7 @@ test_reorder_drain(void) goto exit; } if (robufs[0] != NULL)