From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 60B9D1B518 for ; Fri, 30 Nov 2018 00:16:06 +0100 (CET) Received: from Internal Mail-Server by MTLPINE1 (envelope-from yskoh@mellanox.com) with ESMTPS (AES256-SHA encrypted); 30 Nov 2018 01:21:59 +0200 Received: from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx [10.101.0.96]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id wATNCW95032075; Fri, 30 Nov 2018 01:16:04 +0200 From: Yongseok Koh To: Shahed Shaikh Cc: dpdk stable Date: Thu, 29 Nov 2018 15:11:59 -0800 Message-Id: <20181129231202.30436-125-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20181129231202.30436-1-yskoh@mellanox.com> References: <20181129231202.30436-1-yskoh@mellanox.com> Subject: [dpdk-stable] patch 'net/qede: fix Tx offload mask' has been queued to LTS release 17.11.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 23:16:06 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/01/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Yongseok --- >>From 9c78277fa68914c557648d83403334ec9ca73e38 Mon Sep 17 00:00:00 2001 From: Shahed Shaikh Date: Wed, 21 Nov 2018 21:20:49 +0000 Subject: [PATCH] net/qede: fix Tx offload mask [ upstream commit 3985ea528a9b74a49af4c8b557b7e145a21692af ] Following commit updated the Tx offload mask commit 1037ed842c37 ("mbuf: fix Tx offload mask"). So, not having PKT_TX_IPV6 and PKT_TX_IPV4 in qede PMDs supported Tx offload mask breaks TSO support since application will fail in transmit prepare function. Fixes: 1037ed842c37 ("mbuf: fix Tx offload mask") Signed-off-by: Shahed Shaikh --- drivers/net/qede/qede_rxtx.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/qede/qede_rxtx.h b/drivers/net/qede/qede_rxtx.h index ae88206d6..9db9fedb2 100644 --- a/drivers/net/qede/qede_rxtx.h +++ b/drivers/net/qede/qede_rxtx.h @@ -145,7 +145,9 @@ PKT_TX_TCP_CKSUM | \ PKT_TX_UDP_CKSUM | \ PKT_TX_OUTER_IP_CKSUM | \ - PKT_TX_TCP_SEG) + PKT_TX_TCP_SEG | \ + PKT_TX_IPV4 | \ + PKT_TX_IPV6) #define QEDE_TX_OFFLOAD_MASK (QEDE_TX_CSUM_OFFLOAD_MASK | \ PKT_TX_QINQ_PKT | \ -- 2.11.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-29 15:01:50.662170242 -0800 +++ 0125-net-qede-fix-Tx-offload-mask.patch 2018-11-29 15:01:45.332960000 -0800 @@ -1,8 +1,10 @@ -From 3985ea528a9b74a49af4c8b557b7e145a21692af Mon Sep 17 00:00:00 2001 +From 9c78277fa68914c557648d83403334ec9ca73e38 Mon Sep 17 00:00:00 2001 From: Shahed Shaikh Date: Wed, 21 Nov 2018 21:20:49 +0000 Subject: [PATCH] net/qede: fix Tx offload mask +[ upstream commit 3985ea528a9b74a49af4c8b557b7e145a21692af ] + Following commit updated the Tx offload mask commit 1037ed842c37 ("mbuf: fix Tx offload mask"). @@ -11,7 +13,6 @@ prepare function. Fixes: 1037ed842c37 ("mbuf: fix Tx offload mask") -Cc: stable@dpdk.org Signed-off-by: Shahed Shaikh --- @@ -19,10 +20,10 @@ 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/qede/qede_rxtx.h b/drivers/net/qede/qede_rxtx.h -index 0afadd8da..454daa07b 100644 +index ae88206d6..9db9fedb2 100644 --- a/drivers/net/qede/qede_rxtx.h +++ b/drivers/net/qede/qede_rxtx.h -@@ -149,7 +149,9 @@ +@@ -145,7 +145,9 @@ PKT_TX_TCP_CKSUM | \ PKT_TX_UDP_CKSUM | \ PKT_TX_OUTER_IP_CKSUM | \ @@ -32,7 +33,7 @@ + PKT_TX_IPV6) #define QEDE_TX_OFFLOAD_MASK (QEDE_TX_CSUM_OFFLOAD_MASK | \ - PKT_TX_VLAN_PKT | \ + PKT_TX_QINQ_PKT | \ -- 2.11.0