From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 7592D1B518 for ; Fri, 30 Nov 2018 00:13:55 +0100 (CET) Received: from Internal Mail-Server by MTLPINE1 (envelope-from yskoh@mellanox.com) with ESMTPS (AES256-SHA encrypted); 30 Nov 2018 01:19:48 +0200 Received: from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx [10.101.0.96]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id wATNCW7m032075; Fri, 30 Nov 2018 01:13:53 +0200 From: Yongseok Koh To: Rasesh Mody Cc: dpdk stable Date: Thu, 29 Nov 2018 15:10:42 -0800 Message-Id: <20181129231202.30436-48-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20181129231202.30436-1-yskoh@mellanox.com> References: <20181129231202.30436-1-yskoh@mellanox.com> Subject: [dpdk-stable] patch 'net/bnx2x: fix call to link handling periodic function' has been queued to LTS release 17.11.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 23:13:55 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/01/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Yongseok --- >>From 2718f06b6c823596c41592a71fe5a583471c1978 Mon Sep 17 00:00:00 2001 From: Rasesh Mody Date: Sat, 29 Sep 2018 05:42:40 +0000 Subject: [PATCH] net/bnx2x: fix call to link handling periodic function [ upstream commit 0f6ebeee2402441b20e45ea27f0ff2a4fc2c165f ] If link handling periodic function is allowed to be called in interrupt context, the periodic function can get called too frequently and exhaust the retry credits to check link status. This change makes sure link handling periodic function is not called in interrupt context. Fixes: 540a211084a7 ("bnx2x: driver core") Signed-off-by: Rasesh Mody --- drivers/net/bnx2x/bnx2x_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c index 650d6ce60..bf176d80e 100644 --- a/drivers/net/bnx2x/bnx2x_ethdev.c +++ b/drivers/net/bnx2x/bnx2x_ethdev.c @@ -188,7 +188,9 @@ bnx2x_interrupt_handler(void *param) PMD_DEBUG_PERIODIC_LOG(INFO, "Interrupt handled"); + atomic_store_rel_long(&sc->periodic_flags, PERIODIC_STOP); bnx2x_interrupt_action(dev); + atomic_store_rel_long(&sc->periodic_flags, PERIODIC_GO); rte_intr_enable(&sc->pci_dev->intr_handle); } -- 2.11.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-29 15:01:47.355917433 -0800 +++ 0048-net-bnx2x-fix-call-to-link-handling-periodic-functio.patch 2018-11-29 15:01:45.106962000 -0800 @@ -1,8 +1,10 @@ -From 0f6ebeee2402441b20e45ea27f0ff2a4fc2c165f Mon Sep 17 00:00:00 2001 +From 2718f06b6c823596c41592a71fe5a583471c1978 Mon Sep 17 00:00:00 2001 From: Rasesh Mody Date: Sat, 29 Sep 2018 05:42:40 +0000 Subject: [PATCH] net/bnx2x: fix call to link handling periodic function +[ upstream commit 0f6ebeee2402441b20e45ea27f0ff2a4fc2c165f ] + If link handling periodic function is allowed to be called in interrupt context, the periodic function can get called too frequently and exhaust the retry credits to check link status. @@ -11,7 +13,6 @@ interrupt context. Fixes: 540a211084a7 ("bnx2x: driver core") -Cc: stable@dpdk.org Signed-off-by: Rasesh Mody --- @@ -19,12 +20,12 @@ 1 file changed, 2 insertions(+) diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c -index ae2e60a06..0057843b5 100644 +index 650d6ce60..bf176d80e 100644 --- a/drivers/net/bnx2x/bnx2x_ethdev.c +++ b/drivers/net/bnx2x/bnx2x_ethdev.c -@@ -131,7 +131,9 @@ bnx2x_interrupt_handler(void *param) +@@ -188,7 +188,9 @@ bnx2x_interrupt_handler(void *param) - PMD_DEBUG_PERIODIC_LOG(INFO, sc, "Interrupt handled"); + PMD_DEBUG_PERIODIC_LOG(INFO, "Interrupt handled"); + atomic_store_rel_long(&sc->periodic_flags, PERIODIC_STOP); bnx2x_interrupt_action(dev);