From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 833281B512 for ; Fri, 30 Nov 2018 00:14:00 +0100 (CET) Received: from Internal Mail-Server by MTLPINE1 (envelope-from yskoh@mellanox.com) with ESMTPS (AES256-SHA encrypted); 30 Nov 2018 01:19:53 +0200 Received: from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx [10.101.0.96]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id wATNCW7p032075; Fri, 30 Nov 2018 01:13:58 +0200 From: Yongseok Koh To: Yongping Zhang Cc: Ajit Khaparde , dpdk stable Date: Thu, 29 Nov 2018 15:10:45 -0800 Message-Id: <20181129231202.30436-51-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20181129231202.30436-1-yskoh@mellanox.com> References: <20181129231202.30436-1-yskoh@mellanox.com> Subject: [dpdk-stable] patch 'net/bnxt: fix registration of VF async event completion ring' has been queued to LTS release 17.11.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 23:14:00 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/01/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Yongseok --- >>From db8802d754ce932c1aef911d991b49390d34c4cb Mon Sep 17 00:00:00 2001 From: Yongping Zhang Date: Fri, 28 Sep 2018 19:00:01 -0700 Subject: [PATCH] net/bnxt: fix registration of VF async event completion ring [ upstream commit 5f267bae3ee6da6ee158276055255b6ef5287caf ] While registering vf's event completion ring to FW, use the wrong macro, FW doesn't set up the event completion ring successfully, VF can't receive any async event. Fixes: 4535cad39515 ("net/bnxt: handle VF/PF initialization appropriately") Signed-off-by: Yongping Zhang Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index db3222f4e..3cadfc341 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -2744,7 +2744,7 @@ int bnxt_hwrm_vf_func_cfg_def_cp(struct bnxt *bp) HWRM_PREP(req, FUNC_VF_CFG); req.enables = rte_cpu_to_le_32( - HWRM_FUNC_CFG_INPUT_ENABLES_ASYNC_EVENT_CR); + HWRM_FUNC_VF_CFG_INPUT_ENABLES_ASYNC_EVENT_CR); req.async_event_cr = rte_cpu_to_le_16( bp->def_cp_ring->cp_ring_struct->fw_ring_id); rc = bnxt_hwrm_send_message(bp, &req, sizeof(req)); -- 2.11.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-29 15:01:47.480975275 -0800 +++ 0051-net-bnxt-fix-registration-of-VF-async-event-completi.patch 2018-11-29 15:01:45.113959000 -0800 @@ -1,14 +1,15 @@ -From 5f267bae3ee6da6ee158276055255b6ef5287caf Mon Sep 17 00:00:00 2001 +From db8802d754ce932c1aef911d991b49390d34c4cb Mon Sep 17 00:00:00 2001 From: Yongping Zhang Date: Fri, 28 Sep 2018 19:00:01 -0700 Subject: [PATCH] net/bnxt: fix registration of VF async event completion ring +[ upstream commit 5f267bae3ee6da6ee158276055255b6ef5287caf ] + While registering vf's event completion ring to FW, use the wrong macro, FW doesn't set up the event completion ring successfully, VF can't receive any async event. Fixes: 4535cad39515 ("net/bnxt: handle VF/PF initialization appropriately") -Cc: stable@dpdk.org Signed-off-by: Yongping Zhang Signed-off-by: Ajit Khaparde @@ -17,18 +18,18 @@ 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c -index 62da254b9..51fe3a4c2 100644 +index db3222f4e..3cadfc341 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c -@@ -3001,7 +3001,7 @@ int bnxt_hwrm_vf_func_cfg_def_cp(struct bnxt *bp) - HWRM_PREP(req, FUNC_VF_CFG, BNXT_USE_CHIMP_MB); +@@ -2744,7 +2744,7 @@ int bnxt_hwrm_vf_func_cfg_def_cp(struct bnxt *bp) + HWRM_PREP(req, FUNC_VF_CFG); req.enables = rte_cpu_to_le_32( - HWRM_FUNC_CFG_INPUT_ENABLES_ASYNC_EVENT_CR); + HWRM_FUNC_VF_CFG_INPUT_ENABLES_ASYNC_EVENT_CR); req.async_event_cr = rte_cpu_to_le_16( bp->def_cp_ring->cp_ring_struct->fw_ring_id); - rc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB); + rc = bnxt_hwrm_send_message(bp, &req, sizeof(req)); -- 2.11.0