From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id 60E281B517 for ; Fri, 30 Nov 2018 00:15:06 +0100 (CET) Received: from Internal Mail-Server by MTLPINE1 (envelope-from yskoh@mellanox.com) with ESMTPS (AES256-SHA encrypted); 30 Nov 2018 01:20:56 +0200 Received: from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx [10.101.0.96]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id wATNCW8S032075; Fri, 30 Nov 2018 01:15:01 +0200 From: Yongseok Koh To: Yongseok Koh Cc: dpdk stable Date: Thu, 29 Nov 2018 15:11:22 -0800 Message-Id: <20181129231202.30436-88-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20181129231202.30436-1-yskoh@mellanox.com> References: <20181129231202.30436-1-yskoh@mellanox.com> Subject: [dpdk-stable] patch 'mk: disable gcc AVX512F support' has been queued to LTS release 17.11.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 23:15:06 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/01/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Yongseok --- >>From c8a1211869451f847fd726a520df800c61dd25a3 Mon Sep 17 00:00:00 2001 From: Yongseok Koh Date: Sat, 3 Nov 2018 01:06:32 +0000 Subject: [PATCH] mk: disable gcc AVX512F support [ upstream commit 8d07c82b239f7782be0d3afbb626390e2cb0c8f5 ] This is a workaround to prevent a crash, which might be caused by optimization of newer gcc (7.3.0) on Intel Skylake. This disables AVX512F support of gcc by adding -mno-avx512f if it is disabled in DPDK (CONFIG_RTE_ENABLE_AVX512=n). This does not apply to the meson build as that doesn't have such an option but always enable AVX512F whenever supported. Bugzilla ID: 97 Signed-off-by: Yongseok Koh --- mk/rte.cpuflags.mk | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk index 64caa3dbc..2129510c2 100644 --- a/mk/rte.cpuflags.mk +++ b/mk/rte.cpuflags.mk @@ -96,6 +96,11 @@ endif ifneq ($(filter $(AUTO_CPUFLAGS),__AVX512F__),) ifeq ($(CONFIG_RTE_ENABLE_AVX512),y) CPUFLAGS += AVX512F +else +# disable AVX512F support of gcc as a workaround for Bug 97 +ifeq ($(CONFIG_RTE_TOOLCHAIN_GCC),y) +MACHINE_CFLAGS += -mno-avx512f +endif endif endif -- 2.11.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-29 15:01:49.093983176 -0800 +++ 0088-mk-disable-gcc-AVX512F-support.patch 2018-11-29 15:01:45.239957000 -0800 @@ -1,8 +1,10 @@ -From 8d07c82b239f7782be0d3afbb626390e2cb0c8f5 Mon Sep 17 00:00:00 2001 +From c8a1211869451f847fd726a520df800c61dd25a3 Mon Sep 17 00:00:00 2001 From: Yongseok Koh Date: Sat, 3 Nov 2018 01:06:32 +0000 Subject: [PATCH] mk: disable gcc AVX512F support +[ upstream commit 8d07c82b239f7782be0d3afbb626390e2cb0c8f5 ] + This is a workaround to prevent a crash, which might be caused by optimization of newer gcc (7.3.0) on Intel Skylake. @@ -13,7 +15,6 @@ but always enable AVX512F whenever supported. Bugzilla ID: 97 -Cc: stable@dpdk.org Signed-off-by: Yongseok Koh --- @@ -21,10 +22,10 @@ 1 file changed, 5 insertions(+) diff --git a/mk/rte.cpuflags.mk b/mk/rte.cpuflags.mk -index 43ed84155..c3291b17a 100644 +index 64caa3dbc..2129510c2 100644 --- a/mk/rte.cpuflags.mk +++ b/mk/rte.cpuflags.mk -@@ -68,6 +68,11 @@ endif +@@ -96,6 +96,11 @@ endif ifneq ($(filter $(AUTO_CPUFLAGS),__AVX512F__),) ifeq ($(CONFIG_RTE_ENABLE_AVX512),y) CPUFLAGS += AVX512F