From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by dpdk.org (Postfix) with ESMTP id A314B1B50A for ; Fri, 30 Nov 2018 00:15:15 +0100 (CET) Received: from Internal Mail-Server by MTLPINE1 (envelope-from yskoh@mellanox.com) with ESMTPS (AES256-SHA encrypted); 30 Nov 2018 01:21:04 +0200 Received: from scfae-sc-2.mti.labs.mlnx (scfae-sc-2.mti.labs.mlnx [10.101.0.96]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id wATNCW8X032075; Fri, 30 Nov 2018 01:15:09 +0200 From: Yongseok Koh To: Jerin Jacob Cc: Ferruh Yigit , dpdk stable Date: Thu, 29 Nov 2018 15:11:27 -0800 Message-Id: <20181129231202.30436-93-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20181129231202.30436-1-yskoh@mellanox.com> References: <20181129231202.30436-1-yskoh@mellanox.com> Subject: [dpdk-stable] patch 'doc: clarify TSO Tx offload prerequisite' has been queued to LTS release 17.11.5 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2018 23:15:16 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.5 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/01/18. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. If the code is different (ie: not only metadata diffs), due for example to a change in context or macro names, please double check it. Thanks. Yongseok --- >>From 83526c9d4f4b49a4b4b44b21be19ac70a3ccc733 Mon Sep 17 00:00:00 2001 From: Jerin Jacob Date: Thu, 1 Nov 2018 08:46:42 +0000 Subject: [PATCH] doc: clarify TSO Tx offload prerequisite [ upstream commit 25b85ae5db74820aab71e07f88e01c3d93932eff ] Based on the PKT_TX_TCP_SEG definition, the application needs to update PKT_TX_IPV4 or PKT_TX_IPV6 based on IPV4 or IPV6 packet and PKT_TX_IP_CKSUM ol_flags to enable Tx TSO offload. Fixes: dad1ec72a377 ("doc: document NIC features") Signed-off-by: Jerin Jacob Acked-by: Ferruh Yigit --- doc/guides/nics/features.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst index 69c579404..f31aee930 100644 --- a/doc/guides/nics/features.rst +++ b/doc/guides/nics/features.rst @@ -235,7 +235,7 @@ Supports TCP Segmentation Offloading. * **[uses] rte_eth_txconf,rte_eth_txmode**: ``offloads:DEV_TX_OFFLOAD_TCP_TSO``. * **[uses] rte_eth_desc_lim**: ``nb_seg_max``, ``nb_mtu_seg_max``. -* **[uses] mbuf**: ``mbuf.ol_flags:PKT_TX_TCP_SEG``. +* **[uses] mbuf**: ``mbuf.ol_flags:`` ``PKT_TX_TCP_SEG``, ``PKT_TX_IPV4``, ``PKT_TX_IPV6``, ``PKT_TX_IP_CKSUM``. * **[uses] mbuf**: ``mbuf.tso_segsz``, ``mbuf.l2_len``, ``mbuf.l3_len``, ``mbuf.l4_len``. * **[implements] datapath**: ``TSO functionality``. * **[provides] rte_eth_dev_info**: ``tx_offload_capa,tx_queue_offload_capa:DEV_TX_OFFLOAD_TCP_TSO,DEV_TX_OFFLOAD_UDP_TSO``. -- 2.11.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2018-11-29 15:01:49.301782839 -0800 +++ 0093-doc-clarify-TSO-Tx-offload-prerequisite.patch 2018-11-29 15:01:45.247958000 -0800 @@ -1,15 +1,16 @@ -From 25b85ae5db74820aab71e07f88e01c3d93932eff Mon Sep 17 00:00:00 2001 +From 83526c9d4f4b49a4b4b44b21be19ac70a3ccc733 Mon Sep 17 00:00:00 2001 From: Jerin Jacob Date: Thu, 1 Nov 2018 08:46:42 +0000 Subject: [PATCH] doc: clarify TSO Tx offload prerequisite +[ upstream commit 25b85ae5db74820aab71e07f88e01c3d93932eff ] + Based on the PKT_TX_TCP_SEG definition, the application needs to update PKT_TX_IPV4 or PKT_TX_IPV6 based on IPV4 or IPV6 packet and PKT_TX_IP_CKSUM ol_flags to enable Tx TSO offload. Fixes: dad1ec72a377 ("doc: document NIC features") -Cc: stable@dpdk.org Signed-off-by: Jerin Jacob Acked-by: Ferruh Yigit @@ -18,10 +19,10 @@ 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst -index 3fa5cb745..d3f904839 100644 +index 69c579404..f31aee930 100644 --- a/doc/guides/nics/features.rst +++ b/doc/guides/nics/features.rst -@@ -208,7 +208,7 @@ Supports TCP Segmentation Offloading. +@@ -235,7 +235,7 @@ Supports TCP Segmentation Offloading. * **[uses] rte_eth_txconf,rte_eth_txmode**: ``offloads:DEV_TX_OFFLOAD_TCP_TSO``. * **[uses] rte_eth_desc_lim**: ``nb_seg_max``, ``nb_mtu_seg_max``.