From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.tuxdriver.com (charlotte.tuxdriver.com [70.61.120.58]) by dpdk.org (Postfix) with ESMTP id D86972BE6; Tue, 4 Dec 2018 16:20:02 +0100 (CET) Received: from cpe-2606-a000-111b-405a-a193-cb97-58ba-1c15.dyn6.twc.com ([2606:a000:111b:405a:a193:cb97:58ba:1c15] helo=localhost) by smtp.tuxdriver.com with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.63) (envelope-from ) id 1gTwbF-0003qA-SD; Mon, 03 Dec 2018 17:22:09 -0500 Date: Tue, 4 Dec 2018 10:18:53 -0500 From: Neil Horman To: David Marchand Cc: dev@dpdk.org, stable@dpdk.org, tredaelli@redhat.com, ferruh.yigit@intel.com, ivan.malov@oktetlabs.ru, arybchenko@solarflare.com Message-ID: <20181204151853.GB31778@hmswarspite.think-freely.org> References: <1543912111-8106-1-git-send-email-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1543912111-8106-1-git-send-email-david.marchand@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Score: 0.3 (/) X-Spam-Status: No Subject: Re: [dpdk-stable] [PATCH] log: add missing experimental tag X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Dec 2018 15:20:03 -0000 On Tue, Dec 04, 2018 at 09:28:31AM +0100, David Marchand wrote: > When rte_log_register_type_and_pick_level() has been introduced, it has > been correctly added to the EXPERIMENTAL section of the eal map and the > symbol itself has been marked at its definition. > > However, the declaration of this symbol in rte_log.h is missing the > __rte_experimental tag. > Because of this, a user can try to call this symbol without being aware > this is an experimental api (neither compilation nor link warning). > > Fixes: b22e77c02620 ("eal: register log type and pick level from args") > Signed-off-by: David Marchand > --- > lib/librte_eal/common/include/rte_log.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/lib/librte_eal/common/include/rte_log.h b/lib/librte_eal/common/include/rte_log.h > index 2f789cb..f334efc 100644 > --- a/lib/librte_eal/common/include/rte_log.h > +++ b/lib/librte_eal/common/include/rte_log.h > @@ -24,6 +24,7 @@ > > #include > #include > +#include > > struct rte_log_dynamic_type; > > @@ -226,6 +227,7 @@ struct rte_logs { > * - >=0: the newly registered log type > * - <0: rte_log_register() error value > */ > +__rte_experimental > int rte_log_register_type_and_pick_level(const char *name, uint32_t level_def); > > /** > -- > 1.8.3.1 > > Acked-by: Neil Horman