From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout1.w1.samsung.com (mailout1.w1.samsung.com [210.118.77.11]) by dpdk.org (Postfix) with ESMTP id 1692225D9 for ; Tue, 22 Jan 2019 17:27:23 +0100 (CET) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20190122162722euoutp010cd67a21a3b8aabfd7826b5faa7b35af~8OHPfUTKg0881108811euoutp01Y for ; Tue, 22 Jan 2019 16:27:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20190122162722euoutp010cd67a21a3b8aabfd7826b5faa7b35af~8OHPfUTKg0881108811euoutp01Y DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1548174442; bh=q6DEmYJzTGC6NChfoqxDcKPKDC/1rB3mluicyZVD2E0=; h=From:To:Cc:Subject:Date:References:From; b=B6tXLipHUqB0aekhLyCQRKFBsV7J6bBeTTgh64OZhu9RDZSMMYII+VLr3JY6luINV aBxSoWtbdlL/YREzyJlusBr52Rpoo0CnT7F+MdfL3fmK5NBM+EhtlPdwj2Ni9asaB/ xTLc39KEv2BzeDHactwRDcvLHND03q1PIfsS6414= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20190122162721eucas1p21f8e32a969ee437ebc74086e44b67b02~8OHPAtJdx1473714737eucas1p2x; Tue, 22 Jan 2019 16:27:21 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 0E.50.04294.964474C5; Tue, 22 Jan 2019 16:27:21 +0000 (GMT) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20190122162720eucas1p1a9b93996c3a9384ba141313d3de9e37a~8OHOKH6cN1324213242eucas1p1E; Tue, 22 Jan 2019 16:27:20 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20190122162720eusmtrp100cc6734adf5ab5f2fab613bce59f696~8OHN7_hRu0172601726eusmtrp1T; Tue, 22 Jan 2019 16:27:20 +0000 (GMT) X-AuditID: cbfec7f4-84fff700000010c6-be-5c47446996a1 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 32.66.04128.864474C5; Tue, 22 Jan 2019 16:27:20 +0000 (GMT) Received: from imaximets.rnd.samsung.ru (unknown [106.109.129.180]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20190122162719eusmtip2aa329e20e4d956bb3a25b8e530f489b9~8OHNKsnv72152221522eusmtip2w; Tue, 22 Jan 2019 16:27:19 +0000 (GMT) From: Ilya Maximets To: dev@dpdk.org, Anatoly Burakov Cc: Thomas Monjalon , Ilya Maximets , stable@dpdk.org Date: Tue, 22 Jan 2019 19:27:14 +0300 Message-Id: <20190122162714.9144-1-i.maximets@samsung.com> X-Mailer: git-send-email 2.17.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrHIsWRmVeSWpSXmKPExsWy7djPc7qZLu4xBtPPyVg8ureY2eLdp+1M Flfaf7Jb/Ov4w27x6cEJFgdWj18LlrJ6LN7zksnj2M1p7B59W1YxBrBEcdmkpOZklqUW6dsl cGUs6L3OVLCds2LVvz7mBsab7F2MnBwSAiYSx7ZMZ+xi5OIQEljBKPHy1T5WCOcLo8SW0+3M EM5nRonGqS0sXYwcYC3zHuhBxJczSrx+cpAdwvnBKHHl2S5mkLlsAjoSp1YfYQSxRQRsJf7e 2A+2j1kgReLvpVcsILawgL3ExicvwOpZBFQlXi+4yARi8wpYSWyatpEV4j55idUbDoBdISFw gE2ivXcuE0TCRWLvxp9QTwhLvDq+BcqWkTg9uYcFwq6XuN/ykhGiuYNRYvqhf1DN9hJbXp9j B3mHWUBTYv0ufYjPHCXuTuODMPkkbrwVhDiZT2LStunMEGFeiY42IYgZKhK/Dy5nhrClJG6+ +8wOUeIhcWxtAEhYSCBWYkLrGpYJjHKzEDYtYGRcxSieWlqcm55abJSXWq5XnJhbXJqXrpec n7uJERjrp/8d/7KDcdefpEOMAhyMSjy8P8zcY4RYE8uKK3MPMUpwMCuJ8LpedIsR4k1JrKxK LcqPLyrNSS0+xCjNwaIkzlvN8CBaSCA9sSQ1OzW1ILUIJsvEwSnVwNjZUn3rULWpUraM3mfj PywcnGtY3izLrN9RfMs6yb3fmu88l33/ii0e3b3rJzdZsO7vmyrUynHl5vf2+HDJI+5BKqnc aucyzBQq3lR2x4hel8ne2PEqvSDZ4fYra92uqx+afm2uOCtjVMgTxzM/iDGM03ve/SWX6jOd ZzS6sk826Vy7IKNRiaU4I9FQi7moOBEApAa8gvECAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrKLMWRmVeSWpSXmKPExsVy+t/xe7oZLu4xBjdeylg8ureY2eLdp+1M Flfaf7Jb/Ov4w27x6cEJFgdWj18LlrJ6LN7zksnj2M1p7B59W1YxBrBE6dkU5ZeWpCpk5BeX 2CpFG1oY6RlaWugZmVjqGRqbx1oZmSrp29mkpOZklqUW6dsl6GUs6L3OVLCds2LVvz7mBsab 7F2MHBwSAiYS8x7odTFycQgJLGWU6O3cztLFyAkUl5L48esCK4QtLPHnWhcbRNE3RomfC+eC FbEJ6EicWn2EEcQWEbCXuPyzmw1kKLNAmkTPn1yQsDBQeOOTF8wgNouAqsTrBReZQGxeASuJ TdM2Qs2Xl1i94QDzBEaeBYwMqxhFUkuLc9Nzi430ihNzi0vz0vWS83M3MQKDbNuxn1t2MHa9 Cz7EKMDBqMTD+8PMPUaINbGsuDL3EKMEB7OSCK/rRbcYId6UxMqq1KL8+KLSnNTiQ4ymQMsn MkuJJucDIyCvJN7Q1NDcwtLQ3Njc2MxCSZz3vEFllJBAemJJanZqakFqEUwfEwenVANj741q Jss6l/iIQKv1AU5rXNXFjv+T+D279Krv3LmMQYUneNV+93bOfeAWmGszf8pKnV++k5acSBDY lperale/pH6yyoep/6a/XBj9KVhL7t+Byw//tsn+bHUMfvBm6zc7Tg2RJb3pZx4Kh71/sXLv v31bS3Z1Hi2z3j1tp4NqRtsSXy+P/7oZSizFGYmGWsxFxYkAWCNHIEgCAAA= X-CMS-MailID: 20190122162720eucas1p1a9b93996c3a9384ba141313d3de9e37a X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20190122162720eucas1p1a9b93996c3a9384ba141313d3de9e37a X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20190122162720eucas1p1a9b93996c3a9384ba141313d3de9e37a References: Subject: [dpdk-stable] [PATCH] eal: fix parsing zero socket memory and limits X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jan 2019 16:27:23 -0000 Modern memory mode allowes to not reserve any memory by the '--socket-mem' option. i.e. it could be possible to specify zero preallocated memory like '--socket-mem 0'. Also, it should be possible to configure unlimited memory allocations by '--socket-limit 0'. Both cases are impossible now and blocks starting the DPDK application: ./dpdk-app --socket-limit 0 <...> EAL: invalid parameters for --socket-limit EAL: Invalid 'command line' arguments. Unable to initialize DPDK: Invalid argument Fixes: 6b42f75632f0 ("eal: enable non-legacy memory mode") Cc: stable@dpdk.org Signed-off-by: Ilya Maximets --- lib/librte_eal/linuxapp/eal/eal.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c index a386829f3..13f401684 100644 --- a/lib/librte_eal/linuxapp/eal/eal.c +++ b/lib/librte_eal/linuxapp/eal/eal.c @@ -582,10 +582,6 @@ eal_parse_socket_arg(char *strval, volatile uint64_t *socket_arg) socket_arg[i] = val; } - /* check if we have a positive amount of total memory */ - if (total_mem == 0) - return -1; - return 0; } -- 2.17.1