From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id D8DA03256; Mon, 25 Feb 2019 09:34:03 +0100 (CET) Received: from lfbn-1-5920-128.w90-110.abo.wanadoo.fr ([90.110.126.128] helo=droids-corp.org) by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gyBkB-0001BD-8F; Mon, 25 Feb 2019 09:36:12 +0100 Received: by droids-corp.org (sSMTP sendmail emulation); Mon, 25 Feb 2019 09:33:59 +0100 Date: Mon, 25 Feb 2019 09:33:59 +0100 From: Olivier Matz To: "Burakov, Anatoly" Cc: David Marchand , dev@dpdk.org, ktraynor@redhat.com, stable@dpdk.org Message-ID: <20190225083359.uzvwejkej3elyqdh@platinum> References: <1550151042-9764-1-git-send-email-david.marchand@redhat.com> <1550608871-5251-1-git-send-email-david.marchand@redhat.com> <1550608871-5251-2-git-send-email-david.marchand@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-stable] [PATCH v3 2/2] eal: restrict ctrl threads to startup cpu affinity X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Feb 2019 08:34:04 -0000 On Wed, Feb 20, 2019 at 04:01:33PM +0000, Burakov, Anatoly wrote: > On 19-Feb-19 8:41 PM, David Marchand wrote: > > Spawning the ctrl threads on anything that is not part of the eal > > coremask is not that polite to the rest of the system, especially > > when you took good care to pin your processes on cpu resources with > > tools like taskset (linux) / cpuset (freebsd). > > > > Rather than introduce yet another eal options to control on which cpu > > those ctrl threads are created, let's take the startup cpu affinity > > as a reference and remove the eal coremask from it. > > If no cpu is left, then we default to the master core. > > > > The cpuset is computed once at init before the original cpu affinity > > is lost. > > > > Introduced a RTE_CPU_AND macro to abstract the differences between linux > > and freebsd respective macros. > > > > Examples in a 4 cores FreeBSD vm: > > > > $ ./build/app/testpmd -l 2,3 --no-huge --no-pci -m 512 \ > > -- -i --total-num-mbufs=2048 > > > > $ procstat -S 1057 > > PID TID COMM TDNAME CPU CSID CPU MASK > > 1057 100131 testpmd - 2 1 2 > > 1057 100140 testpmd eal-intr-thread 1 1 0-1 > > 1057 100141 testpmd rte_mp_handle 1 1 0-1 > > 1057 100142 testpmd lcore-slave-3 3 1 3 > > > > $ cpuset -l 1,2,3 ./build/app/testpmd -l 2,3 --no-huge --no-pci -m 512 \ > > -- -i --total-num-mbufs=2048 > > > > $ procstat -S 1061 > > PID TID COMM TDNAME CPU CSID CPU MASK > > 1061 100131 testpmd - 2 2 2 > > 1061 100144 testpmd eal-intr-thread 1 2 1 > > 1061 100145 testpmd rte_mp_handle 1 2 1 > > 1061 100147 testpmd lcore-slave-3 3 2 3 > > > > $ cpuset -l 2,3 ./build/app/testpmd -l 2,3 --no-huge --no-pci -m 512 \ > > -- -i --total-num-mbufs=2048 > > > > $ procstat -S 1065 > > PID TID COMM TDNAME CPU CSID CPU MASK > > 1065 100131 testpmd - 2 2 2 > > 1065 100148 testpmd eal-intr-thread 2 2 2 > > 1065 100149 testpmd rte_mp_handle 2 2 2 > > 1065 100150 testpmd lcore-slave-3 3 2 3 > > > > Fixes: d651ee4919cd ("eal: set affinity for control threads") > > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > > --- > > Reviewed-by: Anatoly Burakov Reviewed-by: Olivier Matz