From: Stephen Hemminger <stephen@networkplumber.org>
To: olegpoly123 <olegp123@walla.co.il>
Cc: keith.wiles@intel.com, thomas@monjalon.net, dev@dpdk.org,
stable@dpdk.org, Oeg Polyakov <opolyakov@northforgeinc.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2 1/2] net/tap: fix missing _SC_IOV_MAX
Date: Fri, 8 Mar 2019 09:29:37 -0800 [thread overview]
Message-ID: <20190308092937.05330e54@shemminger-XPS-13-9360> (raw)
In-Reply-To: <20190308155547.1695-1-olegp123@walla.co.il>
On Fri, 8 Mar 2019 10:55:46 -0500
olegpoly123 <olegp123@walla.co.il> wrote:
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index 6f5109fca..cd48b2b2a 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -1326,6 +1326,11 @@ tap_rx_queue_setup(struct rte_eth_dev *dev,
> struct rx_queue *rxq = &internals->rxq[rx_queue_id];
> struct rte_mbuf **tmp = &rxq->pool;
> long iov_max = sysconf(_SC_IOV_MAX);
> + if (iov_max <= 0) {
> + TAP_LOG(WARNING,
> + "_SC_IOV_MAX is not defined. Using 1024 as default\n");
> + iov_max = 1024;
> + }
Blank line between declarations and code please.
This should never happen except for redhat bug: https://bugzilla.redhat.com/show_bug.cgi?id=1504165
prev parent reply other threads:[~2019-03-08 17:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190308155547.1695-1-olegp123@walla.co.il>
[not found] ` <20190308155547.1695-2-olegp123@walla.co.il>
2019-03-08 16:33 ` [dpdk-stable] [PATCH v2 2/2] Define macro for iov_max default value Wiles, Keith
2019-03-08 17:29 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190308092937.05330e54@shemminger-XPS-13-9360 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
--cc=olegp123@walla.co.il \
--cc=opolyakov@northforgeinc.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).